You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@seatunnel.apache.org by GitBox <gi...@apache.org> on 2022/09/23 08:58:15 UTC
[GitHub] [incubator-seatunnel] liugddx opened a new pull request, #2862: [Improve][flink-api]extraction unified method
liugddx opened a new pull request, #2862:
URL: https://github.com/apache/incubator-seatunnel/pull/2862
<!--
Thank you for contributing to SeaTunnel! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
## Contribution Checklist
- Make sure that the pull request corresponds to a [GITHUB issue](https://github.com/apache/incubator-seatunnel/issues).
- Name the pull request in the form "[Feature] [component] Title of the pull request", where *Feature* can be replaced by `Hotfix`, `Bug`, etc.
- Minor fixes should be named following this pattern: `[hotfix] [docs] Fix typo in README.md doc`.
-->
## Purpose of this pull request
<!-- Describe the purpose of this pull request. For example: This pull request adds checkstyle plugin.-->
extraction unified method
## Check list
* [ ] Code changed are covered with tests, or it does not need tests for reason:
* [ ] If any new Jar binary package adding in your PR, please add License Notice according
[New License Guide](https://github.com/apache/incubator-seatunnel/blob/dev/docs/en/contribution/new-license.md)
* [ ] If necessary, please update the documentation to describe the new feature. https://github.com/apache/incubator-seatunnel/tree/dev/docs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] liugddx commented on pull request #2862: [Improve][flink-api]extraction unified method
Posted by GitBox <gi...@apache.org>.
liugddx commented on PR #2862:
URL: https://github.com/apache/incubator-seatunnel/pull/2862#issuecomment-1259211066
Hi,please rerun CI. @EricJoy2048
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] Hisoka-X commented on a diff in pull request #2862: [Improve][flink-api]extraction unified method
Posted by GitBox <gi...@apache.org>.
Hisoka-X commented on code in PR #2862:
URL: https://github.com/apache/incubator-seatunnel/pull/2862#discussion_r979907946
##########
seatunnel-apis/seatunnel-api-flink/src/main/java/org/apache/seatunnel/flink/FlinkEnvironment.java:
##########
@@ -322,4 +325,18 @@ private void setCheckpoint() {
}
}
+ public void registerResultTable(Config config, String tableName, DataStream<Row> dataStream) {
Review Comment:
tableName always be `RESULT_TABLE_NAME`, so you can remove it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] liugddx commented on pull request #2862: [Improve][flink-api]extraction unified method
Posted by GitBox <gi...@apache.org>.
liugddx commented on PR #2862:
URL: https://github.com/apache/incubator-seatunnel/pull/2862#issuecomment-1260289469
please rerun CI. @EricJoy2048
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] ashulin merged pull request #2862: [Improve][flink-api]extraction unified method
Posted by GitBox <gi...@apache.org>.
ashulin merged PR #2862:
URL: https://github.com/apache/incubator-seatunnel/pull/2862
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] liugddx commented on a diff in pull request #2862: [Improve][flink-api]extraction unified method
Posted by GitBox <gi...@apache.org>.
liugddx commented on code in PR #2862:
URL: https://github.com/apache/incubator-seatunnel/pull/2862#discussion_r979919828
##########
seatunnel-apis/seatunnel-api-flink/src/main/java/org/apache/seatunnel/flink/FlinkEnvironment.java:
##########
@@ -322,4 +325,18 @@ private void setCheckpoint() {
}
}
+ public void registerResultTable(Config config, String tableName, DataStream<Row> dataStream) {
Review Comment:
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] liugddx commented on pull request #2862: [Improve][flink-api]extraction unified method
Posted by GitBox <gi...@apache.org>.
liugddx commented on PR #2862:
URL: https://github.com/apache/incubator-seatunnel/pull/2862#issuecomment-1258913860
> CI is error ,and i think it's because the `JdbcPostgresIT` and `JdbcMysqlIT` are unstable.and i tested it locally and the error also happen. so i fix it in #2907 .
@EricJoy2048 please rerun CI,thanks. CC @ic4y
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] liugddx commented on pull request #2862: [Improve][flink-api]extraction unified method
Posted by GitBox <gi...@apache.org>.
liugddx commented on PR #2862:
URL: https://github.com/apache/incubator-seatunnel/pull/2862#issuecomment-1258913031
CI is error ,and i think it's because the `JdbcPostgresIT` and `JdbcMysqlIT` are unstable.and i tested it locally and the error also happen. so i fix it in #2907 .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] EricJoy2048 commented on pull request #2862: [Improve][flink-api]extraction unified method
Posted by GitBox <gi...@apache.org>.
EricJoy2048 commented on PR #2862:
URL: https://github.com/apache/incubator-seatunnel/pull/2862#issuecomment-1258918233
> #2907
Ok, I will rerun the failed job after the https://github.com/apache/incubator-seatunnel/pull/2907 been merged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org