[GitHub] sijie opened a new pull request #1251: BP-29 (task 4): use metadata service uri for constructing registration manager and ledger manager factory

[GitBox <gi...@apache.org>]

sijie opened a new pull request #1251: BP-29 (task 4): use metadata service uri for constructing registration manager and ledger manager factory
URL: https://github.com/apache/bookkeeper/pull/1251
 
 
   Descriptions of the changes in this PR:
   
   The main changes are at two places:
   
   - Deprecating using ServerConfiguration#getRegistrationManagerClass(). Changed Bookie.java to use MetadataBookieDriver to getRegistrationManager().
   - Use MetadataBookieDriver/MetadataClientDriver to retrieve ledger manager factory in Bookie.java / BookKeeper.java
   
   The other changes are in-place changes for replacing using registration manager to using metadata drivers.
   
   - provides a few util functions in `MetadataDrivers` to run `functions` with registration manager / ledger manager factory
   
   
   Master Issue: #1123 
   
   > ---
   > Be sure to do all of the following to help us incorporate your contribution
   > quickly and easily:
   >
   > If this PR is a BookKeeper Proposal (BP):
   >
   > - [ ] Make sure the PR title is formatted like:
   >     `<BP-#>: Description of bookkeeper proposal`
   >     `e.g. BP-1: 64 bits ledger is support`
   > - [ ] Attach the master issue link in the description of this PR.
   > - [ ] Attach the google doc link if the BP is written in Google Doc.
   >
   > Otherwise:
   > 
   > - [ ] Make sure the PR title is formatted like:
   >     `<Issue #>: Description of pull request`
   >     `e.g. Issue 123: Description ...`
   > - [ ] Make sure tests pass via `mvn clean apache-rat:check install spotbugs:check`.
   > - [ ] Replace `<Issue #>` in the title with the actual Issue number.
   > 
   > ---
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services