[GitHub] [openwhisk] style95 commented on a diff in pull request #5400: upgrade kafka client library to 2.8.2

["style95 (via GitHub)" <gi...@apache.org>]

style95 commented on code in PR #5400:
URL: https://github.com/apache/openwhisk/pull/5400#discussion_r1183178655


##########
core/monitoring/user-events/src/test/scala/org/apache/openwhisk/core/monitoring/metrics/KafkaSpecBase.scala:
##########
@@ -30,11 +30,25 @@ abstract class KafkaSpecBase
     with ScalaFutures
     with FlatSpecLike
     with EmbeddedKafka
-    with EmbeddedKafkaLike
     with IntegrationPatience
     with Eventually
     with EventsTestHelper { this: Suite =>
-  implicit val timeoutConfig: PatienceConfig = PatienceConfig(1.minute)
+  implicit val timeoutConfig: PatienceConfig = PatienceConfig(5.minute)
   override val sleepAfterProduce: FiniteDuration = 10.seconds
-  override protected val topicCreationTimeout = 60.seconds
+  override protected val topicCreationTimeout = 120.seconds

Review Comment:
   I am just curious if this is to apply different timeouts for topic creation and publishing timeout or if there was any case that topic creation takes more than 60s.
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@openwhisk.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org