You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@myfaces.apache.org by Sean Schofield <se...@gmail.com> on 2005/03/30 17:49:07 UTC

Re: webapp resources problem

Sylvain,

There are definitely some issues with all of these build files.  I'd
really like to get rid of the separate directories under the build
directory (such as build/examples-webapp.)  IMO they just create a lot
of clutter since they only really contain a build file specific to the
webapp in question.

I wrote build-webapps.xml for two reasons.  The first is related to
the nightly build process.  I didn't want to have CATALINA_HOME, etc.
setup on the build machine which was basically required because of
some of the optional ant tasks used to deploy the webapps.  The second
is that its difficult to maintain all of these separate build files.

The build-webapps.xml file works great right now but it doesn't handle
the deploy stuff.  Here is what I propose.  We should write a new
buildfile: deploy-webapps.xml that will handle the deployment of jars
already built using build-webapps.xml.  Could you write such a build
script (using build-webapps.xml as a model?)  I'm not a big fan of
deploying using Ant .  I've had some trouble with it in the past and
so I don't usually use it.  So I'm probably not the best person for
this.

Once that is up and running for all the webapps, we can drop the
subdirectories in build.  One suggestion though.  Lets not drop any
more directories or move anything around until 1.0.9 is released.  We
don't want to make the testing of the RC any more confusing.

Thoughts?

sean


On Wed, 30 Mar 2005 11:39:22 -0400, Sylvain Vieujot <sv...@freelance.com> wrote:
>  Yes, doing that it works fine.
>  Thanks.
>  
>  Hello Sean,
>  
>  I ran into problems deploying the examples webapp.
>  Thanks to Matthias, I found that the build file that's in
> build/examples-webapp isn't in sync with the main build all process.
>  
>  Indeed, if you build the examples webapp with this build file, you don't
> get the myfaces-examples.jar. Instead, the classes go directly in
> WEB-INF/classes, and the resources aren't located in the right directory, as
> they go in /WEB-INF/classes/example/org/apache..... instead of the expected
> /WEB-INF/classes/org/apache....
>  
>  Anyway, I think this build file might better be removed, or upgraded to use
> the same build process with the build-webapps.xml file.
>  The reason I was using this build/examples-webapp/build.xml file is that it
> can directly deploy the webapp which is handy when you're doing tests.
>  
>  Thanks,
>  
>  Sylvain.
>  
>  
>  On Wed, 2005-03-30 at 17:10 +0200, Matthias Wessendorf wrote: 
>  clean-all and after that all Sean created some patches for simplifing the
> example web apps Can you try them on your box? (the tasks) ? -Matthias
> Sylvain Vieujot wrote: > Yes, we definitely have different war files, and
> yours looks good. > What target do you launch ? > > I launch the default
> target (run-examples) from build/examples- > webapp/build.xml > > Sylvain. >
> > On Wed, 2005-03-30 at 14:00 +0200, Matthias Wessendorf wrote: > > >>here
> WEB-INF/lib >> >>contains "myfaces-examples.jar" >> >>HTH, >>Matthias >>
> >>Sylvain Vieujot wrote: >> >>>Yes, please use this address. >>> >>>Thanks.
> >>> >>>Sylvain. >>> >>>On Wed, 2005-03-30 at 08:08 +0200, Matthias
> Wessendorf wrote: >>> >>> >>> >>>>Sorry, >>>> >>>>but the APACHE mailserver
> doesn't love *big* >>>>files, so can you mail me another email address? >>>>
> >>>>That I can use for sending you the WAR file, build on my box. >>>>
> >>>>-Matthias >>>> >>>>Sylvain Vieujot wrote: >>>> >>>> >>>>>In fact, I just
> find that in the war, the resources are in /WEB-
> >>>>>INF/classes/example/org/apache..... instead of the expected /WEB-
> >>>>>INF/classes/org/apache.... >>>>> >>>>>But I wonder how it could be that
> it works on your machine. >>>>>Maybe you didn't make a clean before
> compiling, and you have them in >>>>>both locations. >>>>> >>>>>Could you
> try to expand your myfaces-examples.war, and check this ? >>>>> >>>>>Thanks,
> >>>>> >>>>>Sylvain. >>>>> >>>>>On Tue, 2005-03-29 at 09:37 +0200, Matthias
> Wessendorf wrote: >>>>> >>>>> >>>>> >>>>> >>>>>>Sylvain, >>>>>> >>>>>>I just
> looked at example WEB-APP and all seams >>>>>>to be fine. I build it just
> some minutes before. >>>>>> >>>>>>All messages are displayed like expected.
> >>>>>>(see GIF) >>>>>> >>>>>>Did I (again) miss something`? >>>>>>-Matthias
> >>>>>> >>>>>>Sylvain Vieujot wrote: >>>>>> >>>>>> >>>>>> >>>>>>>Hello
> Matthias, >>>>>>> >>>>>>>Thank you. >>>>>>>Indeed, now it compiles, but they
> are still some problems with the >>>>>>>property files. >>>>>>>I guess they
> aren't included in the webapp as all the messages are empty >>>>>>>(in the
> examples-webapp). >>>>>>> >>>>>>>Sylvain. >>>>>>> >>>>>>>On Mon, 2005-03-28
> at 18:26 +0200, Matthias Wessendorf wrote: >>>>>>> >>>>>>> >>>>>>> >>>>>>>
> >>>>>>> >>>>>>>>Sylvain, >>>>>>>> >>>>>>>>thanks for pointing it out!
> >>>>>>>>and yes Sean was right, it was me. >>>>>>>> >>>>>>>>I just removed
> >>>>>>>>MYFACES_HOME/webapps/src/org/** >>>>>>>> >>>>>>> >>>>>>>>from now
> there should only: >>>>>>> >>>>>>> >>>>>>>
> >>>>>>>>MYFACES_HOME/webapps/src/blank
> >>>>>>>>MYFACES_HOME/webapps/src/examples
> >>>>>>>>MYFACES_HOME/webapps/src/tiles >>>>>>>>MYFACES_HOME/webapps/src/wap
> >>>>>>>> >>>>>>>>Also, I changed the build file *before* >>>>>>>>deleting
> the mentioned files. >>>>>>>>On my box the task "all" works. >>>>>>>>
> >>>>>>>>In >>>>>>>> >>>>>>>>MYFACES_HOME/build/release >>>>>>>>
> >>>>>>>>there should after that three TGZ >>>>>>>>-src >>>>>>>>-bin
> >>>>>>>>-app >>>>>>>> >>>>>>>>Did I miss something? >>>>>>>>-Matthias
> >>>>>>>> >>>>>>>>Sylvain Vieujot wrote: >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>>
> >>>>>>>>>Done. >>>>>>>>> >>>>>>>>>In the process, I found that there is a
> mess in the webapps sources. >>>>>>>>>Right now, we have 2 trees with the
> same webapps beans sources, and so, >>>>>>>>>the webapps don't compile
> anymore. >>>>>>>>> >>>>>>>>>I didn't fix this, as I guess someone is the
> process of refactoring >>>>>>>>>this, and I'm not sure what the final
> structure should be. >>>>>>>>> >>>>>>>>>Sylvain. >>>>>>>>> >>>>>>>>>On Fri,
> 2005-03-25 at 22:02 +0100, Manfred Geiler wrote: >>>>>>>>> >>>>>>>>>
> >>>>>>>>> >>>>>>>>> >>>>>>>>> >>>>>>>>> >>>>>>>>>>+1 >>>>>>>>>> >>>>>>>>>>
> >>>>>>>>>>On Fri, 25 Mar 2005 16:00:25 -0400, Sylvain Vieujot
> <sv...@apache.org> wrote: >>>>>>>>>> >>>>>>>>>> >>>>>>>>>> >>>>>>>>>>
> >>>>>>>>>> >>>>>>>>>>>Before we do the 1.0.9 release, I thought it would be
> good to rename the >>>>>>>>>>>x:htmlEditor to x:inputHtml as it fits better
> with the standard JSF naming >>>>>>>>>>>convention. >>>>>>>>>>>
> >>>>>>>>>>>Any thoughts ? >>>>>>>>>>> >>>>>>>>>>>Sylvain. >>>>>>>>>
> >>>>>>>>> >>> >>> >

Re: webapp resources problem

Posted by Sylvain Vieujot <sv...@apache.org>.
To be short :

- I agree not to change anything before the release (except the small
update I did to the main build.xml to fix MYFACES-153).

- I didn't had time to think about the deploy-webapps right now, but
yes, I'm ready to work on it after the release.

Sylvain.

On Wed, 2005-03-30 at 10:49 -0500, Sean Schofield wrote:

> Sylvain,
> 
> There are definitely some issues with all of these build files.  I'd
> really like to get rid of the separate directories under the build
> directory (such as build/examples-webapp.)  IMO they just create a lot
> of clutter since they only really contain a build file specific to the
> webapp in question.
> 
> I wrote build-webapps.xml for two reasons.  The first is related to
> the nightly build process.  I didn't want to have CATALINA_HOME, etc.
> setup on the build machine which was basically required because of
> some of the optional ant tasks used to deploy the webapps.  The second
> is that its difficult to maintain all of these separate build files.
> 
> The build-webapps.xml file works great right now but it doesn't handle
> the deploy stuff.  Here is what I propose.  We should write a new
> buildfile: deploy-webapps.xml that will handle the deployment of jars
> already built using build-webapps.xml.  Could you write such a build
> script (using build-webapps.xml as a model?)  I'm not a big fan of
> deploying using Ant .  I've had some trouble with it in the past and
> so I don't usually use it.  So I'm probably not the best person for
> this.
> 
> Once that is up and running for all the webapps, we can drop the
> subdirectories in build.  One suggestion though.  Lets not drop any
> more directories or move anything around until 1.0.9 is released.  We
> don't want to make the testing of the RC any more confusing.
> 
> Thoughts?
> 
> sean
> 
> 
> On Wed, 30 Mar 2005 11:39:22 -0400, Sylvain Vieujot <sv...@freelance.com> wrote:
> >  Yes, doing that it works fine.
> >  Thanks.
> >  
> >  Hello Sean,
> >  
> >  I ran into problems deploying the examples webapp.
> >  Thanks to Matthias, I found that the build file that's in
> > build/examples-webapp isn't in sync with the main build all process.
> >  
> >  Indeed, if you build the examples webapp with this build file, you don't
> > get the myfaces-examples.jar. Instead, the classes go directly in
> > WEB-INF/classes, and the resources aren't located in the right directory, as
> > they go in /WEB-INF/classes/example/org/apache..... instead of the expected
> > /WEB-INF/classes/org/apache....
> >  
> >  Anyway, I think this build file might better be removed, or upgraded to use
> > the same build process with the build-webapps.xml file.
> >  The reason I was using this build/examples-webapp/build.xml file is that it
> > can directly deploy the webapp which is handy when you're doing tests.
> >  
> >  Thanks,
> >  
> >  Sylvain.
> >  
> >  
> >  On Wed, 2005-03-30 at 17:10 +0200, Matthias Wessendorf wrote: 
> >  clean-all and after that all Sean created some patches for simplifing the
> > example web apps Can you try them on your box? (the tasks) ? -Matthias
> > Sylvain Vieujot wrote: > Yes, we definitely have different war files, and
> > yours looks good. > What target do you launch ? > > I launch the default
> > target (run-examples) from build/examples- > webapp/build.xml > > Sylvain. >
> > > On Wed, 2005-03-30 at 14:00 +0200, Matthias Wessendorf wrote: > > >>here
> > WEB-INF/lib >> >>contains "myfaces-examples.jar" >> >>HTH, >>Matthias >>
> > >>Sylvain Vieujot wrote: >> >>>Yes, please use this address. >>> >>>Thanks.
> > >>> >>>Sylvain. >>> >>>On Wed, 2005-03-30 at 08:08 +0200, Matthias
> > Wessendorf wrote: >>> >>> >>> >>>>Sorry, >>>> >>>>but the APACHE mailserver
> > doesn't love *big* >>>>files, so can you mail me another email address? >>>>
> > >>>>That I can use for sending you the WAR file, build on my box. >>>>
> > >>>>-Matthias >>>> >>>>Sylvain Vieujot wrote: >>>> >>>> >>>>>In fact, I just
> > find that in the war, the resources are in /WEB-
> > >>>>>INF/classes/example/org/apache..... instead of the expected /WEB-
> > >>>>>INF/classes/org/apache.... >>>>> >>>>>But I wonder how it could be that
> > it works on your machine. >>>>>Maybe you didn't make a clean before
> > compiling, and you have them in >>>>>both locations. >>>>> >>>>>Could you
> > try to expand your myfaces-examples.war, and check this ? >>>>> >>>>>Thanks,
> > >>>>> >>>>>Sylvain. >>>>> >>>>>On Tue, 2005-03-29 at 09:37 +0200, Matthias
> > Wessendorf wrote: >>>>> >>>>> >>>>> >>>>> >>>>>>Sylvain, >>>>>> >>>>>>I just
> > looked at example WEB-APP and all seams >>>>>>to be fine. I build it just
> > some minutes before. >>>>>> >>>>>>All messages are displayed like expected.
> > >>>>>>(see GIF) >>>>>> >>>>>>Did I (again) miss something`? >>>>>>-Matthias
> > >>>>>> >>>>>>Sylvain Vieujot wrote: >>>>>> >>>>>> >>>>>> >>>>>>>Hello
> > Matthias, >>>>>>> >>>>>>>Thank you. >>>>>>>Indeed, now it compiles, but they
> > are still some problems with the >>>>>>>property files. >>>>>>>I guess they
> > aren't included in the webapp as all the messages are empty >>>>>>>(in the
> > examples-webapp). >>>>>>> >>>>>>>Sylvain. >>>>>>> >>>>>>>On Mon, 2005-03-28
> > at 18:26 +0200, Matthias Wessendorf wrote: >>>>>>> >>>>>>> >>>>>>> >>>>>>>
> > >>>>>>> >>>>>>>>Sylvain, >>>>>>>> >>>>>>>>thanks for pointing it out!
> > >>>>>>>>and yes Sean was right, it was me. >>>>>>>> >>>>>>>>I just removed
> > >>>>>>>>MYFACES_HOME/webapps/src/org/** >>>>>>>> >>>>>>> >>>>>>>>from now
> > there should only: >>>>>>> >>>>>>> >>>>>>>
> > >>>>>>>>MYFACES_HOME/webapps/src/blank
> > >>>>>>>>MYFACES_HOME/webapps/src/examples
> > >>>>>>>>MYFACES_HOME/webapps/src/tiles >>>>>>>>MYFACES_HOME/webapps/src/wap
> > >>>>>>>> >>>>>>>>Also, I changed the build file *before* >>>>>>>>deleting
> > the mentioned files. >>>>>>>>On my box the task "all" works. >>>>>>>>
> > >>>>>>>>In >>>>>>>> >>>>>>>>MYFACES_HOME/build/release >>>>>>>>
> > >>>>>>>>there should after that three TGZ >>>>>>>>-src >>>>>>>>-bin
> > >>>>>>>>-app >>>>>>>> >>>>>>>>Did I miss something? >>>>>>>>-Matthias
> > >>>>>>>> >>>>>>>>Sylvain Vieujot wrote: >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>>
> > >>>>>>>>>Done. >>>>>>>>> >>>>>>>>>In the process, I found that there is a
> > mess in the webapps sources. >>>>>>>>>Right now, we have 2 trees with the
> > same webapps beans sources, and so, >>>>>>>>>the webapps don't compile
> > anymore. >>>>>>>>> >>>>>>>>>I didn't fix this, as I guess someone is the
> > process of refactoring >>>>>>>>>this, and I'm not sure what the final
> > structure should be. >>>>>>>>> >>>>>>>>>Sylvain. >>>>>>>>> >>>>>>>>>On Fri,
> > 2005-03-25 at 22:02 +0100, Manfred Geiler wrote: >>>>>>>>> >>>>>>>>>
> > >>>>>>>>> >>>>>>>>> >>>>>>>>> >>>>>>>>> >>>>>>>>>>+1 >>>>>>>>>> >>>>>>>>>>
> > >>>>>>>>>>On Fri, 25 Mar 2005 16:00:25 -0400, Sylvain Vieujot
> > <sv...@apache.org> wrote: >>>>>>>>>> >>>>>>>>>> >>>>>>>>>> >>>>>>>>>>
> > >>>>>>>>>> >>>>>>>>>>>Before we do the 1.0.9 release, I thought it would be
> > good to rename the >>>>>>>>>>>x:htmlEditor to x:inputHtml as it fits better
> > with the standard JSF naming >>>>>>>>>>>convention. >>>>>>>>>>>
> > >>>>>>>>>>>Any thoughts ? >>>>>>>>>>> >>>>>>>>>>>Sylvain. >>>>>>>>>
> > >>>>>>>>> >>> >>> >