You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@falcon.apache.org by sandeep samudrala <sa...@gmail.com> on 2015/08/05 21:42:43 UTC
Review Request 37138: FALCON-1368: Changes to make configuration store
loading parallel.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37138/
-----------------------------------------------------------
Review request for Falcon, Ajay Yadava and Srikanth Sundarrajan.
Bugs: FALCON-1368
https://issues.apache.org/jira/browse/FALCON-1368
Repository: falcon-git
Description
-------
I have made changes to make configuration store loading of entities parallel for each entity type in the respective order ( CLUSTER, FEED, PROCESS)
Diffs
-----
common/src/main/java/org/apache/falcon/entity/store/ConfigurationStore.java 7b53ebb
Diff: https://reviews.apache.org/r/37138/diff/
Testing
-------
This is a sample of how it looks and there is a good dip in the restart time of falcon server.
2015-08-06 00:59:04,687 INFO - [pool-5-thread-95:] ~ Restored configuration FEED/ipfeed34
2015-08-06 00:59:04,690 INFO - [pool-5-thread-94:] ~ Restored configuration FEED/ipfeed18
2015-08-06 00:59:04,694 INFO - [pool-5-thread-93:] ~ Restored configuration FEED/ipfeed10
Thanks,
sandeep samudrala
Re: Review Request 37138: FALCON-1368: Changes to make configuration
store loading parallel.
Posted by Ajay Yadava <aj...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37138/#review94331
-----------------------------------------------------------
Apart from a minor comment looks good to me.
common/src/main/java/org/apache/falcon/entity/store/ConfigurationStore.java (line 195)
<https://reviews.apache.org/r/37138/#comment148901>
Unused method?
- Ajay Yadava
On Aug. 5, 2015, 7:42 p.m., sandeep samudrala wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37138/
> -----------------------------------------------------------
>
> (Updated Aug. 5, 2015, 7:42 p.m.)
>
>
> Review request for Falcon, Ajay Yadava and Srikanth Sundarrajan.
>
>
> Bugs: FALCON-1368
> https://issues.apache.org/jira/browse/FALCON-1368
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> I have made changes to make configuration store loading of entities parallel for each entity type in the respective order ( CLUSTER, FEED, PROCESS)
>
>
> Diffs
> -----
>
> common/src/main/java/org/apache/falcon/entity/store/ConfigurationStore.java 7b53ebb
>
> Diff: https://reviews.apache.org/r/37138/diff/
>
>
> Testing
> -------
>
> This is a sample of how it looks and there is a good dip in the restart time of falcon server.
>
> 2015-08-06 00:59:04,687 INFO - [pool-5-thread-95:] ~ Restored configuration FEED/ipfeed34
> 2015-08-06 00:59:04,690 INFO - [pool-5-thread-94:] ~ Restored configuration FEED/ipfeed18
> 2015-08-06 00:59:04,694 INFO - [pool-5-thread-93:] ~ Restored configuration FEED/ipfeed10
>
>
> Thanks,
>
> sandeep samudrala
>
>
Re: Review Request 37138: FALCON-1368: Changes to make configuration
store loading parallel.
Posted by Ajay Yadava <aj...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37138/#review94334
-----------------------------------------------------------
common/src/main/java/org/apache/falcon/entity/store/ConfigurationStore.java (line 182)
<https://reviews.apache.org/r/37138/#comment148903>
It will be a good idea to log if all tasks completed or time out occurred (returned by the awaitTermination)
- Ajay Yadava
On Aug. 5, 2015, 7:42 p.m., sandeep samudrala wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37138/
> -----------------------------------------------------------
>
> (Updated Aug. 5, 2015, 7:42 p.m.)
>
>
> Review request for Falcon, Ajay Yadava and Srikanth Sundarrajan.
>
>
> Bugs: FALCON-1368
> https://issues.apache.org/jira/browse/FALCON-1368
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> I have made changes to make configuration store loading of entities parallel for each entity type in the respective order ( CLUSTER, FEED, PROCESS)
>
>
> Diffs
> -----
>
> common/src/main/java/org/apache/falcon/entity/store/ConfigurationStore.java 7b53ebb
>
> Diff: https://reviews.apache.org/r/37138/diff/
>
>
> Testing
> -------
>
> This is a sample of how it looks and there is a good dip in the restart time of falcon server.
>
> 2015-08-06 00:59:04,687 INFO - [pool-5-thread-95:] ~ Restored configuration FEED/ipfeed34
> 2015-08-06 00:59:04,690 INFO - [pool-5-thread-94:] ~ Restored configuration FEED/ipfeed18
> 2015-08-06 00:59:04,694 INFO - [pool-5-thread-93:] ~ Restored configuration FEED/ipfeed10
>
>
> Thanks,
>
> sandeep samudrala
>
>
Re: Review Request 37138: FALCON-1368: Changes to make configuration
store loading parallel.
Posted by Ajay Yadava <aj...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37138/#review94538
-----------------------------------------------------------
Ship it!
Ship It!
- Ajay Yadava
On Aug. 7, 2015, 2:04 p.m., sandeep samudrala wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37138/
> -----------------------------------------------------------
>
> (Updated Aug. 7, 2015, 2:04 p.m.)
>
>
> Review request for Falcon, Ajay Yadava and Srikanth Sundarrajan.
>
>
> Bugs: FALCON-1368
> https://issues.apache.org/jira/browse/FALCON-1368
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> I have made changes to make configuration store loading of entities parallel for each entity type in the respective order ( CLUSTER, FEED, PROCESS)
>
>
> Diffs
> -----
>
> common/src/main/java/org/apache/falcon/entity/store/ConfigurationStore.java 7b53ebb
>
> Diff: https://reviews.apache.org/r/37138/diff/
>
>
> Testing
> -------
>
> This is a sample of how it looks and there is a good dip in the restart time of falcon server.
>
> 2015-08-06 00:59:04,687 INFO - [pool-5-thread-95:] ~ Restored configuration FEED/ipfeed34
> 2015-08-06 00:59:04,690 INFO - [pool-5-thread-94:] ~ Restored configuration FEED/ipfeed18
> 2015-08-06 00:59:04,694 INFO - [pool-5-thread-93:] ~ Restored configuration FEED/ipfeed10
>
>
> Thanks,
>
> sandeep samudrala
>
>
Re: Review Request 37138: FALCON-1368: Changes to make configuration
store loading parallel.
Posted by Pallavi Rao <pa...@inmobi.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37138/#review94699
-----------------------------------------------------------
Ship it!
Ship It!
- Pallavi Rao
On Aug. 7, 2015, 2:04 p.m., sandeep samudrala wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37138/
> -----------------------------------------------------------
>
> (Updated Aug. 7, 2015, 2:04 p.m.)
>
>
> Review request for Falcon, Ajay Yadava and Srikanth Sundarrajan.
>
>
> Bugs: FALCON-1368
> https://issues.apache.org/jira/browse/FALCON-1368
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> I have made changes to make configuration store loading of entities parallel for each entity type in the respective order ( CLUSTER, FEED, PROCESS)
>
>
> Diffs
> -----
>
> common/src/main/java/org/apache/falcon/entity/store/ConfigurationStore.java 7b53ebb
>
> Diff: https://reviews.apache.org/r/37138/diff/
>
>
> Testing
> -------
>
> This is a sample of how it looks and there is a good dip in the restart time of falcon server.
>
> 2015-08-06 00:59:04,687 INFO - [pool-5-thread-95:] ~ Restored configuration FEED/ipfeed34
> 2015-08-06 00:59:04,690 INFO - [pool-5-thread-94:] ~ Restored configuration FEED/ipfeed18
> 2015-08-06 00:59:04,694 INFO - [pool-5-thread-93:] ~ Restored configuration FEED/ipfeed10
>
>
> Thanks,
>
> sandeep samudrala
>
>
Re: Review Request 37138: FALCON-1368: Changes to make configuration
store loading parallel.
Posted by sandeep samudrala <sa...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37138/
-----------------------------------------------------------
(Updated Aug. 7, 2015, 2:04 p.m.)
Review request for Falcon, Ajay Yadava and Srikanth Sundarrajan.
Bugs: FALCON-1368
https://issues.apache.org/jira/browse/FALCON-1368
Repository: falcon-git
Description
-------
I have made changes to make configuration store loading of entities parallel for each entity type in the respective order ( CLUSTER, FEED, PROCESS)
Diffs (updated)
-----
common/src/main/java/org/apache/falcon/entity/store/ConfigurationStore.java 7b53ebb
Diff: https://reviews.apache.org/r/37138/diff/
Testing
-------
This is a sample of how it looks and there is a good dip in the restart time of falcon server.
2015-08-06 00:59:04,687 INFO - [pool-5-thread-95:] ~ Restored configuration FEED/ipfeed34
2015-08-06 00:59:04,690 INFO - [pool-5-thread-94:] ~ Restored configuration FEED/ipfeed18
2015-08-06 00:59:04,694 INFO - [pool-5-thread-93:] ~ Restored configuration FEED/ipfeed10
Thanks,
sandeep samudrala
Re: Review Request 37138: FALCON-1368: Changes to make configuration
store loading parallel.
Posted by Pallavi Rao <pa...@inmobi.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37138/#review94486
-----------------------------------------------------------
common/src/main/java/org/apache/falcon/entity/store/ConfigurationStore.java (line 174)
<https://reviews.apache.org/r/37138/#comment149112>
onReload being called twice? Once here and once later in the for loop.
common/src/main/java/org/apache/falcon/entity/store/ConfigurationStore.java (line 191)
<https://reviews.apache.org/r/37138/#comment149113>
Shouldn't this check be made before invoking onReload, as a fail-fast mechanism?
- Pallavi Rao
On Aug. 6, 2015, 8:14 p.m., sandeep samudrala wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37138/
> -----------------------------------------------------------
>
> (Updated Aug. 6, 2015, 8:14 p.m.)
>
>
> Review request for Falcon, Ajay Yadava and Srikanth Sundarrajan.
>
>
> Bugs: FALCON-1368
> https://issues.apache.org/jira/browse/FALCON-1368
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> I have made changes to make configuration store loading of entities parallel for each entity type in the respective order ( CLUSTER, FEED, PROCESS)
>
>
> Diffs
> -----
>
> common/src/main/java/org/apache/falcon/entity/store/ConfigurationStore.java 7b53ebb
>
> Diff: https://reviews.apache.org/r/37138/diff/
>
>
> Testing
> -------
>
> This is a sample of how it looks and there is a good dip in the restart time of falcon server.
>
> 2015-08-06 00:59:04,687 INFO - [pool-5-thread-95:] ~ Restored configuration FEED/ipfeed34
> 2015-08-06 00:59:04,690 INFO - [pool-5-thread-94:] ~ Restored configuration FEED/ipfeed18
> 2015-08-06 00:59:04,694 INFO - [pool-5-thread-93:] ~ Restored configuration FEED/ipfeed10
>
>
> Thanks,
>
> sandeep samudrala
>
>
Re: Review Request 37138: FALCON-1368: Changes to make configuration
store loading parallel.
Posted by sandeep samudrala <sa...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37138/
-----------------------------------------------------------
(Updated Aug. 6, 2015, 8:14 p.m.)
Review request for Falcon, Ajay Yadava and Srikanth Sundarrajan.
Bugs: FALCON-1368
https://issues.apache.org/jira/browse/FALCON-1368
Repository: falcon-git
Description
-------
I have made changes to make configuration store loading of entities parallel for each entity type in the respective order ( CLUSTER, FEED, PROCESS)
Diffs (updated)
-----
common/src/main/java/org/apache/falcon/entity/store/ConfigurationStore.java 7b53ebb
Diff: https://reviews.apache.org/r/37138/diff/
Testing
-------
This is a sample of how it looks and there is a good dip in the restart time of falcon server.
2015-08-06 00:59:04,687 INFO - [pool-5-thread-95:] ~ Restored configuration FEED/ipfeed34
2015-08-06 00:59:04,690 INFO - [pool-5-thread-94:] ~ Restored configuration FEED/ipfeed18
2015-08-06 00:59:04,694 INFO - [pool-5-thread-93:] ~ Restored configuration FEED/ipfeed10
Thanks,
sandeep samudrala
Re: Review Request 37138: FALCON-1368: Changes to make configuration
store loading parallel.
Posted by sandeep samudrala <sa...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37138/
-----------------------------------------------------------
(Updated Aug. 6, 2015, 3:47 a.m.)
Review request for Falcon, Ajay Yadava and Srikanth Sundarrajan.
Bugs: FALCON-1368
https://issues.apache.org/jira/browse/FALCON-1368
Repository: falcon-git
Description
-------
I have made changes to make configuration store loading of entities parallel for each entity type in the respective order ( CLUSTER, FEED, PROCESS)
Diffs (updated)
-----
common/src/main/java/org/apache/falcon/entity/store/ConfigurationStore.java 7b53ebb
Diff: https://reviews.apache.org/r/37138/diff/
Testing
-------
This is a sample of how it looks and there is a good dip in the restart time of falcon server.
2015-08-06 00:59:04,687 INFO - [pool-5-thread-95:] ~ Restored configuration FEED/ipfeed34
2015-08-06 00:59:04,690 INFO - [pool-5-thread-94:] ~ Restored configuration FEED/ipfeed18
2015-08-06 00:59:04,694 INFO - [pool-5-thread-93:] ~ Restored configuration FEED/ipfeed10
Thanks,
sandeep samudrala