You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/09/15 11:48:26 UTC
[GitHub] [spark] AngersZhuuuu opened a new pull request #34006: [SPARK-36755][SQL] ArraysOverlap should handle duplicated Double.NaN and Float.NaN
AngersZhuuuu opened a new pull request #34006:
URL: https://github.com/apache/spark/pull/34006
### What changes were proposed in this pull request?
For query
```
select arrays_overlap(array(cast('nan' as double), 1d), array(cast('nan' as double)))
```
This returns [false], but it should return [true].
This issue is caused by `OpenHashSet` can't handle `Double.NaN` and `Float.NaN` too.
In this pr fix this based on https://github.com/apache/spark/pull/33955
### Why are the changes needed?
Fix bug
### Does this PR introduce _any_ user-facing change?
arrays_overlap won't handle equal `NaN` value
### How was this patch tested?
Added UT
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34006: [SPARK-36755][SQL] ArraysOverlap should handle duplicated Double.NaN and Float.NaN
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34006:
URL: https://github.com/apache/spark/pull/34006#issuecomment-919982778
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/47803/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on pull request #34006: [SPARK-36755][SQL] ArraysOverlap should handle duplicated Double.NaN and Float.NaN
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on pull request #34006:
URL: https://github.com/apache/spark/pull/34006#issuecomment-920569569
also merged to 3.0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34006: [SPARK-36755][SQL] ArraysOverlap should handle duplicated Double.NaN and Float.NaN
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34006:
URL: https://github.com/apache/spark/pull/34006#issuecomment-919986811
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/47803/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34006: [SPARK-36755][SQL] ArraysOverlap should handle duplicated Double.NaN and Float.NaN
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34006:
URL: https://github.com/apache/spark/pull/34006#issuecomment-919977104
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/47803/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34006: [SPARK-36755][SQL] ArraysOverlap should handle duplicated Double.NaN and Float.NaN
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34006:
URL: https://github.com/apache/spark/pull/34006#issuecomment-919950305
**[Test build #143300 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/143300/testReport)** for PR 34006 at commit [`ac8bce8`](https://github.com/apache/spark/commit/ac8bce83e7abb01fcea9e53a67a695e31aef7b6a).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34006: [SPARK-36755][SQL] ArraysOverlap should handle duplicated Double.NaN and Float.NaN
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34006:
URL: https://github.com/apache/spark/pull/34006#issuecomment-920188991
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/143300/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #34006: [SPARK-36755][SQL] ArraysOverlap should handle duplicated Double.NaN and Float.NaN
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #34006:
URL: https://github.com/apache/spark/pull/34006#issuecomment-919950305
**[Test build #143300 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/143300/testReport)** for PR 34006 at commit [`ac8bce8`](https://github.com/apache/spark/commit/ac8bce83e7abb01fcea9e53a67a695e31aef7b6a).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on pull request #34006: [SPARK-36755][SQL] ArraysOverlap should handle duplicated Double.NaN and Float.NaN
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on pull request #34006:
URL: https://github.com/apache/spark/pull/34006#issuecomment-920075984
thanks, merging to master/3.2/3.1!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34006: [SPARK-36755][SQL] ArraysOverlap should handle duplicated Double.NaN and Float.NaN
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34006:
URL: https://github.com/apache/spark/pull/34006#issuecomment-920186539
**[Test build #143300 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/143300/testReport)** for PR 34006 at commit [`ac8bce8`](https://github.com/apache/spark/commit/ac8bce83e7abb01fcea9e53a67a695e31aef7b6a).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AngersZhuuuu commented on pull request #34006: [SPARK-36755][SQL] ArraysOverlap should handle duplicated Double.NaN and Float.NaN
Posted by GitBox <gi...@apache.org>.
AngersZhuuuu commented on pull request #34006:
URL: https://github.com/apache/spark/pull/34006#issuecomment-919965444
ping @cloud-fan @dongjoon-hyun
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan closed pull request #34006: [SPARK-36755][SQL] ArraysOverlap should handle duplicated Double.NaN and Float.NaN
Posted by GitBox <gi...@apache.org>.
cloud-fan closed pull request #34006:
URL: https://github.com/apache/spark/pull/34006
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #34006: [SPARK-36755][SQL] ArraysOverlap should handle duplicated Double.NaN and Float.NaN
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #34006:
URL: https://github.com/apache/spark/pull/34006#issuecomment-920112470
+1, LGTM. It's nice to have a simple fix. Thank you, @AngersZhuuuu and @cloud-fan .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34006: [SPARK-36755][SQL] ArraysOverlap should handle duplicated Double.NaN and Float.NaN
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34006:
URL: https://github.com/apache/spark/pull/34006#issuecomment-920188991
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/143300/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34006: [SPARK-36755][SQL] ArraysOverlap should handle duplicated Double.NaN and Float.NaN
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34006:
URL: https://github.com/apache/spark/pull/34006#issuecomment-919986811
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/47803/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org