You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Andrew Wong (Code Review)" <ge...@cloudera.org> on 2021/05/14 19:19:13 UTC

[kudu-CR] [txns] add a means to get transaction metadata from participant 

Andrew Wong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/17446


Change subject: [txns] add a means to get transaction metadata from participant
......................................................................

[txns] add a means to get transaction metadata from participant

This patch adds a GET_METADATA participant RPC and a method to call it
through the TxnSystemClient. The RPC currently returns the TxnMetadataPB
for the given transaction, giving a bit of insight into the state of the
given participant.

I will use this in an upcoming tool that drills into a transaction and
its participants.

Change-Id: I4b03f13f174bd9a83609fb7ed6106746777b4207
---
M src/kudu/integration-tests/txn_participant-itest.cc
M src/kudu/tablet/tablet_metadata.cc
M src/kudu/tablet/tablet_metadata.h
M src/kudu/tablet/txn_metadata.h
M src/kudu/tablet/txn_participant-test.cc
M src/kudu/transactions/participant_rpc.cc
M src/kudu/transactions/participant_rpc.h
M src/kudu/transactions/txn_system_client.cc
M src/kudu/transactions/txn_system_client.h
M src/kudu/tserver/tablet_service.cc
M src/kudu/tserver/tserver_admin.proto
11 files changed, 215 insertions(+), 39 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/46/17446/1
-- 
To view, visit http://gerrit.cloudera.org:8080/17446
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I4b03f13f174bd9a83609fb7ed6106746777b4207
Gerrit-Change-Number: 17446
Gerrit-PatchSet: 1
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>

[kudu-CR] [txns] add a means to get transaction metadata from participant

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/17446 )

Change subject: [txns] add a means to get transaction metadata from participant
......................................................................


Patch Set 3: Code-Review+1

(2 comments)

overall looks good, just a few nits

http://gerrit.cloudera.org:8080/#/c/17446/3/src/kudu/integration-tests/txn_participant-itest.cc
File src/kudu/integration-tests/txn_participant-itest.cc:

http://gerrit.cloudera.org:8080/#/c/17446/3/src/kudu/integration-tests/txn_participant-itest.cc@873
PS3, Line 873:   ASSERT_FALSE(meta_pb.has_aborted());
Does it make sense to add coverage to make sure this field is populated when a transaction is aborted?


http://gerrit.cloudera.org:8080/#/c/17446/3/src/kudu/tserver/tserver_admin.proto
File src/kudu/tserver/tserver_admin.proto:

http://gerrit.cloudera.org:8080/#/c/17446/3/src/kudu/tserver/tserver_admin.proto@127
PS3, Line 127: empty
nit: if no metadata exists on the given participant, is it going to be rather absent or present and empty?  Would be nice to clarify.



-- 
To view, visit http://gerrit.cloudera.org:8080/17446
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4b03f13f174bd9a83609fb7ed6106746777b4207
Gerrit-Change-Number: 17446
Gerrit-PatchSet: 3
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Sat, 15 May 2021 06:33:49 +0000
Gerrit-HasComments: Yes

[kudu-CR] [txns] add a means to get transaction metadata from participant

Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Hello Alexey Serbin, Kudu Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/17446

to look at the new patch set (#4).

Change subject: [txns] add a means to get transaction metadata from participant
......................................................................

[txns] add a means to get transaction metadata from participant

This patch adds a GET_METADATA participant RPC and a method to call it
through the TxnSystemClient. The RPC currently returns the TxnMetadataPB
for the given transaction, giving a bit of insight into the state of the
given participant.

I will use this in an upcoming tool that drills into a transaction and
its participants.

Change-Id: I4b03f13f174bd9a83609fb7ed6106746777b4207
---
M src/kudu/integration-tests/txn_participant-itest.cc
M src/kudu/tablet/tablet_metadata.cc
M src/kudu/tablet/tablet_metadata.h
M src/kudu/tablet/txn_metadata.h
M src/kudu/tablet/txn_participant-test.cc
M src/kudu/transactions/participant_rpc.cc
M src/kudu/transactions/participant_rpc.h
M src/kudu/transactions/txn_system_client.cc
M src/kudu/transactions/txn_system_client.h
M src/kudu/tserver/tablet_service.cc
M src/kudu/tserver/tserver_admin.proto
11 files changed, 232 insertions(+), 39 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/46/17446/4
-- 
To view, visit http://gerrit.cloudera.org:8080/17446
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I4b03f13f174bd9a83609fb7ed6106746777b4207
Gerrit-Change-Number: 17446
Gerrit-PatchSet: 4
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)

[kudu-CR] [txns] add a means to get transaction metadata from participant

Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/17446 )

Change subject: [txns] add a means to get transaction metadata from participant
......................................................................


Patch Set 4:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/17446/3/src/kudu/integration-tests/txn_participant-itest.cc
File src/kudu/integration-tests/txn_participant-itest.cc:

http://gerrit.cloudera.org:8080/#/c/17446/3/src/kudu/integration-tests/txn_participant-itest.cc@873
PS3, Line 873:       /*begin_commit_timestamp*/nullpt
> Does it make sense to add coverage to make sure this field is populated whe
Done


http://gerrit.cloudera.org:8080/#/c/17446/3/src/kudu/tserver/tserver_admin.proto
File src/kudu/tserver/tserver_admin.proto:

http://gerrit.cloudera.org:8080/#/c/17446/3/src/kudu/tserver/tserver_admin.proto@127
PS3, Line 127: absen
> nit: if no metadata exists on the given participant, is it going to be rath
Done



-- 
To view, visit http://gerrit.cloudera.org:8080/17446
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4b03f13f174bd9a83609fb7ed6106746777b4207
Gerrit-Change-Number: 17446
Gerrit-PatchSet: 4
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Mon, 17 May 2021 01:07:33 +0000
Gerrit-HasComments: Yes

[kudu-CR] [txns] add a means to get transaction metadata from participant

Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/17446 )

Change subject: [txns] add a means to get transaction metadata from participant
......................................................................

[txns] add a means to get transaction metadata from participant

This patch adds a GET_METADATA participant RPC and a method to call it
through the TxnSystemClient. The RPC currently returns the TxnMetadataPB
for the given transaction, giving a bit of insight into the state of the
given participant.

I will use this in an upcoming tool that drills into a transaction and
its participants.

Change-Id: I4b03f13f174bd9a83609fb7ed6106746777b4207
Reviewed-on: http://gerrit.cloudera.org:8080/17446
Tested-by: Kudu Jenkins
Reviewed-by: Alexey Serbin <as...@cloudera.com>
---
M src/kudu/integration-tests/txn_participant-itest.cc
M src/kudu/tablet/tablet_metadata.cc
M src/kudu/tablet/tablet_metadata.h
M src/kudu/tablet/txn_metadata.h
M src/kudu/tablet/txn_participant-test.cc
M src/kudu/transactions/participant_rpc.cc
M src/kudu/transactions/participant_rpc.h
M src/kudu/transactions/txn_system_client.cc
M src/kudu/transactions/txn_system_client.h
M src/kudu/tserver/tablet_service.cc
M src/kudu/tserver/tserver_admin.proto
11 files changed, 232 insertions(+), 39 deletions(-)

Approvals:
  Kudu Jenkins: Verified
  Alexey Serbin: Looks good to me, approved

-- 
To view, visit http://gerrit.cloudera.org:8080/17446
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I4b03f13f174bd9a83609fb7ed6106746777b4207
Gerrit-Change-Number: 17446
Gerrit-PatchSet: 5
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)

[kudu-CR] [txns] add a means to get transaction metadata from participant

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/17446 )

Change subject: [txns] add a means to get transaction metadata from participant
......................................................................


Patch Set 4: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/17446
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4b03f13f174bd9a83609fb7ed6106746777b4207
Gerrit-Change-Number: 17446
Gerrit-PatchSet: 4
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Mon, 17 May 2021 16:07:35 +0000
Gerrit-HasComments: No

[kudu-CR] [txns] add a means to get transaction metadata from participant

Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/17446

to look at the new patch set (#3).

Change subject: [txns] add a means to get transaction metadata from participant
......................................................................

[txns] add a means to get transaction metadata from participant

This patch adds a GET_METADATA participant RPC and a method to call it
through the TxnSystemClient. The RPC currently returns the TxnMetadataPB
for the given transaction, giving a bit of insight into the state of the
given participant.

I will use this in an upcoming tool that drills into a transaction and
its participants.

Change-Id: I4b03f13f174bd9a83609fb7ed6106746777b4207
---
M src/kudu/integration-tests/txn_participant-itest.cc
M src/kudu/tablet/tablet_metadata.cc
M src/kudu/tablet/tablet_metadata.h
M src/kudu/tablet/txn_metadata.h
M src/kudu/tablet/txn_participant-test.cc
M src/kudu/transactions/participant_rpc.cc
M src/kudu/transactions/participant_rpc.h
M src/kudu/transactions/txn_system_client.cc
M src/kudu/transactions/txn_system_client.h
M src/kudu/tserver/tablet_service.cc
M src/kudu/tserver/tserver_admin.proto
11 files changed, 218 insertions(+), 39 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/46/17446/3
-- 
To view, visit http://gerrit.cloudera.org:8080/17446
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I4b03f13f174bd9a83609fb7ed6106746777b4207
Gerrit-Change-Number: 17446
Gerrit-PatchSet: 3
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)

[kudu-CR] [txns] add a means to get transaction metadata from participant

Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/17446

to look at the new patch set (#2).

Change subject: [txns] add a means to get transaction metadata from participant
......................................................................

[txns] add a means to get transaction metadata from participant

This patch adds a GET_METADATA participant RPC and a method to call it
through the TxnSystemClient. The RPC currently returns the TxnMetadataPB
for the given transaction, giving a bit of insight into the state of the
given participant.

I will use this in an upcoming tool that drills into a transaction and
its participants.

Change-Id: I4b03f13f174bd9a83609fb7ed6106746777b4207
---
M src/kudu/integration-tests/txn_participant-itest.cc
M src/kudu/tablet/tablet_metadata.cc
M src/kudu/tablet/tablet_metadata.h
M src/kudu/tablet/txn_metadata.h
M src/kudu/tablet/txn_participant-test.cc
M src/kudu/transactions/participant_rpc.cc
M src/kudu/transactions/participant_rpc.h
M src/kudu/transactions/txn_system_client.cc
M src/kudu/transactions/txn_system_client.h
M src/kudu/tserver/tablet_service.cc
M src/kudu/tserver/tserver_admin.proto
11 files changed, 217 insertions(+), 39 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/46/17446/2
-- 
To view, visit http://gerrit.cloudera.org:8080/17446
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I4b03f13f174bd9a83609fb7ed6106746777b4207
Gerrit-Change-Number: 17446
Gerrit-PatchSet: 2
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)