You are viewing a plain text version of this content. The canonical link for it is here.
Posted to fop-dev@xmlgraphics.apache.org by bu...@apache.org on 2008/04/28 02:03:07 UTC
DO NOT REPLY [Bug 44885] New: fo:inline-container implementation
https://issues.apache.org/bugzilla/show_bug.cgi?id=44885
Summary: fo:inline-container implementation
Product: Fop
Version: 1.0dev
Platform: All
OS/Version: All
Status: NEW
Severity: enhancement
Priority: P1
Component: general
AssignedTo: fop-dev@xmlgraphics.apache.org
ReportedBy: adelmelle@apache.org
Created an attachment (id=21861)
--> (https://issues.apache.org/bugzilla/attachment.cgi?id=21861)
patch for the implementation
This Bugzilla entry will be used for the moment to keep track of the progress
of an implementation for fo:inline-container. The related changes are
restricted to a handful of classes, so branching seemed like overkill. No
commits to the trunk yet, since I see some possible overlap with Simon's
branch.
Anyway, status so far. The rough patch in attachment models the
InlineContainerLayoutManager along the lines of BlockContainerLayoutManager. It
already aligns the content better than my last attempt (way back when). Still
some things remaining to check out, but the basics are there...
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
DO NOT REPLY [Bug 44885] [PATCH] fo:inline-container implementation
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=44885
Andreas L. Delmelle <ad...@apache.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Summary|fo:inline-container |[PATCH] fo:inline-container
|implementation |implementation
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
DO NOT REPLY [Bug 44885] fo:inline-container implementation
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=44885
Andreas L. Delmelle <ad...@apache.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #21893|0 |1
is obsolete| |
--- Comment #9 from Andreas L. Delmelle <ad...@apache.org> 2011-02-10 18:21:04 EST ---
Created an attachment (id=26636)
--> (https://issues.apache.org/bugzilla/attachment.cgi?id=26636)
updated patch against latest trunk
New rough patch. Only confirmed that it renders the attached sample exactly the
same as before. Layout unit tests all seem to be unaffected, as expected. Some
checkstyle issues, I know. Definitely still far too sketchy and also generates
too much overhead.
I already factored out the inner breaker (which can then be shared with
BlockContainerBreaker), but still...
The nested/deferred algorithm should probably not be a full
PageBreakingAlgorithm, and the breaker itself should provide
straightforward/simplified overrides of more methods to control that
BreakingAlgorithm.
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
DO NOT REPLY [Bug 44885] [PATCH] fo:inline-container implementation
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=44885
--- Comment #11 from Andreas L. Delmelle <ad...@apache.org> 2011-04-19 17:43:39 EDT ---
(In reply to comment #10)
> Thanks for your patch, Andreas! One question...
>
> > New rough patch. Only confirmed that it renders the attached sample exactly the
> > same as before. Layout unit tests all seem to be unaffected, as expected. Some
> > checkstyle issues, I know. Definitely still far too sketchy and also generates
> > too much overhead.
>
> Is this overhead also present if inline-container elements are not used?
That's a definite No. Only documents actually using fo:inline-container would
be affected.
The overhead I am referring to specifically, is the 'abuse' of
PageBreakingAlgorithm. While the approach makes sense for absolute-positioned
or rotated block-containers --and may turn out to be unavoidable for similar
inline-containers-, regular block-containers would generate less overhead than
regular inline-containers, which seems wrong somehow...?
I am worried that a document with, say 200 inline-containers would generate
just as many PageBreakingAlgorithms, and those can hardly be considered
light-weight objects. Those instances will take up valuable heap space, since
they are all kept alive until the parent's addAreas() has been called...
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
DO NOT REPLY [Bug 44885] [PATCH] fo:inline-container implementation
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=44885
--- Comment #10 from Matthias Reischenbacher <ma...@gmx.at> 2011-04-19 16:54:19 EDT ---
Thanks for your patch, Andreas! One question...
> New rough patch. Only confirmed that it renders the attached sample exactly the
> same as before. Layout unit tests all seem to be unaffected, as expected. Some
> checkstyle issues, I know. Definitely still far too sketchy and also generates
> too much overhead.
Is this overhead also present if inline-container elements are not used?
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
DO NOT REPLY [Bug 44885] [PATCH] fo:inline-container implementation
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=44885
Glenn Adams <ga...@apache.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Priority|P3 |P2
--- Comment #13 from Glenn Adams <ga...@apache.org> 2012-04-11 03:22:23 UTC ---
increase priority for bugs with a patch
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
DO NOT REPLY [Bug 44885] [PATCH] fo:inline-container implementation
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=44885
Glenn Adams <gl...@skynav.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Priority|P1 |P3
--- Comment #12 from Glenn Adams <gl...@skynav.com> 2012-04-07 01:39:43 UTC ---
resetting P1 open bugs to P3 pending further review
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
Re: [Bug 44885] New: fo:inline-container implementation
Posted by Andreas Delmelle <an...@telenet.be>.
On Apr 28, 2008, at 21:36, Simon Pepping wrote:
> On Sun, Apr 27, 2008 at 05:03:07PM -0700, bugzilla@apache.org wrote:
>> This Bugzilla entry will be used for the moment to keep track of
>> the progress
>> of an implementation for fo:inline-container. The related changes are
>> restricted to a handful of classes, so branching seemed like
>> overkill. No
>> commits to the trunk yet, since I see some possible overlap with
>> Simon's
>> branch.
>
> You should not let yourself be stopped by my work. It is not going
> forward very much at the moment, and in any case I will catch up with
> commits to trunk.
OK, thanks. I'll keep that in mind. I already checked closer, and the
overlap seems to be minimal after all. The only major change is the
addition of InlineContainerLM.
The changes to the other files in the layoutmgr package are limited
to adding a few accessors or changing visibility to make information
accessible from within the layoutmgr.inline package.
Anyway, the patch still needs some cleanup and additional testcases
etc. Due to some copy-pasting from BlockContainerLM, there's
obviously a lot of code-duplication and still some unused parts, and
so on...
So the Bugzilla is more meant as a preview, for people who'd already
like to play with it themselves.
Cheers
Andreas
Re: [Bug 44885] New: fo:inline-container implementation
Posted by Simon Pepping <sp...@leverkruid.eu>.
On Sun, Apr 27, 2008 at 05:03:07PM -0700, bugzilla@apache.org wrote:
> This Bugzilla entry will be used for the moment to keep track of the progress
> of an implementation for fo:inline-container. The related changes are
> restricted to a handful of classes, so branching seemed like overkill. No
> commits to the trunk yet, since I see some possible overlap with Simon's
> branch.
You should not let yourself be stopped by my work. It is not going
forward very much at the moment, and in any case I will catch up with
commits to trunk.
Simon
--
Simon Pepping
home page: http://www.leverkruid.eu
DO NOT REPLY [Bug 44885] [PATCH] fo:inline-container implementation
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=44885
Glenn Adams <ga...@apache.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |NEW
--- Comment #14 from Glenn Adams <ga...@apache.org> 2012-04-11 06:17:52 UTC ---
change status from ASSIGNED to NEW for consistency
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
DO NOT REPLY [Bug 44885] fo:inline-container implementation
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=44885
Andreas L. Delmelle <ad...@apache.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #21895|0 |1
is obsolete| |
--- Comment #8 from Andreas L. Delmelle <ad...@apache.org> 2008-05-01 07:09:34 PST ---
Created an attachment (id=21897)
--> (https://issues.apache.org/bugzilla/attachment.cgi?id=21897)
Updated sample PDF result
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
DO NOT REPLY [Bug 44885] fo:inline-container implementation
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=44885
Andreas L. Delmelle <ad...@apache.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #21863|0 |1
is obsolete| |
--- Comment #5 from Andreas L. Delmelle <ad...@apache.org> 2008-05-01 06:00:53 PST ---
Created an attachment (id=21895)
--> (https://issues.apache.org/bugzilla/attachment.cgi?id=21895)
Updated sample PDF result
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
DO NOT REPLY [Bug 44885] fo:inline-container implementation
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=44885
Andreas L. Delmelle <ad...@apache.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #21861|0 |1
is obsolete| |
--- Comment #3 from Andreas L. Delmelle <ad...@apache.org> 2008-05-01 05:58:58 PST ---
Created an attachment (id=21893)
--> (https://issues.apache.org/bugzilla/attachment.cgi?id=21893)
Updated patch: added support for display-align and ipd="auto"
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
DO NOT REPLY [Bug 44885] fo:inline-container implementation
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=44885
Andreas L. Delmelle <ad...@apache.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #21894|0 |1
is obsolete| |
--- Comment #7 from Andreas L. Delmelle <ad...@apache.org> 2008-05-01 07:07:35 PST ---
Created an attachment (id=21896)
--> (https://issues.apache.org/bugzilla/attachment.cgi?id=21896)
Updated sample FO: added some examples for alignment-adjust
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
DO NOT REPLY [Bug 44885] fo:inline-container implementation
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=44885
--- Comment #2 from Andreas L. Delmelle <ad...@apache.org> 2008-04-27 17:07:54 PST ---
Created an attachment (id=21863)
--> (https://issues.apache.org/bugzilla/attachment.cgi?id=21863)
PDF result after applying the patch
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
DO NOT REPLY [Bug 44885] fo:inline-container implementation
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=44885
Andreas L. Delmelle <ad...@apache.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
DO NOT REPLY [Bug 44885] fo:inline-container implementation
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=44885
--- Comment #1 from Andreas L. Delmelle <ad...@apache.org> 2008-04-27 17:05:04 PST ---
Created an attachment (id=21862)
--> (https://issues.apache.org/bugzilla/attachment.cgi?id=21862)
Small test FO
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
DO NOT REPLY [Bug 44885] fo:inline-container implementation
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=44885
--- Comment #6 from Andreas L. Delmelle <ad...@apache.org> 2008-05-01 07:03:56 PST ---
Still to do after the patch in attachment #21893:
- add support for reference-orientation:
started off by adding a CTM to area.inline.Viewport;
modifications to AbstractRenderer still needed to make use of it
(see test output: the grey inline-container on page 2 should have its
content rotated by 180 degrees)
- check area-alignment properties
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
DO NOT REPLY [Bug 44885] fo:inline-container implementation
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=44885
Andreas L. Delmelle <ad...@apache.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #21862|0 |1
is obsolete| |
--- Comment #4 from Andreas L. Delmelle <ad...@apache.org> 2008-05-01 06:00:01 PST ---
Created an attachment (id=21894)
--> (https://issues.apache.org/bugzilla/attachment.cgi?id=21894)
Updated sample FO
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.