You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by karup1990 <gi...@git.apache.org> on 2016/07/22 04:17:20 UTC
[GitHub] zeppelin pull request #1214: ZEPPELIN-1224: Fix typo in method name
GitHub user karup1990 opened a pull request:
https://github.com/apache/zeppelin/pull/1214
ZEPPELIN-1224: Fix typo in method name
### What is this PR for?
Get the correct method to invoke, for autocompletion
### What type of PR is it?
Bug Fix
### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-1224
### How should this be tested?
Try to get the auto complete suggestion.(`cmd + .`)
We should not get `NoSuchMethodError` and suggestions should be listed rightly
### Screenshots (if appropriate)
NA
### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/karup1990/incubator-zeppelin ZEPPELIN-1224
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/1214.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1214
----
commit cd3df44404f1d2a581478067f3d322736e54c38b
Author: Karup <ka...@outlook.com>
Date: 2016-07-22T04:09:29Z
Fix typo in method name
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1214: ZEPPELIN-1224: Fix typo in method name
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/zeppelin/pull/1214
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1214: ZEPPELIN-1224: Fix typo in method name
Posted by karup1990 <gi...@git.apache.org>.
Github user karup1990 commented on the issue:
https://github.com/apache/zeppelin/pull/1214
I was thinking to keep changes minimal.
Should I change all variable names ? @AhyoungRyu
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1214: ZEPPELIN-1224: Fix typo in method name
Posted by AhyoungRyu <gi...@git.apache.org>.
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/1214
@karup1990 Thanks! Looks good \U0001f44d
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1214: ZEPPELIN-1224: Fix typo in method name
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/1214
LGTM.
CI failure irrelevant. Merge it into master and branch-0.6 if there're no more discussions.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1214: ZEPPELIN-1224: Fix typo in method name
Posted by karup1990 <gi...@git.apache.org>.
Github user karup1990 commented on the issue:
https://github.com/apache/zeppelin/pull/1214
Makes sense. Done
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1214: ZEPPELIN-1224: Fix typo in method name
Posted by AhyoungRyu <gi...@git.apache.org>.
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/1214
I tried to find all `completor` from the root dir. That I found was all. Since it's just 8 part in 2 files (`SparkInterpreter.java` & `DepInterpreter.java`), we don't need to remain typos i think. What do you think? :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---