[GitHub] [tvm] Hzfengsy commented on a change in pull request #9527: [TIR] Allow compute_at create block predicate for non-trivial bounds and support floordiv pattern

[GitBox <gi...@apache.org>]

Hzfengsy commented on a change in pull request #9527:
URL: https://github.com/apache/tvm/pull/9527#discussion_r752065063



##########
File path: src/tir/schedule/primitive/compute_at.cc
##########
@@ -514,6 +605,14 @@ void ComputeAtOrReverseComputeAtImpl(ScheduleState self, const StmtSRef& block_s
       /*realize=*/reconstructor.new_block_realize_,
       /*loop_var_ranges=*/LoopDomainOfSRefTreePath(GetRef<StmtSRef>(block_sref->parent)),
       /*analyzer=*/&analyzer);
+  // The verifier can not prove region cover state if some complex predicte is introduced
+  // so here it explicitly reset these flags below.
+  if (is_compute_at && !is_const_int(reconstructor.new_block_realize_->predicate)) {

Review comment:
       It's a bug of `RegionCoverCheck`. We should fix it instead of working around it.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org