You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@avro.apache.org by "sarutak (via GitHub)" <gi...@apache.org> on 2023/09/20 18:26:55 UTC
[GitHub] [avro] sarutak opened a new pull request, #2508: AVRO-3865, AVRO-3866: [Build][Perl][Python] Add VERSION.txt to .gitignore
sarutak opened a new pull request, #2508:
URL: https://github.com/apache/avro/pull/2508
AVRO-3865
AVRO-3855
## What is the purpose of the change
This PR proposes to add `lang/perl/VERSION.txt` and `lang/py/VERSION.txt` to `.gitignore`.
They are created when we run `lang/perl/build.sh doc` and `lang/py/build.sh doc`
## Verifying this change
Confirmed `git status` doesn't mark `VERSION.txt` as untracked.
## Documentation
- Does this pull request introduce a new feature? (no)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [avro] sarutak commented on pull request #2508: AVRO-3865, AVRO-3866: [Build][Perl][Python] Add VERSION.txt to .gitignore
Posted by "sarutak (via GitHub)" <gi...@apache.org>.
sarutak commented on PR #2508:
URL: https://github.com/apache/avro/pull/2508#issuecomment-1729015963
> Actually the Perl build script has no doc target. It is the dist target that copies the file -
Sorry, it's a typo. I've modified it.
> IMO we should improve the build.sh scripts to clean up after themselves instead of hiding the files with .gitignore.
Or, how about just referring to `share/VERSION.txt` rather than copying it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [avro] martin-g commented on pull request #2508: AVRO-3865, AVRO-3866: [Build][Perl][Python] Add VERSION.txt to .gitignore
Posted by "martin-g (via GitHub)" <gi...@apache.org>.
martin-g commented on PR #2508:
URL: https://github.com/apache/avro/pull/2508#issuecomment-1728944782
> They are created when we run `lang/perl/build.sh doc`
Actually the Perl build script has no `doc` target. It is the `dist` target that copies the file - https://github.com/apache/avro/blob/a240cebfbf618487329257ff9f097c21ba42861c/lang/perl/build.sh#L60-L61
IMO we should improve the build.sh scripts to clean up after themselves instead of hiding the files with .gitignore.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [avro] sarutak commented on pull request #2508: AVRO-3865, AVRO-3866: [Build][Perl][Python] Add VERSION.txt to .gitignore
Posted by "sarutak (via GitHub)" <gi...@apache.org>.
sarutak commented on PR #2508:
URL: https://github.com/apache/avro/pull/2508#issuecomment-1728237669
BTW, `build.sh dist` doesn't create `lang/py/VERSION.txt` because `lang/py/build.sh dist` doesn't generates doc for Python.
That issue will be resolved in #2497
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [avro] RyanSkraba commented on pull request #2508: AVRO-3865, AVRO-3866: [Build][Perl][Python] Refer to share/VERSION.txt rather than copy it
Posted by "RyanSkraba (via GitHub)" <gi...@apache.org>.
RyanSkraba commented on PR #2508:
URL: https://github.com/apache/avro/pull/2508#issuecomment-1731274995
Wow -- thanks so much for this speedy fix :D It's magic to me when a contributor picks up a to do item that's been bugging me for ages :heart:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [avro] martin-g merged pull request #2508: AVRO-3865, AVRO-3866: [Build][Perl][Python] Refer to share/VERSION.txt rather than copy it
Posted by "martin-g (via GitHub)" <gi...@apache.org>.
martin-g merged PR #2508:
URL: https://github.com/apache/avro/pull/2508
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [avro] martin-g commented on pull request #2508: AVRO-3865, AVRO-3866: [Build][Perl][Python] Add VERSION.txt to .gitignore
Posted by "martin-g (via GitHub)" <gi...@apache.org>.
martin-g commented on PR #2508:
URL: https://github.com/apache/avro/pull/2508#issuecomment-1729022226
> Or, how about just referring to `share/VERSION.txt` rather than copying it.
Also OK if it works!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [avro] martin-g commented on pull request #2508: AVRO-3865, AVRO-3866: [Build][Perl][Python] Refer to share/VERSION.txt rather than copy it
Posted by "martin-g (via GitHub)" <gi...@apache.org>.
martin-g commented on PR #2508:
URL: https://github.com/apache/avro/pull/2508#issuecomment-1731058188
Thank you, @sarutak !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org