You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Grant Henke (Code Review)" <ge...@cloudera.org> on 2017/08/25 23:21:53 UTC

[kudu-CR] Disable the daemon usage in Jenkins Gradle build

Grant Henke has uploaded a new change for review.

  http://gerrit.cloudera.org:8080/7841

Change subject: Disable the daemon usage in Jenkins Gradle build
......................................................................

Disable the daemon usage in Jenkins Gradle build

We enable the daemon by default for user buildsbut should disable it in CI environments wherebuild isolation/correctness is paramount.Additionally we have seen daemon issues on theJenkins environment and this should resolve them orat a minimum make them more clear.

Change-Id: I8a9724bd5305fd771583d99220688b7fdab472aa
---
M build-support/jenkins/build-and-test.sh
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/41/7841/1
-- 
To view, visit http://gerrit.cloudera.org:8080/7841
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I8a9724bd5305fd771583d99220688b7fdab472aa
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Grant Henke <gr...@gmail.com>

[kudu-CR] Disable the daemon usage in Jenkins Gradle build

Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has uploaded a new patch set (#2).

Change subject: Disable the daemon usage in Jenkins Gradle build
......................................................................

Disable the daemon usage in Jenkins Gradle build

We enable the daemon by default for user builds
but should disable it in CI environments where
build isolation/correctness is paramount.

Additionally we have seen daemon issues on the
Jenkins environment and this should resolve them or
at a minimum make them more clear.

Change-Id: I8a9724bd5305fd771583d99220688b7fdab472aa
---
M build-support/jenkins/build-and-test.sh
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/41/7841/2
-- 
To view, visit http://gerrit.cloudera.org:8080/7841
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I8a9724bd5305fd771583d99220688b7fdab472aa
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Grant Henke <gr...@gmail.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins

[kudu-CR] Disable the daemon usage in Jenkins Gradle build

Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change.

Change subject: Disable the daemon usage in Jenkins Gradle build
......................................................................


Patch Set 2: Code-Review+2

-- 
To view, visit http://gerrit.cloudera.org:8080/7841
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8a9724bd5305fd771583d99220688b7fdab472aa
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Grant Henke <gr...@gmail.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No

[kudu-CR] Disable the daemon usage in Jenkins Gradle build

Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change.

Change subject: Disable the daemon usage in Jenkins Gradle build
......................................................................


Patch Set 3: Code-Review+2

-- 
To view, visit http://gerrit.cloudera.org:8080/7841
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8a9724bd5305fd771583d99220688b7fdab472aa
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Grant Henke <gr...@gmail.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No

[kudu-CR] Disable the daemon usage in Jenkins Gradle build

Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change.

Change subject: Disable the daemon usage in Jenkins Gradle build
......................................................................


Patch Set 2: Code-Review+2

-- 
To view, visit http://gerrit.cloudera.org:8080/7841
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8a9724bd5305fd771583d99220688b7fdab472aa
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Grant Henke <gr...@gmail.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No

[kudu-CR] Disable the daemon usage in Jenkins Gradle build

Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has submitted this change and it was merged.

Change subject: Disable the daemon usage in Jenkins Gradle build
......................................................................


Disable the daemon usage in Jenkins Gradle build

We enable the daemon by default for user builds
but should disable it in CI environments where
build isolation/correctness is paramount.

Additionally we have seen daemon issues on the
Jenkins environment and this should resolve them or
at a minimum make them more clear.

Change-Id: I8a9724bd5305fd771583d99220688b7fdab472aa
Reviewed-on: http://gerrit.cloudera.org:8080/7841
Tested-by: Kudu Jenkins
Reviewed-by: Todd Lipcon <to...@apache.org>
---
M build-support/jenkins/build-and-test.sh
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Todd Lipcon: Looks good to me, approved
  Kudu Jenkins: Verified



-- 
To view, visit http://gerrit.cloudera.org:8080/7841
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I8a9724bd5305fd771583d99220688b7fdab472aa
Gerrit-PatchSet: 4
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Grant Henke <gr...@gmail.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>