You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Dmytro Sen <ds...@hortonworks.com> on 2014/09/15 17:56:39 UTC

Review Request 25649: Incorrect name for turning on/off Maintenance Mode in Background operations window

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25649/
-----------------------------------------------------------

Review request for Ambari and Dmitro Lisnichenko.


Bugs: AMBARI-7311
    https://issues.apache.org/jira/browse/AMBARI-7311


Repository: ambari


Description
-------

Steps:
Try turn On/Off Maintenance Mode for any service.
Open Background operations window.
Result: there are present 'Update Nagios configuration' operation instead turning on/of MM.


Diffs
-----

  ambari-server/src/main/java/org/apache/ambari/server/controller/MaintenanceStateHelper.java 059e2c9 

Diff: https://reviews.apache.org/r/25649/diff/


Testing
-------

[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 18:42.223s
[INFO] Finished at: Mon Sep 15 18:54:14 EEST 2014
[INFO] Final Memory: 120M/1257M


Thanks,

Dmytro Sen


Re: Review Request 25649: Incorrect name for turning on/off Maintenance Mode in Background operations window

Posted by Dmitro Lisnichenko <dl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25649/#review53825
-----------------------------------------------------------

Ship it!


Ship It!

- Dmitro Lisnichenko


On Sept. 18, 2014, 3:07 p.m., Dmytro Sen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25649/
> -----------------------------------------------------------
> 
> (Updated Sept. 18, 2014, 3:07 p.m.)
> 
> 
> Review request for Ambari and Dmitro Lisnichenko.
> 
> 
> Bugs: AMBARI-7311
>     https://issues.apache.org/jira/browse/AMBARI-7311
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Steps:
> Try turn On/Off Maintenance Mode for any service.
> Open Background operations window.
> Result: there are present 'Update Nagios configuration' operation instead turning on/of MM.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/MaintenanceStateHelper.java 2222f24 
> 
> Diff: https://reviews.apache.org/r/25649/diff/
> 
> 
> Testing
> -------
> 
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 18:42.223s
> [INFO] Finished at: Mon Sep 15 18:54:14 EEST 2014
> [INFO] Final Memory: 120M/1257M
> 
> 
> Thanks,
> 
> Dmytro Sen
> 
>


Re: Review Request 25649: Incorrect name for turning on/off Maintenance Mode in Background operations window

Posted by Dmytro Sen <ds...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25649/
-----------------------------------------------------------

(Updated Сен. 18, 2014, 3:07 п.п.)


Review request for Ambari and Dmitro Lisnichenko.


Bugs: AMBARI-7311
    https://issues.apache.org/jira/browse/AMBARI-7311


Repository: ambari


Description
-------

Steps:
Try turn On/Off Maintenance Mode for any service.
Open Background operations window.
Result: there are present 'Update Nagios configuration' operation instead turning on/of MM.


Diffs (updated)
-----

  ambari-server/src/main/java/org/apache/ambari/server/controller/MaintenanceStateHelper.java 2222f24 

Diff: https://reviews.apache.org/r/25649/diff/


Testing
-------

[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 18:42.223s
[INFO] Finished at: Mon Sep 15 18:54:14 EEST 2014
[INFO] Final Memory: 120M/1257M


Thanks,

Dmytro Sen


Re: Review Request 25649: Incorrect name for turning on/off Maintenance Mode in Background operations window

Posted by Dmitro Lisnichenko <dl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25649/#review53346
-----------------------------------------------------------



ambari-server/src/main/java/org/apache/ambari/server/controller/MaintenanceStateHelper.java
<https://reviews.apache.org/r/25649/#comment92979>

    Not sure it is a good text. This operation is issued when we disable MM


- Dmitro Lisnichenko


On Sept. 15, 2014, 3:56 p.m., Dmytro Sen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25649/
> -----------------------------------------------------------
> 
> (Updated Sept. 15, 2014, 3:56 p.m.)
> 
> 
> Review request for Ambari and Dmitro Lisnichenko.
> 
> 
> Bugs: AMBARI-7311
>     https://issues.apache.org/jira/browse/AMBARI-7311
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Steps:
> Try turn On/Off Maintenance Mode for any service.
> Open Background operations window.
> Result: there are present 'Update Nagios configuration' operation instead turning on/of MM.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/MaintenanceStateHelper.java 059e2c9 
> 
> Diff: https://reviews.apache.org/r/25649/diff/
> 
> 
> Testing
> -------
> 
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 18:42.223s
> [INFO] Finished at: Mon Sep 15 18:54:14 EEST 2014
> [INFO] Final Memory: 120M/1257M
> 
> 
> Thanks,
> 
> Dmytro Sen
> 
>