You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/04/18 12:59:49 UTC

[GitHub] [spark] cxzl25 opened a new pull request, #36245: [SPARK-38936][SQL] Script transform feed thread should have name

cxzl25 opened a new pull request, #36245:
URL: https://github.com/apache/spark/pull/36245

   ### What changes were proposed in this pull request?
   re-add thread name(`Thread-ScriptTransformation-Feed`).
   
   ### Why are the changes needed?
   Lost feed thread name after [SPARK-32105](https://issues.apache.org/jira/browse/SPARK-32105) refactoring.
   
   ### Does this PR introduce _any_ user-facing change?
   No
   
   
   ### How was this patch tested?
   exist UT
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] HyukjinKwon commented on pull request #36245: [SPARK-38936][SQL] Script transform feed thread should have name

Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on PR #36245:
URL: https://github.com/apache/spark/pull/36245#issuecomment-1104645674

   Merged to master and branch-3.3, branch-3.2 and branch-3.1.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] HyukjinKwon closed pull request #36245: [SPARK-38936][SQL] Script transform feed thread should have name

Posted by GitBox <gi...@apache.org>.
HyukjinKwon closed pull request #36245: [SPARK-38936][SQL] Script transform feed thread should have name
URL: https://github.com/apache/spark/pull/36245


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on pull request #36245: [SPARK-38936][SQL] Script transform feed thread should have name

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on PR #36245:
URL: https://github.com/apache/spark/pull/36245#issuecomment-1101654960

   Can one of the admins verify this patch?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] cxzl25 commented on a diff in pull request #36245: [SPARK-38936][SQL] Script transform feed thread should have name

Posted by GitBox <gi...@apache.org>.
cxzl25 commented on code in PR #36245:
URL: https://github.com/apache/spark/pull/36245#discussion_r854313221


##########
sql/core/src/main/scala/org/apache/spark/sql/execution/BaseScriptTransformationExec.scala:
##########
@@ -262,7 +262,8 @@ trait BaseScriptTransformationExec extends UnaryExecNode {
       }
 }
 
-abstract class BaseScriptTransformationWriterThread extends Thread with Logging {
+abstract class BaseScriptTransformationWriterThread
+  extends Thread("Thread-ScriptTransformation-Feed") with Logging {

Review Comment:
   We can follow a format like this.
   https://github.com/apache/spark/blob/8acce8885964fcb5b23046bdac8a882d723f35cc/sql/core/src/main/scala/org/apache/spark/sql/execution/BaseScriptTransformationExec.scala#L100
   
   ![image](https://user-images.githubusercontent.com/3898450/164274148-e3097a81-4a76-4d24-85f3-0b8ec5822f81.png)
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] HyukjinKwon commented on a diff in pull request #36245: [SPARK-38936][SQL] Script transform feed thread should have name

Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on code in PR #36245:
URL: https://github.com/apache/spark/pull/36245#discussion_r853683619


##########
sql/core/src/main/scala/org/apache/spark/sql/execution/BaseScriptTransformationExec.scala:
##########
@@ -262,7 +262,8 @@ trait BaseScriptTransformationExec extends UnaryExecNode {
       }
 }
 
-abstract class BaseScriptTransformationWriterThread extends Thread with Logging {
+abstract class BaseScriptTransformationWriterThread
+  extends Thread("Thread-ScriptTransformation-Feed") with Logging {

Review Comment:
   Looks fine but can we check if this naming is consistent with others?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] HyukjinKwon commented on pull request #36245: [SPARK-38936][SQL] Script transform feed thread should have name

Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on PR #36245:
URL: https://github.com/apache/spark/pull/36245#issuecomment-1103417894

   cc @AngersZhuuuu FYI .


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org