[PR] [DSIP-17263][Task] Render SQL parameters before statement execution [dolphinscheduler]

["qiuyanjun888 (via GitHub)" <gi...@apache.org>]

qiuyanjun888 opened a new pull request, #18396:
URL: https://github.com/apache/dolphinscheduler/pull/18396

   ## Purpose
   
   Fix #17263
   
   Render SQL task custom parameters locally before submitting SQL through JDBC `Statement`, avoiding `PreparedStatement` for SQL text that already contains DolphinScheduler parameter syntax.
   
   ## Changes
   
   - Add a SQL task local parameter renderer for `${name}` and `!{name}` placeholders.
   - Render normal `${name}` placeholders as SQL literals by default, including escaping string-like values and validating typed literals.
   - Preserve raw `!{name}` replacement for trusted SQL fragments without rescanning rendered replacement text.
   - Use JDBC `Statement` to execute rendered SQL in `SqlTask`.
   - Document SQL task parameter rendering rules and raw replacement constraints.
   - Add regression coverage for identifier fragments, list values, quoted strings, raw fragments, malformed typed literals, and Statement execution.
   
   ## Tests
   
   - `./mvnw -pl dolphinscheduler-task-plugin/dolphinscheduler-task-sql -am -DskipUT=false -DskipITs -DskipE2E -Dcheckstyle.skip -Dspotless.check.skip -Djacoco.skip=true -Dsurefire.failIfNoSpecifiedTests=false -Dtest=SqlTaskTest test`
   - `./mvnw -pl dolphinscheduler-task-plugin/dolphinscheduler-task-sql -am spotless:apply`
   - `git diff --check`
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [DSIP-89][Task] Render SQL parameters before statement execution [dolphinscheduler]

["SbloodyS (via GitHub)" <gi...@apache.org>]

SbloodyS commented on PR #18396:
URL: https://github.com/apache/dolphinscheduler/pull/18396#issuecomment-4889994139

   You should follow PR template to claim you are using AI.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [DSIP-89][Task] Render SQL parameters before statement execution [dolphinscheduler]

["SbloodyS (via GitHub)" <gi...@apache.org>]

SbloodyS closed pull request #18396: [DSIP-89][Task] Render SQL parameters before statement execution
URL: https://github.com/apache/dolphinscheduler/pull/18396


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org