You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@activemq.apache.org by spyrkob <gi...@git.apache.org> on 2018/11/14 16:24:26 UTC
[GitHub] activemq-artemis pull request #2432: [ARTEMIS-2176] RA connection properties...
GitHub user spyrkob opened a pull request:
https://github.com/apache/activemq-artemis/pull/2432
[ARTEMIS-2176] RA connection properties are not propagated to XARecov…
…eryConfig
Possible fix and test for https://issues.apache.org/jira/browse/ARTEMIS-2176
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/spyrkob/jboss-activemq-artemis ARTEMIS-2176
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/activemq-artemis/pull/2432.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2432
----
commit 96b3d87be7448626ad777ea3b32a185c0fb3b5f3
Author: Bartosz Spyrko-Smietanko <bs...@...>
Date: 2018-11-13T15:50:33Z
[ARTEMIS-2176] RA connection properties are not propagated to XARecoveryConfig
----
---
[GitHub] activemq-artemis pull request #2432: [ARTEMIS-2176] RA connection properties...
Posted by spyrkob <gi...@git.apache.org>.
Github user spyrkob commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2432#discussion_r237094610
--- Diff: artemis-service-extensions/src/main/java/org/apache/activemq/artemis/service/extensions/xa/recovery/XARecoveryConfig.java ---
@@ -45,16 +45,41 @@
private final Map<String, String> properties;
private final ClientProtocolManagerFactory clientProtocolManager;
+ // ServerLocator properties
--- End diff --
@clebertsuconic does that answer your question?
---
[GitHub] activemq-artemis pull request #2432: [ARTEMIS-2176] RA connection properties...
Posted by spyrkob <gi...@git.apache.org>.
Github user spyrkob commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2432#discussion_r233862871
--- Diff: artemis-service-extensions/src/main/java/org/apache/activemq/artemis/service/extensions/xa/recovery/XARecoveryConfig.java ---
@@ -45,16 +45,41 @@
private final Map<String, String> properties;
private final ClientProtocolManagerFactory clientProtocolManager;
+ // ServerLocator properties
--- End diff --
@clebertsuconic I was trying to make them available in createServerLocator() so that I can apply them to new instances of ServerLocator. Would it be better to hold a reference to original locator/factory instead? Or is there a better way to pass those properties I missed?
---
[GitHub] activemq-artemis pull request #2432: [ARTEMIS-2176] RA connection properties...
Posted by clebertsuconic <gi...@git.apache.org>.
Github user clebertsuconic commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2432#discussion_r233540277
--- Diff: artemis-service-extensions/src/main/java/org/apache/activemq/artemis/service/extensions/xa/recovery/XARecoveryConfig.java ---
@@ -45,16 +45,41 @@
private final Map<String, String> properties;
private final ClientProtocolManagerFactory clientProtocolManager;
+ // ServerLocator properties
--- End diff --
why you had to bring those here?
---
[GitHub] activemq-artemis pull request #2432: [ARTEMIS-2176] RA connection properties...
Posted by clebertsuconic <gi...@git.apache.org>.
Github user clebertsuconic commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2432#discussion_r233860659
--- Diff: artemis-service-extensions/src/main/java/org/apache/activemq/artemis/service/extensions/xa/recovery/XARecoveryConfig.java ---
@@ -45,16 +45,41 @@
private final Map<String, String> properties;
private final ClientProtocolManagerFactory clientProtocolManager;
+ // ServerLocator properties
--- End diff --
@spyrkob ?? ^^^
---