Re: [PR] SLING-12283 : changed the config Pid to separate factoryPID & PID wit… [sling-org-apache-sling-installer-factory-configuration]

["jsedding (via GitHub)" <gi...@apache.org>]

jsedding commented on code in PR #13:
URL: https://github.com/apache/sling-org-apache-sling-installer-factory-configuration/pull/13#discussion_r1650485640


##########
src/main/java/org/apache/sling/installer/factories/configuration/impl/ConfigInstallTask.java:
##########
@@ -92,6 +92,9 @@ public void execute(final InstallationContext ctx) {
                 }
 
                 Configuration config = ConfigUtil.getConfiguration(this.getConfigurationAdmin(), this.factoryPid, this.configPid);
+                if (config == null) {
+                    config = ConfigUtil.getLegacyFactoryConfig(this.getConfigurationAdmin(), this.factoryPid, null, this.configPid);
+                }

Review Comment:
   We need it for deletion in case the config is removed on another cluster node, where it has the '~'-separated format.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org