[GitHub] [apisix] dmsolr opened a new pull request #4548: fix: balancer() function was not invoked after load_balancer phase

[GitBox <gi...@apache.org>]

dmsolr opened a new pull request #4548:
URL: https://github.com/apache/apisix/pull/4548


   ### What this PR does / why we need it:
   <!--- Why is this change required? What problem does it solve? -->
   <!--- If it fixes an open issue, please link to the issue here. -->
   
   ### Pre-submission checklist:
   
   * [x] Did you explain what problem does this PR solve? Or what new features have been added?
   * [ ] Have you added corresponding test cases?
   * [ ] Have you modified the corresponding document?
   * [ ] Is this PR backward compatible? **If it is not backward compatible, please discuss on the [mailing list](https://github.com/apache/apisix/tree/master#community) first**
   
   I found, now, APISIX does not invoke plugin's balancer function.
   As far as I learned, we have added `common_phase("balancer")` at the end of the balancer function.
   At actually, it really works.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix] dmsolr closed pull request #4548: feat: allow plugin running in the balancer phase

[GitBox <gi...@apache.org>]

dmsolr closed pull request #4548:
URL: https://github.com/apache/apisix/pull/4548


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix] tokers commented on pull request #4548: feat: allow plugin running in the balancer phase

[GitBox <gi...@apache.org>]

tokers commented on pull request #4548:
URL: https://github.com/apache/apisix/pull/4548#issuecomment-875210629


   @dmsolr Please add some test cases to cover it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org