[GitHub] [incubator-pekko-grpc] mdedetrich commented on pull request #121: pekko http 1.0.0

["mdedetrich (via GitHub)" <gi...@apache.org>]

mdedetrich commented on PR #121:
URL: https://github.com/apache/incubator-pekko-grpc/pull/121#issuecomment-1662161348

   > @mdedetrich I changed the Maven poms but I am very wary of changing the PekkoGrpcPlugin.groovy file. I suspect that the logic there, which is encased in an `if` statement, is related to users being able to test snapshot releases of pekko-grpc as opposed to being used for getting snapshot releases of pekko core or pekko-http.
   
   Yes this correct but the reason I suggested the change is that `url "https://oss.sonatype.org/content/repositories/snapshots" ` was pointing to where Akka used to store akka-grpc snapshots, in our case however we store the snapshots in `https://repository.apache.org/content/groups/snapshots` and as you can see from https://github.com/apache/incubator-pekko-grpc/blob/a605bcfbfd881d433fabdc12dfc05972c9f7b2b7/gradle-plugin/src/main/groovy/org/apache/pekko/grpc/gradle/PekkoGrpcPlugin.groovy#L57-L64 they are both listed there when there should only be `https://repository.apache.org/content/groups/snapshots`.
   
   This was an accident from a previous PR but I can also fix this in a separate PR from this.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org