You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hugegraph.apache.org by "imbajin (via GitHub)" <gi...@apache.org> on 2026/10/14 20:48:50 UTC
[PR] fix(ci): include CDC launcher helper [hugegraph-toolchain]
imbajin opened a new pull request, #822:
URL: https://github.com/apache/hugegraph-toolchain/pull/822
## Purpose of the PR
The CDC recovery fixture copied only the launcher, so its shared parameter helper was missing and validation stopped before Flink submission. Copy both existing scripts into the fixture bin directory. This follows [ASF #819](https://github.com/apache/hugegraph-toolchain/pull/819) and changes only the test fixture.
## Verifying these changes
The local control reproduces the missing-helper failure with the original fixture layout. With this change, the actual fixture launcher loads the native helper and reaches a mock Flink executable with argument boundaries preserved; a missing value still prevents submission. Existing launcher checks, Python helper tests, Python compilation and `git diff --check` pass.
The native Docker CDC snapshot/recovery scenario now passes in [the source PR's CI](https://github.com/hugegraph/hugegraph-toolchain/actions/runs/38633061648/job/116090150916), together with its license checks.
## Does this PR potentially affect the following parts?
- [ ] Dependencies
- [ ] Modify configurations
- [ ] The public API
- [ ] Other affects
- [x] Nope: test-fixture layout only
## Documentation Status
- [ ] `Doc - TODO`
- [ ] `Doc - Done`
- [x] `Doc - No Need`: test fixture only; product behavior and documentation are unchanged.
Paired source PR: https://github.com/hugegraph/hugegraph-toolchain/pull/74
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For additional commands, e-mail: issues-help@hugegraph.apache.org
Re: [PR] fix(ci): include CDC launcher helper [hugegraph-toolchain]
Posted by "imbajin (via GitHub)" <gi...@apache.org>.
imbajin merged PR #822:
URL: https://github.com/apache/hugegraph-toolchain/pull/822
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For additional commands, e-mail: issues-help@hugegraph.apache.org
Re: [PR] fix(ci): include CDC launcher helper [hugegraph-toolchain]
Posted by "imbajin (via GitHub)" <gi...@apache.org>.
imbajin commented on code in PR #822:
URL: https://github.com/apache/hugegraph-toolchain/pull/822#discussion_r4277863811
##########
hugegraph-loader/assembly/travis/flink-cdc/verify.py:
##########
@@ -258,8 +258,9 @@ def start_flink_mysql(self):
shutil.copyfile(jar, destination)
with jar.open("rb") as stream:
self.report["job_sha256"] = hashlib.file_digest(stream, "sha256").hexdigest()
- shutil.copyfile(Path(__file__).parents[2] / "static/bin/hugegraph-flinkcdc-loader.sh",
- job / "bin/hugegraph-flinkcdc-loader.sh")
+ for script in ("hugegraph-flinkcdc-loader.sh", "get-params.sh"):
Review Comment:
Shared `get-params.sh` edits now select both existing Spark Loader and Flink CDC lanes; each dedicated launcher still selects only its own lane. The existing CI-policy regression reproduces the old omission and passes after this two-file selector/test fix, alongside the full Python 3.13 policy suite (with its existing Server-only skip). No product script or runtime fixture was changed in this update, and the new head's CI is tracked separately from the earlier packaged CDC result.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For additional commands, e-mail: issues-help@hugegraph.apache.org
Re: [PR] fix(ci): include CDC launcher helper [hugegraph-toolchain]
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #822:
URL: https://github.com/apache/hugegraph-toolchain/pull/822#issuecomment-6180337800
## [Codecov](https://app.codecov.io/gh/apache/hugegraph-toolchain/pull/822?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 55.72%. Comparing base ([`bcd5ce2`](https://app.codecov.io/gh/apache/hugegraph-toolchain/commit/bcd5ce21533db745087d2bc7e8cd1f9969a21756?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`c4e6457`](https://app.codecov.io/gh/apache/hugegraph-toolchain/commit/c4e64574e52dcc042a8457dfa8b4b82cb60ba109?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 3 commits behind head on master.
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #822 +/- ##
============================================
+ Coverage 47.06% 55.72% +8.66%
+ Complexity 4518 1136 -3382
============================================
Files 602 111 -491
Lines 29452 6268 -23184
Branches 3456 840 -2616
============================================
- Hits 13862 3493 -10369
+ Misses 14308 2511 -11797
+ Partials 1282 264 -1018
```
</details>
[:umbrella: View full report in Codecov by Harness](https://app.codecov.io/gh/apache/hugegraph-toolchain/pull/822?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For additional commands, e-mail: issues-help@hugegraph.apache.org
Re: [PR] fix(ci): include CDC launcher helper [hugegraph-toolchain]
Posted by "bitflicker64 (via GitHub)" <gi...@apache.org>.
bitflicker64 commented on code in PR #822:
URL: https://github.com/apache/hugegraph-toolchain/pull/822#discussion_r4277810893
##########
hugegraph-loader/assembly/travis/flink-cdc/verify.py:
##########
@@ -258,8 +258,9 @@ def start_flink_mysql(self):
shutil.copyfile(jar, destination)
with jar.open("rb") as stream:
self.report["job_sha256"] = hashlib.file_digest(stream, "sha256").hexdigest()
- shutil.copyfile(Path(__file__).parents[2] / "static/bin/hugegraph-flinkcdc-loader.sh",
- job / "bin/hugegraph-flinkcdc-loader.sh")
+ for script in ("hugegraph-flinkcdc-loader.sh", "get-params.sh"):
Review Comment:
Important: This fixture now copies `get-params.sh`, and since #819 `hugegraph-flinkcdc-loader.sh` sources it (line 54) to validate every submission. But a PR that changes only `get-params.sh` never runs the Flink CDC lane. In `.github/scripts/ci-policy.py` `optional_checks`, `get-params.sh` sets `spark_loader` only (lines 105-106), while `flink_cdc` (lines 109-113) lists the Flink launcher but not its helper. At this head, `optional_checks(["hugegraph-loader/assembly/static/bin/get-params.sh"])` returns `flink_cdc: False`, and `test_engine_launchers_select_only_their_actual_runtime_lane` in `test_ci_policy.py` (lines 309-318) asserts that result. With `flink_cdc` false, neither `flink-launcher.test.cjs` nor `packaged-cdc-recovery` runs, because both live only in `flink-cdc-ci.yml`. So a helper change that breaks Flink submission, such as a new `return 2` path that the Flink argument shape hits, would merge with green CI, the same failure this PR repairs. This gap predates the PR,
which does not widen it. Please add `LOADER + "assembly/static/bin/get-params.sh"` to the `flink_cdc` condition and change the `get-params.sh` case in the test to expect both `spark_loader` and `flink_cdc`, either here or in a follow-up.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For additional commands, e-mail: issues-help@hugegraph.apache.org