You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@falcon.apache.org by Srikanth Sundarrajan <sr...@hotmail.com> on 2013/07/27 14:02:19 UTC
Re: Review Request 12987: Properties load should fall back to classpath if
not present in config.location
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12987/
-----------------------------------------------------------
(Updated July 27, 2013, 12:02 p.m.)
Review request for Falcon.
Bugs: FALCON-65
https://issues.apache.org/jira/browse/FALCON-65
Repository: falcon-git
Description
-------
Properties load should fall back to classpath if not present in config.location
Diffs
-----
common/src/main/java/org/apache/falcon/util/ApplicationProperties.java 3746729
common/src/main/resources/startup.properties 4ff00d7
common/src/test/java/org/apache/falcon/util/ApplicationPropertiesTest.java PRE-CREATION
common/src/test/java/org/apache/falcon/util/StartupPropertiesTest.java 6b2ec06
common/src/test/resources/classpath.properties PRE-CREATION
pom.xml ca16762
src/bin/falcon-start 9a68220
webapp/pom.xml 6743527
Diff: https://reviews.apache.org/r/12987/diff/
Testing
-------
Thanks,
Srikanth Sundarrajan
Re: Review Request 12987: Properties load should fall back to classpath if
not present in config.location
Posted by Seetharam Venkatesh <ve...@innerzeal.com>.
> On July 28, 2013, 6:04 a.m., Seetharam Venkatesh wrote:
> > Ship It!
You need to add me as a reviewer so I can cancel my comments?
Sorry, I updated the review prematurely. I do see one issue. Somehow I see each of the properties being initialized twice apart from logging it twice in each. I'm attaching the application.log for your convenience in the jira.
- Seetharam
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12987/#review24055
-----------------------------------------------------------
On July 27, 2013, 12:02 p.m., Srikanth Sundarrajan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12987/
> -----------------------------------------------------------
>
> (Updated July 27, 2013, 12:02 p.m.)
>
>
> Review request for Falcon.
>
>
> Bugs: FALCON-65
> https://issues.apache.org/jira/browse/FALCON-65
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> Properties load should fall back to classpath if not present in config.location
>
>
> Diffs
> -----
>
> common/src/main/java/org/apache/falcon/util/ApplicationProperties.java 3746729
> common/src/main/resources/startup.properties 4ff00d7
> common/src/test/java/org/apache/falcon/util/ApplicationPropertiesTest.java PRE-CREATION
> common/src/test/java/org/apache/falcon/util/StartupPropertiesTest.java 6b2ec06
> common/src/test/resources/classpath.properties PRE-CREATION
> pom.xml ca16762
> src/bin/falcon-start 9a68220
> webapp/pom.xml 6743527
>
> Diff: https://reviews.apache.org/r/12987/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Srikanth Sundarrajan
>
>
Re: Review Request 12987: Properties load should fall back to classpath if
not present in config.location
Posted by Seetharam Venkatesh <ve...@innerzeal.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12987/#review24055
-----------------------------------------------------------
Ship it!
Ship It!
- Seetharam Venkatesh
On July 27, 2013, 12:02 p.m., Srikanth Sundarrajan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12987/
> -----------------------------------------------------------
>
> (Updated July 27, 2013, 12:02 p.m.)
>
>
> Review request for Falcon.
>
>
> Bugs: FALCON-65
> https://issues.apache.org/jira/browse/FALCON-65
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> Properties load should fall back to classpath if not present in config.location
>
>
> Diffs
> -----
>
> common/src/main/java/org/apache/falcon/util/ApplicationProperties.java 3746729
> common/src/main/resources/startup.properties 4ff00d7
> common/src/test/java/org/apache/falcon/util/ApplicationPropertiesTest.java PRE-CREATION
> common/src/test/java/org/apache/falcon/util/StartupPropertiesTest.java 6b2ec06
> common/src/test/resources/classpath.properties PRE-CREATION
> pom.xml ca16762
> src/bin/falcon-start 9a68220
> webapp/pom.xml 6743527
>
> Diff: https://reviews.apache.org/r/12987/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Srikanth Sundarrajan
>
>
Re: Review Request 12987: Properties load should fall back to classpath if
not present in config.location
Posted by Seetharam Venkatesh <ve...@innerzeal.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12987/#review24148
-----------------------------------------------------------
Ship it!
Ship It!
- Seetharam Venkatesh
On July 29, 2013, 4:50 p.m., Srikanth Sundarrajan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12987/
> -----------------------------------------------------------
>
> (Updated July 29, 2013, 4:50 p.m.)
>
>
> Review request for Falcon.
>
>
> Bugs: FALCON-65
> https://issues.apache.org/jira/browse/FALCON-65
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> Properties load should fall back to classpath if not present in config.location
>
>
> Diffs
> -----
>
> common/src/main/java/org/apache/falcon/util/ApplicationProperties.java 3746729
> common/src/main/resources/log4j.xml 4183181
> common/src/main/resources/startup.properties 4ff00d7
> common/src/test/java/org/apache/falcon/util/ApplicationPropertiesTest.java PRE-CREATION
> common/src/test/java/org/apache/falcon/util/StartupPropertiesTest.java 6b2ec06
> common/src/test/resources/classpath.properties PRE-CREATION
> pom.xml b1595fb
> prism/src/main/resources/log4j.xml ef53274
> src/bin/falcon-start 9a68220
> src/conf/log4j.xml 738beb5
> src/conf/startup.properties a1fdab2
> webapp/pom.xml 9c2f320
> webapp/src/main/resources/log4j.xml 48fc14b
>
> Diff: https://reviews.apache.org/r/12987/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Srikanth Sundarrajan
>
>
Re: Review Request 12987: Properties load should fall back to classpath if
not present in config.location
Posted by Srikanth Sundarrajan <sr...@hotmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12987/
-----------------------------------------------------------
(Updated July 29, 2013, 4:50 p.m.)
Review request for Falcon.
Changes
-------
1. log4j changes
2. hadoop - exclude jasper libs
3. fix startup.properties for system.lib folder
Bugs: FALCON-65
https://issues.apache.org/jira/browse/FALCON-65
Repository: falcon-git
Description
-------
Properties load should fall back to classpath if not present in config.location
Diffs (updated)
-----
common/src/main/java/org/apache/falcon/util/ApplicationProperties.java 3746729
common/src/main/resources/log4j.xml 4183181
common/src/main/resources/startup.properties 4ff00d7
common/src/test/java/org/apache/falcon/util/ApplicationPropertiesTest.java PRE-CREATION
common/src/test/java/org/apache/falcon/util/StartupPropertiesTest.java 6b2ec06
common/src/test/resources/classpath.properties PRE-CREATION
pom.xml b1595fb
prism/src/main/resources/log4j.xml ef53274
src/bin/falcon-start 9a68220
src/conf/log4j.xml 738beb5
src/conf/startup.properties a1fdab2
webapp/pom.xml 9c2f320
webapp/src/main/resources/log4j.xml 48fc14b
Diff: https://reviews.apache.org/r/12987/diff/
Testing
-------
Thanks,
Srikanth Sundarrajan
Re: Review Request 12987: Properties load should fall back to classpath if
not present in config.location
Posted by Srikanth Sundarrajan <sr...@hotmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12987/
-----------------------------------------------------------
(Updated July 28, 2013, 1:43 p.m.)
Review request for Falcon.
Changes
-------
log4j.xml needed to be modified with appropriate additivity configuration.
Bugs: FALCON-65
https://issues.apache.org/jira/browse/FALCON-65
Repository: falcon-git
Description
-------
Properties load should fall back to classpath if not present in config.location
Diffs (updated)
-----
common/src/main/java/org/apache/falcon/util/ApplicationProperties.java 3746729
common/src/main/resources/log4j.xml 4183181
common/src/main/resources/startup.properties 4ff00d7
common/src/test/java/org/apache/falcon/util/ApplicationPropertiesTest.java PRE-CREATION
common/src/test/java/org/apache/falcon/util/StartupPropertiesTest.java 6b2ec06
common/src/test/resources/classpath.properties PRE-CREATION
pom.xml ca16762
prism/src/main/resources/log4j.xml ef53274
src/bin/falcon-start 9a68220
webapp/pom.xml 6743527
webapp/src/main/resources/log4j.xml 48fc14b
Diff: https://reviews.apache.org/r/12987/diff/
Testing
-------
Thanks,
Srikanth Sundarrajan
Re: Review Request 12987: Properties load should fall back to classpath if
not present in config.location
Posted by Seetharam Venkatesh <ve...@innerzeal.com>.
> On July 27, 2013, 6 p.m., Seetharam Venkatesh wrote:
> > All the changes look good. You had to create dependencies to work around the pom.version. I do not understand the changes to filtering in super pom. You exclude in one and include in another. Can you please clarify what is going on?
>
> Srikanth Sundarrajan wrote:
> We exclude startup.properties, runtime.properties & log4j.xml from filtering by adding them in the exclude section. But excluding them will prevent them from being copied entirely. So another section is added to include them, but now without performing the maven resource filtering. Does that help ?
Thanks Srikanth. I think I get it. :-)
Verified the build, all unit and integration tests pass. Also verified the properties files loading is correct.
- Seetharam
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12987/#review24035
-----------------------------------------------------------
On July 27, 2013, 12:02 p.m., Srikanth Sundarrajan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12987/
> -----------------------------------------------------------
>
> (Updated July 27, 2013, 12:02 p.m.)
>
>
> Review request for Falcon.
>
>
> Bugs: FALCON-65
> https://issues.apache.org/jira/browse/FALCON-65
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> Properties load should fall back to classpath if not present in config.location
>
>
> Diffs
> -----
>
> common/src/main/java/org/apache/falcon/util/ApplicationProperties.java 3746729
> common/src/main/resources/startup.properties 4ff00d7
> common/src/test/java/org/apache/falcon/util/ApplicationPropertiesTest.java PRE-CREATION
> common/src/test/java/org/apache/falcon/util/StartupPropertiesTest.java 6b2ec06
> common/src/test/resources/classpath.properties PRE-CREATION
> pom.xml ca16762
> src/bin/falcon-start 9a68220
> webapp/pom.xml 6743527
>
> Diff: https://reviews.apache.org/r/12987/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Srikanth Sundarrajan
>
>
Re: Review Request 12987: Properties load should fall back to classpath if
not present in config.location
Posted by Srikanth Sundarrajan <sr...@hotmail.com>.
> On July 27, 2013, 6 p.m., Seetharam Venkatesh wrote:
> > All the changes look good. You had to create dependencies to work around the pom.version. I do not understand the changes to filtering in super pom. You exclude in one and include in another. Can you please clarify what is going on?
We exclude startup.properties, runtime.properties & log4j.xml from filtering by adding them in the exclude section. But excluding them will prevent them from being copied entirely. So another section is added to include them, but now without performing the maven resource filtering. Does that help ?
- Srikanth
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12987/#review24035
-----------------------------------------------------------
On July 27, 2013, 12:02 p.m., Srikanth Sundarrajan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12987/
> -----------------------------------------------------------
>
> (Updated July 27, 2013, 12:02 p.m.)
>
>
> Review request for Falcon.
>
>
> Bugs: FALCON-65
> https://issues.apache.org/jira/browse/FALCON-65
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> Properties load should fall back to classpath if not present in config.location
>
>
> Diffs
> -----
>
> common/src/main/java/org/apache/falcon/util/ApplicationProperties.java 3746729
> common/src/main/resources/startup.properties 4ff00d7
> common/src/test/java/org/apache/falcon/util/ApplicationPropertiesTest.java PRE-CREATION
> common/src/test/java/org/apache/falcon/util/StartupPropertiesTest.java 6b2ec06
> common/src/test/resources/classpath.properties PRE-CREATION
> pom.xml ca16762
> src/bin/falcon-start 9a68220
> webapp/pom.xml 6743527
>
> Diff: https://reviews.apache.org/r/12987/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Srikanth Sundarrajan
>
>
Re: Review Request 12987: Properties load should fall back to classpath if
not present in config.location
Posted by Seetharam Venkatesh <ve...@innerzeal.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12987/#review24035
-----------------------------------------------------------
All the changes look good. You had to create dependencies to work around the pom.version. I do not understand the changes to filtering in super pom. You exclude in one and include in another. Can you please clarify what is going on?
- Seetharam Venkatesh
On July 27, 2013, 12:02 p.m., Srikanth Sundarrajan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12987/
> -----------------------------------------------------------
>
> (Updated July 27, 2013, 12:02 p.m.)
>
>
> Review request for Falcon.
>
>
> Bugs: FALCON-65
> https://issues.apache.org/jira/browse/FALCON-65
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> Properties load should fall back to classpath if not present in config.location
>
>
> Diffs
> -----
>
> common/src/main/java/org/apache/falcon/util/ApplicationProperties.java 3746729
> common/src/main/resources/startup.properties 4ff00d7
> common/src/test/java/org/apache/falcon/util/ApplicationPropertiesTest.java PRE-CREATION
> common/src/test/java/org/apache/falcon/util/StartupPropertiesTest.java 6b2ec06
> common/src/test/resources/classpath.properties PRE-CREATION
> pom.xml ca16762
> src/bin/falcon-start 9a68220
> webapp/pom.xml 6743527
>
> Diff: https://reviews.apache.org/r/12987/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Srikanth Sundarrajan
>
>