You are viewing a plain text version of this content. The canonical link for it is here.
Posted to c-dev@axis.apache.org by Valentin Kuznetsov <vk...@yahoo.com> on 2004/10/13 21:49:22 UTC
changes
Hi,
I'd like to add a few changes.
1) Remove hardcoded /usr/local/lib on UNIX platforms
and leave libaxis_xmlparser.so etc to be defined at
run time by LD_LIBRARY_PATH.
2) Add namespace around all enums. I found that Axis
conflicts with other software we use who also have
enum with CRITICAL, INFO, WARN keywords. If we'll wrap
those enum in axis into axis specific namespace all
existing and potential future problems will go away.
Any objections?
Valentin.
__________________________________
Do you Yahoo!?
Yahoo! Mail - You care about security. So do we.
http://promotions.yahoo.com/new_mail
Re: changes
Posted by Roshan Weerasuriya <ro...@opensource.lk>.
hi,
Agreed with Samisa.
Roshan
On Thu, 2004-10-14 at 07:52, Samisa Abeysinghe wrote:
> --- Valentin Kuznetsov <vk...@yahoo.com> wrote:
>
> > Hi,
> > I'd like to add a few changes.
> > 1) Remove hardcoded /usr/local/lib on UNIX platforms
> > and leave libaxis_xmlparser.so etc to be defined at
> > run time by LD_LIBRARY_PATH.
>
> I hope you mean values hard coded in src/common/AxisConfig.cpp.
> Actually these are not really hard coded valies, rather default values to be used, in case one has
> not specified parser/transport lib locations and client/server log locations.
> (It is not /usr/local/lib, rahter /usr/local/axiscpp_deploy/lib or /usr/local/axiscpp_deploy/log
> with /usr/local/axiscpp_deploy being the assumed default Axis C++ deployment folder)
>
> The parser, transport abstraction layers load the libs dynamically and thus the conf file should
> say what lib to load.
>
> However, I agree that, if we give only the lib name (instead of full path to lib) to dlopen() and
> have that lib on LD_LIBRATY_PATH that would work.
>
> Anyway with the current model too, the user have enough flexibility with axiscpp.conf, I guess.
> (as an exmple rather than copying libaxis_xercesc.so or libaxis_expat.so to libaxis_xmlparser.so
> whenever you wish to change the parser lib you can edit the axiscpp.conf and switch parsers - the
> same applies to the transport layer.)
>
>
> > 2) Add namespace around all enums. I found that Axis
> > conflicts with other software we use who also have
> > enum with CRITICAL, INFO, WARN keywords. If we'll wrap
> > those enum in axis into axis specific namespace all
> > existing and potential future problems will go away.
> >
>
> +1
>
> Samisa...
>
>
> > Any objections?
> > Valentin.
> >
> >
> >
> >
> >
> > __________________________________
> > Do you Yahoo!?
> > Yahoo! Mail - You care about security. So do we.
> > http://promotions.yahoo.com/new_mail
> >
>
>
>
>
> _______________________________
> Do you Yahoo!?
> Declare Yourself - Register online to vote today!
> http://vote.yahoo.com
>
Re: changes
Posted by Samisa Abeysinghe <sa...@yahoo.com>.
--- Valentin Kuznetsov <vk...@yahoo.com> wrote:
> Hi,
> I'd like to add a few changes.
> 1) Remove hardcoded /usr/local/lib on UNIX platforms
> and leave libaxis_xmlparser.so etc to be defined at
> run time by LD_LIBRARY_PATH.
I hope you mean values hard coded in src/common/AxisConfig.cpp.
Actually these are not really hard coded valies, rather default values to be used, in case one has
not specified parser/transport lib locations and client/server log locations.
(It is not /usr/local/lib, rahter /usr/local/axiscpp_deploy/lib or /usr/local/axiscpp_deploy/log
with /usr/local/axiscpp_deploy being the assumed default Axis C++ deployment folder)
The parser, transport abstraction layers load the libs dynamically and thus the conf file should
say what lib to load.
However, I agree that, if we give only the lib name (instead of full path to lib) to dlopen() and
have that lib on LD_LIBRATY_PATH that would work.
Anyway with the current model too, the user have enough flexibility with axiscpp.conf, I guess.
(as an exmple rather than copying libaxis_xercesc.so or libaxis_expat.so to libaxis_xmlparser.so
whenever you wish to change the parser lib you can edit the axiscpp.conf and switch parsers - the
same applies to the transport layer.)
> 2) Add namespace around all enums. I found that Axis
> conflicts with other software we use who also have
> enum with CRITICAL, INFO, WARN keywords. If we'll wrap
> those enum in axis into axis specific namespace all
> existing and potential future problems will go away.
>
+1
Samisa...
> Any objections?
> Valentin.
>
>
>
>
>
> __________________________________
> Do you Yahoo!?
> Yahoo! Mail - You care about security. So do we.
> http://promotions.yahoo.com/new_mail
>
_______________________________
Do you Yahoo!?
Declare Yourself - Register online to vote today!
http://vote.yahoo.com