[GitHub] [incubator-celeborn] RexXiong commented on a diff in pull request #1521: [CELEBORN-612][HELM] Tackle hostPath directory permission

["RexXiong (via GitHub)" <gi...@apache.org>]

RexXiong commented on code in PR #1521:
URL: https://github.com/apache/incubator-celeborn/pull/1521#discussion_r1210141620


##########
charts/celeborn/templates/worker-statefulset.yaml:
##########
@@ -71,6 +71,26 @@ spec:
       securityContext:
         {{- toYaml . | nindent 8 }}
       {{- end }}
+      initContainers:
+      {{- $dirs := .Values.volumes.worker }}
+      {{- if eq "hostPath" (index $dirs 0).type }}
+      - name: chown-celeborn-worker-volume
+        image: alpine:3.18
+        imagePullPolicy: {{ .Values.image.pullPolicy | default "IfNotPresent" }}
+        securityContext:
+          runAsUser: 0
+        command:
+        - chown
+        - {{ .Values.securityContext.runAsUser | default 10006 }}:{{ .Values.securityContext.runAsGroup | default 10006 }}
+        {{- range $dir := $dirs }}
+        - {{ $dir.path }}
+        {{- end}}
+        volumeMounts:

Review Comment:
   There is duplicate volumnMounts for celeborn-worker-vol-{{ index }} in main containers, can we remove that? Otherwise we may have consistency problem.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org