You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by Chris Brody <ch...@gmail.com> on 2018/07/23 21:12:30 UTC
[VOTE] cordova-ios 4.5.5 patch release
Please review and vote on this cordova-ios 4.5.5 patch release by
replying to this email (and keep discussion on the DISCUSS thread)
Release issue: https://issues.apache.org/jira/browse/CB-14217
The archive has been published to dist/dev:
https://dist.apache.org/repos/dist/dev/cordova/CB-14217/
The package was published from its corresponding git tag:
cordova-ios: 4.5.5 (0c2b24718a)
Note that you can test it out via:
cordova platform add https://github.com/apache/cordova-ios#4.5.5
Upon a successful vote I will upload the archive to dist/, publish it
to npm, and post the blog post.
Voting guidelines:
https://github.com/apache/cordova-coho/blob/master/docs/release-voting.md
Voting will go on for a minimum of 48 hours.
I vote +1:
* Verified that npm audit shows 0 vulnerabilities
* Ran coho audit-license-headers over the relevant repos
* Ran coho check-license to ensure all dependencies and
subdependencies have Apache-compatible licenses
* Ensured continuous build was green when repo was tagged
* Other tests listed in: https://github.com/apache/cordova-ios/pull/381
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
Re: [VOTE] cordova-ios 4.5.5 patch release
Posted by Chris Brody <ch...@gmail.com>.
The vote has now closed. The results are:
Positive Binding Votes: 3
- Jesse MacFadyen
- Shazron Abdullah
- Christopher J. Brody
Negative Binding Votes: 0
The vote has passed.
Thanks to Jesse and Shazron for the quick review!
On Thu, Jul 26, 2018 at 3:05 PM Jesse <pu...@gmail.com> wrote:
>
> +1
>
> - coho verify-archive
> - checkout tagged version, npm i, no vulns
> - ran npm test, one minor issue with a missing Simulator image
> - continuous build was green when repo was tagged
> - coho check-license
> - coho audit-license-headers
>
>
> @purplecabbage
> risingj.com
>
> On Thu, Jul 26, 2018 at 11:49 AM, Chris Brody <ch...@gmail.com> wrote:
>
> > Can I get one more review on this one?
> > On Tue, Jul 24, 2018 at 4:08 AM Shazron <sh...@gmail.com> wrote:
> > >
> > > I vote +1:
> > > - Could create a blank iOS project
> > > - Could run the iOS project in the simulator and device
> > > On Tue, Jul 24, 2018 at 5:12 AM Chris Brody <ch...@gmail.com>
> > wrote:
> > > >
> > > > Please review and vote on this cordova-ios 4.5.5 patch release by
> > > > replying to this email (and keep discussion on the DISCUSS thread)
> > > >
> > > > Release issue: https://issues.apache.org/jira/browse/CB-14217
> > > >
> > > > The archive has been published to dist/dev:
> > > > https://dist.apache.org/repos/dist/dev/cordova/CB-14217/
> > > >
> > > > The package was published from its corresponding git tag:
> > > >
> > > > cordova-ios: 4.5.5 (0c2b24718a)
> > > >
> > > > Note that you can test it out via:
> > > >
> > > > cordova platform add https://github.com/apache/cordova-ios#4.5.5
> > > >
> > > > Upon a successful vote I will upload the archive to dist/, publish it
> > > > to npm, and post the blog post.
> > > >
> > > > Voting guidelines:
> > > > https://github.com/apache/cordova-coho/blob/master/docs/
> > release-voting.md
> > > >
> > > > Voting will go on for a minimum of 48 hours.
> > > >
> > > > I vote +1:
> > > > * Verified that npm audit shows 0 vulnerabilities
> > > > * Ran coho audit-license-headers over the relevant repos
> > > > * Ran coho check-license to ensure all dependencies and
> > > > subdependencies have Apache-compatible licenses
> > > > * Ensured continuous build was green when repo was tagged
> > > > * Other tests listed in: https://github.com/apache/
> > cordova-ios/pull/381
> > > >
> > > > ---------------------------------------------------------------------
> > > > To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
> > > > For additional commands, e-mail: dev-help@cordova.apache.org
> > > >
> > >
> > > ---------------------------------------------------------------------
> > > To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
> > > For additional commands, e-mail: dev-help@cordova.apache.org
> > >
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
> > For additional commands, e-mail: dev-help@cordova.apache.org
> >
> >
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
Re: [VOTE] cordova-ios 4.5.5 patch release
Posted by Jesse <pu...@gmail.com>.
+1
- coho verify-archive
- checkout tagged version, npm i, no vulns
- ran npm test, one minor issue with a missing Simulator image
- continuous build was green when repo was tagged
- coho check-license
- coho audit-license-headers
@purplecabbage
risingj.com
On Thu, Jul 26, 2018 at 11:49 AM, Chris Brody <ch...@gmail.com> wrote:
> Can I get one more review on this one?
> On Tue, Jul 24, 2018 at 4:08 AM Shazron <sh...@gmail.com> wrote:
> >
> > I vote +1:
> > - Could create a blank iOS project
> > - Could run the iOS project in the simulator and device
> > On Tue, Jul 24, 2018 at 5:12 AM Chris Brody <ch...@gmail.com>
> wrote:
> > >
> > > Please review and vote on this cordova-ios 4.5.5 patch release by
> > > replying to this email (and keep discussion on the DISCUSS thread)
> > >
> > > Release issue: https://issues.apache.org/jira/browse/CB-14217
> > >
> > > The archive has been published to dist/dev:
> > > https://dist.apache.org/repos/dist/dev/cordova/CB-14217/
> > >
> > > The package was published from its corresponding git tag:
> > >
> > > cordova-ios: 4.5.5 (0c2b24718a)
> > >
> > > Note that you can test it out via:
> > >
> > > cordova platform add https://github.com/apache/cordova-ios#4.5.5
> > >
> > > Upon a successful vote I will upload the archive to dist/, publish it
> > > to npm, and post the blog post.
> > >
> > > Voting guidelines:
> > > https://github.com/apache/cordova-coho/blob/master/docs/
> release-voting.md
> > >
> > > Voting will go on for a minimum of 48 hours.
> > >
> > > I vote +1:
> > > * Verified that npm audit shows 0 vulnerabilities
> > > * Ran coho audit-license-headers over the relevant repos
> > > * Ran coho check-license to ensure all dependencies and
> > > subdependencies have Apache-compatible licenses
> > > * Ensured continuous build was green when repo was tagged
> > > * Other tests listed in: https://github.com/apache/
> cordova-ios/pull/381
> > >
> > > ---------------------------------------------------------------------
> > > To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
> > > For additional commands, e-mail: dev-help@cordova.apache.org
> > >
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
> > For additional commands, e-mail: dev-help@cordova.apache.org
> >
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
> For additional commands, e-mail: dev-help@cordova.apache.org
>
>
Re: [VOTE] cordova-ios 4.5.5 patch release
Posted by Chris Brody <ch...@gmail.com>.
Can I get one more review on this one?
On Tue, Jul 24, 2018 at 4:08 AM Shazron <sh...@gmail.com> wrote:
>
> I vote +1:
> - Could create a blank iOS project
> - Could run the iOS project in the simulator and device
> On Tue, Jul 24, 2018 at 5:12 AM Chris Brody <ch...@gmail.com> wrote:
> >
> > Please review and vote on this cordova-ios 4.5.5 patch release by
> > replying to this email (and keep discussion on the DISCUSS thread)
> >
> > Release issue: https://issues.apache.org/jira/browse/CB-14217
> >
> > The archive has been published to dist/dev:
> > https://dist.apache.org/repos/dist/dev/cordova/CB-14217/
> >
> > The package was published from its corresponding git tag:
> >
> > cordova-ios: 4.5.5 (0c2b24718a)
> >
> > Note that you can test it out via:
> >
> > cordova platform add https://github.com/apache/cordova-ios#4.5.5
> >
> > Upon a successful vote I will upload the archive to dist/, publish it
> > to npm, and post the blog post.
> >
> > Voting guidelines:
> > https://github.com/apache/cordova-coho/blob/master/docs/release-voting.md
> >
> > Voting will go on for a minimum of 48 hours.
> >
> > I vote +1:
> > * Verified that npm audit shows 0 vulnerabilities
> > * Ran coho audit-license-headers over the relevant repos
> > * Ran coho check-license to ensure all dependencies and
> > subdependencies have Apache-compatible licenses
> > * Ensured continuous build was green when repo was tagged
> > * Other tests listed in: https://github.com/apache/cordova-ios/pull/381
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
> > For additional commands, e-mail: dev-help@cordova.apache.org
> >
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
> For additional commands, e-mail: dev-help@cordova.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
Re: [VOTE] cordova-ios 4.5.5 patch release
Posted by Shazron <sh...@gmail.com>.
I vote +1:
- Could create a blank iOS project
- Could run the iOS project in the simulator and device
On Tue, Jul 24, 2018 at 5:12 AM Chris Brody <ch...@gmail.com> wrote:
>
> Please review and vote on this cordova-ios 4.5.5 patch release by
> replying to this email (and keep discussion on the DISCUSS thread)
>
> Release issue: https://issues.apache.org/jira/browse/CB-14217
>
> The archive has been published to dist/dev:
> https://dist.apache.org/repos/dist/dev/cordova/CB-14217/
>
> The package was published from its corresponding git tag:
>
> cordova-ios: 4.5.5 (0c2b24718a)
>
> Note that you can test it out via:
>
> cordova platform add https://github.com/apache/cordova-ios#4.5.5
>
> Upon a successful vote I will upload the archive to dist/, publish it
> to npm, and post the blog post.
>
> Voting guidelines:
> https://github.com/apache/cordova-coho/blob/master/docs/release-voting.md
>
> Voting will go on for a minimum of 48 hours.
>
> I vote +1:
> * Verified that npm audit shows 0 vulnerabilities
> * Ran coho audit-license-headers over the relevant repos
> * Ran coho check-license to ensure all dependencies and
> subdependencies have Apache-compatible licenses
> * Ensured continuous build was green when repo was tagged
> * Other tests listed in: https://github.com/apache/cordova-ios/pull/381
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
> For additional commands, e-mail: dev-help@cordova.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org