You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@kyuubi.apache.org by GitBox <gi...@apache.org> on 2022/02/28 14:21:41 UTC

[GitHub] [incubator-kyuubi] pan3793 commented on a change in pull request #1980: Fix race on some service during stop phase

pan3793 commented on a change in pull request #1980:
URL: https://github.com/apache/incubator-kyuubi/pull/1980#discussion_r815931734



##########
File path: kyuubi-common/src/main/scala/org/apache/kyuubi/service/TFrontendService.scala
##########
@@ -66,12 +66,12 @@ abstract class TFrontendService(name: String)
   protected def stopServer(): Unit
 
   override def stop(): Unit = synchronized {
+    super.stop()

Review comment:
       Generally, the order of `super.start()` and `super.stop()` should be symmetrical




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org