[GitHub] [lucene-solr] madrob commented on a change in pull request #1498: SOLR-14351: commitScheduler was missing MDC logging

[GitBox <gi...@apache.org>]

madrob commented on a change in pull request #1498:
URL: https://github.com/apache/lucene-solr/pull/1498#discussion_r422722209



##########
File path: solr/core/src/java/org/apache/solr/update/CommitTracker.java
##########
@@ -57,8 +58,10 @@
   private int docsUpperBound;
   private long timeUpperBound;
   private long tLogFileSizeUpperBound;
-  
-  private final ScheduledExecutorService scheduler = 
+
+  // note: can't use ExecutorsUtil because it doesn't have a *scheduled* ExecutorService.
+  //  Not a big deal but it means we must take care of MDC logging here.

Review comment:
       Is there an issue for improving ExecutorUtil for this?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org