You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/04/11 00:47:23 UTC

[GitHub] [airflow] jmcarp commented on a change in pull request #8145: Drop redundant project id null checks.

jmcarp commented on a change in pull request #8145: Drop redundant project id null checks.
URL: https://github.com/apache/airflow/pull/8145#discussion_r406995108
 
 

 ##########
 File path: airflow/providers/google/cloud/example_dags/example_automl_tables.py
 ##########
 @@ -139,7 +139,6 @@ def get_target_column_spec(columns_specs: List[Dict], column_name: str) -> str:
         task_id="update_dataset_task",
         dataset=update,
         location=GCP_AUTOML_LOCATION,
-        project_id=GCP_PROJECT_ID,
 
 Review comment:
   This parameter was unused in `CloudAutoMLHook.update_dataset`, so I dropped the parameter from that method, as well as `AutoMLTablesUpdateDatasetOperator` and the example code here.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services