[jira] [Commented] (CALCITE-2476) SqlAdvisor: lack of hints when sub-query has STAR (simplifySql produces 0 AS "*")

["Vladimir Sitnikov (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CALCITE-2476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16585192#comment-16585192 ] 

Vladimir Sitnikov commented on CALCITE-2476:
--------------------------------------------

PR 773 comments call to purgeSelectExprsKeepAliases

> SqlAdvisor: lack of hints when sub-query has STAR (simplifySql produces 0 AS "*")
> ---------------------------------------------------------------------------------
>
>                 Key: CALCITE-2476
>                 URL: https://issues.apache.org/jira/browse/CALCITE-2476
>             Project: Calcite
>          Issue Type: Bug
>          Components: core
>    Affects Versions: 1.17.0
>            Reporter: Vladimir Sitnikov
>            Assignee: Julian Hyde
>            Priority: Major
>
> {{SimpleSqlParser.purgeSelectExprsKeepAliases}} tries to replace expressions in {{select}} clause with aliases, and it often produces invalid SQL:
> {{select * from dummy}} is replaced with {{select 0 AS "*" from dummy}} which is invalid
> {{select a.x+ b.y from dummy}} is replaced with {{select 0 AS "b.y" from dummy}} and so on.
> Testcase:
> {code:sql}select ax^ from (select * from dummy a){code}
> Actual output:
> {code:sql}SELECT ax _suggest_ FROM ( SELECT 0 AS * FROM dummy a ){code}
> I'm inclined to comment {{purgeSelectExprsKeepAliases}} out for now.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)