You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@myfaces.apache.org by bo...@apache.org on 2008/01/12 11:53:52 UTC

svn commit: r611399 - /myfaces/tobago/trunk/theme/scarborough/src/main/java/org/apache/myfaces/tobago/renderkit/html/scarborough/standard/tag/TabGroupRenderer.java

Author: bommel
Date: Sat Jan 12 02:53:52 2008
New Revision: 611399

URL: http://svn.apache.org/viewvc?rev=611399&view=rev
Log:
(TOBAGO-176) prevent NPE when onclick is empty

Modified:
    myfaces/tobago/trunk/theme/scarborough/src/main/java/org/apache/myfaces/tobago/renderkit/html/scarborough/standard/tag/TabGroupRenderer.java

Modified: myfaces/tobago/trunk/theme/scarborough/src/main/java/org/apache/myfaces/tobago/renderkit/html/scarborough/standard/tag/TabGroupRenderer.java
URL: http://svn.apache.org/viewvc/myfaces/tobago/trunk/theme/scarborough/src/main/java/org/apache/myfaces/tobago/renderkit/html/scarborough/standard/tag/TabGroupRenderer.java?rev=611399&r1=611398&r2=611399&view=diff
==============================================================================
--- myfaces/tobago/trunk/theme/scarborough/src/main/java/org/apache/myfaces/tobago/renderkit/html/scarborough/standard/tag/TabGroupRenderer.java (original)
+++ myfaces/tobago/trunk/theme/scarborough/src/main/java/org/apache/myfaces/tobago/renderkit/html/scarborough/standard/tag/TabGroupRenderer.java Sat Jan 12 02:53:52 2008
@@ -356,7 +356,9 @@
           // tool bar
           UIMenuCommand menuItem = (UIMenuCommand) application.createComponent(UIMenuCommand.COMPONENT_TYPE);
           menuItem.setRendererType("MenuCommand");
-          menuItem.getAttributes().put(ATTR_ONCLICK, onclick);
+          if (onclick != null) {
+            menuItem.getAttributes().put(ATTR_ONCLICK, onclick);
+          }
           Object label2 = tab.getAttributes().get(ATTR_LABEL);
           if (label2 != null) {
             menuItem.getAttributes().put(ATTR_LABEL, label2);