You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "David Knupp (Code Review)" <ge...@cloudera.org> on 2020/04/27 22:55:00 UTC

[Impala-ASF-CR] Revert "IMPALA-9648: Exclude netty and netty-all from hadoop-hdfs mvn download"

David Knupp has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15825


Change subject: Revert "IMPALA-9648: Exclude netty and netty-all from hadoop-hdfs mvn download"
......................................................................

Revert "IMPALA-9648: Exclude netty and netty-all from hadoop-hdfs mvn download"

This patch was causing CI builds to fail in certain environments where
netty 3.10.5 was present.

This reverts commit 0eef60cc943518edbeffd84504574daeb11c812d.

Change-Id: Ic10ae25321988db2a92bb55b3063350000d9a6f9
---
M fe/pom.xml
1 file changed, 0 insertions(+), 38 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/25/15825/1
-- 
To view, visit http://gerrit.cloudera.org:8080/15825
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic10ae25321988db2a92bb55b3063350000d9a6f9
Gerrit-Change-Number: 15825
Gerrit-PatchSet: 1
Gerrit-Owner: David Knupp <dk...@cloudera.com>

[Impala-ASF-CR] Revert "IMPALA-9648: Exclude netty and netty-all from hadoop-hdfs mvn download"

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15825 )

Change subject: Revert "IMPALA-9648: Exclude netty and netty-all from hadoop-hdfs mvn download"
......................................................................


Patch Set 1:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/5893/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/15825
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic10ae25321988db2a92bb55b3063350000d9a6f9
Gerrit-Change-Number: 15825
Gerrit-PatchSet: 1
Gerrit-Owner: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Mon, 27 Apr 2020 23:15:41 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] Revert "IMPALA-9648: Exclude netty and netty-all from hadoop-hdfs mvn download"

Posted by "David Knupp (Code Review)" <ge...@cloudera.org>.
David Knupp has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15825 )

Change subject: Revert "IMPALA-9648: Exclude netty and netty-all from hadoop-hdfs mvn download"
......................................................................

Revert "IMPALA-9648: Exclude netty and netty-all from hadoop-hdfs mvn download"

This patch was causing CI builds to fail in certain environments where
netty 3.10.5 was present.

This reverts commit 0eef60cc943518edbeffd84504574daeb11c812d.

Change-Id: Ic10ae25321988db2a92bb55b3063350000d9a6f9
Reviewed-on: http://gerrit.cloudera.org:8080/15825
Reviewed-by: David Knupp <dk...@cloudera.com>
Tested-by: David Knupp <dk...@cloudera.com>
---
M fe/pom.xml
1 file changed, 0 insertions(+), 38 deletions(-)

Approvals:
  David Knupp: Looks good to me, approved; Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/15825
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic10ae25321988db2a92bb55b3063350000d9a6f9
Gerrit-Change-Number: 15825
Gerrit-PatchSet: 2
Gerrit-Owner: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>

[Impala-ASF-CR] Revert "IMPALA-9648: Exclude netty and netty-all from hadoop-hdfs mvn download"

Posted by "David Knupp (Code Review)" <ge...@cloudera.org>.
David Knupp has posted comments on this change. ( http://gerrit.cloudera.org:8080/15825 )

Change subject: Revert "IMPALA-9648: Exclude netty and netty-all from hadoop-hdfs mvn download"
......................................................................


Patch Set 1: Verified+1 Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/15825
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic10ae25321988db2a92bb55b3063350000d9a6f9
Gerrit-Change-Number: 15825
Gerrit-PatchSet: 1
Gerrit-Owner: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Comment-Date: Mon, 27 Apr 2020 22:55:19 +0000
Gerrit-HasComments: No