You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/02/21 08:21:50 UTC

[GitHub] [spark] lipzhu opened a new pull request #27663: [SPARK-30895]:The behavior of CsvToStructs should not depend on SQLConf.get

lipzhu opened a new pull request #27663: [SPARK-30895]:The behavior of CsvToStructs should not depend on SQLConf.get
URL: https://github.com/apache/spark/pull/27663
 
 
   ### What changes were proposed in this pull request?
   In the PR, I add the `nameOfCorruptRecord` parameter to the `CsvToStructs` expression.
   
   ### Why are the changes needed?
   This allows to avoid the issue when the configuration change between different phases of planning, and this can silently break a query plan which can lead to crashes or data corruption.
   
   ### Does this PR introduce any user-facing change?
   No
   
   ### How was this patch tested?
   By CsvExpressionsSuite.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on issue #27663: [SPARK-30895]:The behavior of CsvToStructs should not depend on SQLConf.get

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27663: [SPARK-30895]:The behavior of CsvToStructs should not depend on SQLConf.get
URL: https://github.com/apache/spark/pull/27663#issuecomment-591298882
 
 
   Test PASSed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/23706/
   Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on issue #27663: [SPARK-30895]:The behavior of CsvToStructs should not depend on SQLConf.get

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27663: [SPARK-30895]:The behavior of CsvToStructs should not depend on SQLConf.get
URL: https://github.com/apache/spark/pull/27663#issuecomment-590166171
 
 
   Merged build finished. Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA removed a comment on issue #27663: [SPARK-30895]:The behavior of CsvToStructs should not depend on SQLConf.get

Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #27663: [SPARK-30895]:The behavior of CsvToStructs should not depend on SQLConf.get
URL: https://github.com/apache/spark/pull/27663#issuecomment-593867288
 
 
   **[Test build #119223 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/119223/testReport)** for PR 27663 at commit [`b8b77ba`](https://github.com/apache/spark/commit/b8b77babe17edeefe4a66b867781d1f3c01e3960).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA removed a comment on issue #27663: [SPARK-30895]:The behavior of CsvToStructs should not depend on SQLConf.get

Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #27663: [SPARK-30895]:The behavior of CsvToStructs should not depend on SQLConf.get
URL: https://github.com/apache/spark/pull/27663#issuecomment-591298360
 
 
   **[Test build #118958 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118958/testReport)** for PR 27663 at commit [`f4150c5`](https://github.com/apache/spark/commit/f4150c5842b51d0016774445c56afa8d871189d8).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on issue #27663: [SPARK-30895]:The behavior of CsvToStructs should not depend on SQLConf.get

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27663: [SPARK-30895]:The behavior of CsvToStructs should not depend on SQLConf.get
URL: https://github.com/apache/spark/pull/27663#issuecomment-594004733
 
 
   Merged build finished. Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on issue #27663: [SPARK-30895]:The behavior of CsvToStructs should not depend on SQLConf.get

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27663: [SPARK-30895]:The behavior of CsvToStructs should not depend on SQLConf.get
URL: https://github.com/apache/spark/pull/27663#issuecomment-589587728
 
 
   Merged build finished. Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on issue #27663: [SPARK-30895]:The behavior of CsvToStructs should not depend on SQLConf.get

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27663: [SPARK-30895]:The behavior of CsvToStructs should not depend on SQLConf.get
URL: https://github.com/apache/spark/pull/27663#issuecomment-589587728
 
 
   Merged build finished. Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on issue #27663: [SPARK-30895]:The behavior of CsvToStructs should not depend on SQLConf.get

Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27663: [SPARK-30895]:The behavior of CsvToStructs should not depend on SQLConf.get
URL: https://github.com/apache/spark/pull/27663#issuecomment-591414200
 
 
   **[Test build #118958 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118958/testReport)** for PR 27663 at commit [`f4150c5`](https://github.com/apache/spark/commit/f4150c5842b51d0016774445c56afa8d871189d8).
    * This patch **fails PySpark unit tests**.
    * This patch merges cleanly.
    * This patch adds no public classes.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on issue #27663: [SPARK-30895]:The behavior of CsvToStructs should not depend on SQLConf.get

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27663: [SPARK-30895]:The behavior of CsvToStructs should not depend on SQLConf.get
URL: https://github.com/apache/spark/pull/27663#issuecomment-589550735
 
 
   Can one of the admins verify this patch?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] HyukjinKwon commented on a change in pull request #27663: [SPARK-30895]:The behavior of CsvToStructs should not depend on SQLConf.get

Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on a change in pull request #27663: [SPARK-30895]:The behavior of CsvToStructs should not depend on SQLConf.get
URL: https://github.com/apache/spark/pull/27663#discussion_r382497227
 
 

 ##########
 File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/csvExpressions.scala
 ##########
 @@ -136,6 +139,21 @@ case class CsvToStructs(
   override def prettyName: String = "from_csv"
 }
 
+object CsvToStructs{
+  def apply(
 
 Review comment:
   @lipzhu Please run the linter `./dev/lint-scala` and fix the style.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on issue #27663: [SPARK-30895]:The behavior of CsvToStructs should not depend on SQLConf.get

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27663: [SPARK-30895]:The behavior of CsvToStructs should not depend on SQLConf.get
URL: https://github.com/apache/spark/pull/27663#issuecomment-590166173
 
 
   Test PASSed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/23593/
   Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on issue #27663: [SPARK-30895]:The behavior of CsvToStructs should not depend on SQLConf.get

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27663: [SPARK-30895]:The behavior of CsvToStructs should not depend on SQLConf.get
URL: https://github.com/apache/spark/pull/27663#issuecomment-589710440
 
 
   Test PASSed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/118780/
   Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on issue #27663: [SPARK-30895]:The behavior of CsvToStructs should not depend on SQLConf.get

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27663: [SPARK-30895]:The behavior of CsvToStructs should not depend on SQLConf.get
URL: https://github.com/apache/spark/pull/27663#issuecomment-589710425
 
 
   Merged build finished. Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on issue #27663: [SPARK-30895]:The behavior of CsvToStructs should not depend on SQLConf.get

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27663: [SPARK-30895]:The behavior of CsvToStructs should not depend on SQLConf.get
URL: https://github.com/apache/spark/pull/27663#issuecomment-590204654
 
 
   Merged build finished. Test FAILed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on issue #27663: [SPARK-30895]:The behavior of CsvToStructs should not depend on SQLConf.get

Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27663: [SPARK-30895]:The behavior of CsvToStructs should not depend on SQLConf.get
URL: https://github.com/apache/spark/pull/27663#issuecomment-594003290
 
 
   **[Test build #119223 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/119223/testReport)** for PR 27663 at commit [`b8b77ba`](https://github.com/apache/spark/commit/b8b77babe17edeefe4a66b867781d1f3c01e3960).
    * This patch passes all tests.
    * This patch merges cleanly.
    * This patch adds no public classes.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA removed a comment on issue #27663: [SPARK-30895]:The behavior of CsvToStructs should not depend on SQLConf.get

Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #27663: [SPARK-30895]:The behavior of CsvToStructs should not depend on SQLConf.get
URL: https://github.com/apache/spark/pull/27663#issuecomment-591469224
 
 
   **[Test build #118976 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118976/testReport)** for PR 27663 at commit [`677c265`](https://github.com/apache/spark/commit/677c265d6f0ce2422ca7d499422c0d58b4fa1c42).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on issue #27663: [SPARK-30895]:The behavior of CsvToStructs should not depend on SQLConf.get

Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27663: [SPARK-30895]:The behavior of CsvToStructs should not depend on SQLConf.get
URL: https://github.com/apache/spark/pull/27663#issuecomment-589709392
 
 
   **[Test build #118780 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118780/testReport)** for PR 27663 at commit [`17ce9b9`](https://github.com/apache/spark/commit/17ce9b91d38de5b86095784aa8aee4fe3b1ba200).
    * This patch passes all tests.
    * This patch merges cleanly.
    * This patch adds no public classes.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on issue #27663: [SPARK-30895]:The behavior of CsvToStructs should not depend on SQLConf.get

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27663: [SPARK-30895]:The behavior of CsvToStructs should not depend on SQLConf.get
URL: https://github.com/apache/spark/pull/27663#issuecomment-590166173
 
 
   Test PASSed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/23593/
   Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on issue #27663: [SPARK-30895]:The behavior of CsvToStructs should not depend on SQLConf.get

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27663: [SPARK-30895]:The behavior of CsvToStructs should not depend on SQLConf.get
URL: https://github.com/apache/spark/pull/27663#issuecomment-589550735
 
 
   Can one of the admins verify this patch?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on issue #27663: [SPARK-30895]:The behavior of CsvToStructs should not depend on SQLConf.get

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27663: [SPARK-30895]:The behavior of CsvToStructs should not depend on SQLConf.get
URL: https://github.com/apache/spark/pull/27663#issuecomment-594004744
 
 
   Test PASSed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/119223/
   Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA removed a comment on issue #27663: [SPARK-30895]:The behavior of CsvToStructs should not depend on SQLConf.get

Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #27663: [SPARK-30895]:The behavior of CsvToStructs should not depend on SQLConf.get
URL: https://github.com/apache/spark/pull/27663#issuecomment-589587255
 
 
   **[Test build #118780 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118780/testReport)** for PR 27663 at commit [`17ce9b9`](https://github.com/apache/spark/commit/17ce9b91d38de5b86095784aa8aee4fe3b1ba200).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on issue #27663: [SPARK-30895]:The behavior of CsvToStructs should not depend on SQLConf.get

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27663: [SPARK-30895]:The behavior of CsvToStructs should not depend on SQLConf.get
URL: https://github.com/apache/spark/pull/27663#issuecomment-590204654
 
 
   Merged build finished. Test FAILed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on issue #27663: [SPARK-30895]:The behavior of CsvToStructs should not depend on SQLConf.get

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27663: [SPARK-30895]:The behavior of CsvToStructs should not depend on SQLConf.get
URL: https://github.com/apache/spark/pull/27663#issuecomment-591298875
 
 
   Merged build finished. Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on issue #27663: [SPARK-30895]:The behavior of CsvToStructs should not depend on SQLConf.get

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27663: [SPARK-30895]:The behavior of CsvToStructs should not depend on SQLConf.get
URL: https://github.com/apache/spark/pull/27663#issuecomment-591470064
 
 
   Test PASSed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/23724/
   Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on issue #27663: [SPARK-30895]:The behavior of CsvToStructs should not depend on SQLConf.get

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27663: [SPARK-30895]:The behavior of CsvToStructs should not depend on SQLConf.get
URL: https://github.com/apache/spark/pull/27663#issuecomment-591415755
 
 
   Merged build finished. Test FAILed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] HyukjinKwon closed pull request #27663: [SPARK-30895]:The behavior of CsvToStructs should not depend on SQLConf.get

Posted by GitBox <gi...@apache.org>.
HyukjinKwon closed pull request #27663: [SPARK-30895]:The behavior of CsvToStructs should not depend on SQLConf.get
URL: https://github.com/apache/spark/pull/27663
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] HyukjinKwon commented on a change in pull request #27663: [SPARK-30895]:The behavior of CsvToStructs should not depend on SQLConf.get

Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on a change in pull request #27663: [SPARK-30895]:The behavior of CsvToStructs should not depend on SQLConf.get
URL: https://github.com/apache/spark/pull/27663#discussion_r383129253
 
 

 ##########
 File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/csvExpressions.scala
 ##########
 @@ -136,6 +139,21 @@ case class CsvToStructs(
   override def prettyName: String = "from_csv"
 }
 
+object CsvToStructs{
+  def apply(
 
 Review comment:
   @lipzhu, can you also check the style guide at https://github.com/databricks/scala-style-guide?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on issue #27663: [SPARK-30895]:The behavior of CsvToStructs should not depend on SQLConf.get

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27663: [SPARK-30895]:The behavior of CsvToStructs should not depend on SQLConf.get
URL: https://github.com/apache/spark/pull/27663#issuecomment-593867815
 
 
   Merged build finished. Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on issue #27663: [SPARK-30895]:The behavior of CsvToStructs should not depend on SQLConf.get

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27663: [SPARK-30895]:The behavior of CsvToStructs should not depend on SQLConf.get
URL: https://github.com/apache/spark/pull/27663#issuecomment-593867827
 
 
   Test PASSed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/23962/
   Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on issue #27663: [SPARK-30895]:The behavior of CsvToStructs should not depend on SQLConf.get

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27663: [SPARK-30895]:The behavior of CsvToStructs should not depend on SQLConf.get
URL: https://github.com/apache/spark/pull/27663#issuecomment-594004733
 
 
   Merged build finished. Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on issue #27663: [SPARK-30895]:The behavior of CsvToStructs should not depend on SQLConf.get

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27663: [SPARK-30895]:The behavior of CsvToStructs should not depend on SQLConf.get
URL: https://github.com/apache/spark/pull/27663#issuecomment-593867815
 
 
   Merged build finished. Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on issue #27663: [SPARK-30895]:The behavior of CsvToStructs should not depend on SQLConf.get

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27663: [SPARK-30895]:The behavior of CsvToStructs should not depend on SQLConf.get
URL: https://github.com/apache/spark/pull/27663#issuecomment-589710425
 
 
   Merged build finished. Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on issue #27663: [SPARK-30895]:The behavior of CsvToStructs should not depend on SQLConf.get

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27663: [SPARK-30895]:The behavior of CsvToStructs should not depend on SQLConf.get
URL: https://github.com/apache/spark/pull/27663#issuecomment-589587744
 
 
   Test PASSed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/23532/
   Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on issue #27663: [SPARK-30895]:The behavior of CsvToStructs should not depend on SQLConf.get

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27663: [SPARK-30895]:The behavior of CsvToStructs should not depend on SQLConf.get
URL: https://github.com/apache/spark/pull/27663#issuecomment-589550257
 
 
   Can one of the admins verify this patch?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on issue #27663: [SPARK-30895]:The behavior of CsvToStructs should not depend on SQLConf.get

Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27663: [SPARK-30895]:The behavior of CsvToStructs should not depend on SQLConf.get
URL: https://github.com/apache/spark/pull/27663#issuecomment-590204450
 
 
   **[Test build #118845 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118845/testReport)** for PR 27663 at commit [`b40cbc5`](https://github.com/apache/spark/commit/b40cbc57ba37bc30d1474c5e70d01cd312d43136).
    * This patch **fails due to an unknown error code, -9**.
    * This patch merges cleanly.
    * This patch adds no public classes.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on issue #27663: [SPARK-30895]:The behavior of CsvToStructs should not depend on SQLConf.get

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27663: [SPARK-30895]:The behavior of CsvToStructs should not depend on SQLConf.get
URL: https://github.com/apache/spark/pull/27663#issuecomment-591470049
 
 
   Merged build finished. Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on issue #27663: [SPARK-30895]:The behavior of CsvToStructs should not depend on SQLConf.get

Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27663: [SPARK-30895]:The behavior of CsvToStructs should not depend on SQLConf.get
URL: https://github.com/apache/spark/pull/27663#issuecomment-589587255
 
 
   **[Test build #118780 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118780/testReport)** for PR 27663 at commit [`17ce9b9`](https://github.com/apache/spark/commit/17ce9b91d38de5b86095784aa8aee4fe3b1ba200).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on issue #27663: [SPARK-30895]:The behavior of CsvToStructs should not depend on SQLConf.get

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27663: [SPARK-30895]:The behavior of CsvToStructs should not depend on SQLConf.get
URL: https://github.com/apache/spark/pull/27663#issuecomment-589550257
 
 
   Can one of the admins verify this patch?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on issue #27663: [SPARK-30895]:The behavior of CsvToStructs should not depend on SQLConf.get

Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27663: [SPARK-30895]:The behavior of CsvToStructs should not depend on SQLConf.get
URL: https://github.com/apache/spark/pull/27663#issuecomment-591469224
 
 
   **[Test build #118976 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118976/testReport)** for PR 27663 at commit [`677c265`](https://github.com/apache/spark/commit/677c265d6f0ce2422ca7d499422c0d58b4fa1c42).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA removed a comment on issue #27663: [SPARK-30895]:The behavior of CsvToStructs should not depend on SQLConf.get

Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #27663: [SPARK-30895]:The behavior of CsvToStructs should not depend on SQLConf.get
URL: https://github.com/apache/spark/pull/27663#issuecomment-590165965
 
 
   **[Test build #118845 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118845/testReport)** for PR 27663 at commit [`b40cbc5`](https://github.com/apache/spark/commit/b40cbc57ba37bc30d1474c5e70d01cd312d43136).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on issue #27663: [SPARK-30895]:The behavior of CsvToStructs should not depend on SQLConf.get

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27663: [SPARK-30895]:The behavior of CsvToStructs should not depend on SQLConf.get
URL: https://github.com/apache/spark/pull/27663#issuecomment-591470064
 
 
   Test PASSed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/23724/
   Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] HyukjinKwon commented on issue #27663: [SPARK-30895]:The behavior of CsvToStructs should not depend on SQLConf.get

Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on issue #27663: [SPARK-30895]:The behavior of CsvToStructs should not depend on SQLConf.get
URL: https://github.com/apache/spark/pull/27663#issuecomment-589586328
 
 
   ok to test

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on issue #27663: [SPARK-30895]:The behavior of CsvToStructs should not depend on SQLConf.get

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27663: [SPARK-30895]:The behavior of CsvToStructs should not depend on SQLConf.get
URL: https://github.com/apache/spark/pull/27663#issuecomment-591415755
 
 
   Merged build finished. Test FAILed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on issue #27663: [SPARK-30895]:The behavior of CsvToStructs should not depend on SQLConf.get

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27663: [SPARK-30895]:The behavior of CsvToStructs should not depend on SQLConf.get
URL: https://github.com/apache/spark/pull/27663#issuecomment-591592916
 
 
   Merged build finished. Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on issue #27663: [SPARK-30895]:The behavior of CsvToStructs should not depend on SQLConf.get

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27663: [SPARK-30895]:The behavior of CsvToStructs should not depend on SQLConf.get
URL: https://github.com/apache/spark/pull/27663#issuecomment-591592916
 
 
   Merged build finished. Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on issue #27663: [SPARK-30895]:The behavior of CsvToStructs should not depend on SQLConf.get

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27663: [SPARK-30895]:The behavior of CsvToStructs should not depend on SQLConf.get
URL: https://github.com/apache/spark/pull/27663#issuecomment-593867827
 
 
   Test PASSed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/23962/
   Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on issue #27663: [SPARK-30895]:The behavior of CsvToStructs should not depend on SQLConf.get

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27663: [SPARK-30895]:The behavior of CsvToStructs should not depend on SQLConf.get
URL: https://github.com/apache/spark/pull/27663#issuecomment-591470049
 
 
   Merged build finished. Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] MaxGekk commented on a change in pull request #27663: [SPARK-30895]:The behavior of CsvToStructs should not depend on SQLConf.get

Posted by GitBox <gi...@apache.org>.
MaxGekk commented on a change in pull request #27663: [SPARK-30895]:The behavior of CsvToStructs should not depend on SQLConf.get
URL: https://github.com/apache/spark/pull/27663#discussion_r386562324
 
 

 ##########
 File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/csvExpressions.scala
 ##########
 @@ -93,8 +98,6 @@ case class CsvToStructs(
     }
   }
 
-  val nameOfCorruptRecord = SQLConf.get.getConf(SQLConf.COLUMN_NAME_OF_CORRUPT_RECORD)
 
 Review comment:
   Reading of the config can be moved into `parser` initialization. In that case, it will not influence on planning.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on issue #27663: [SPARK-30895]:The behavior of CsvToStructs should not depend on SQLConf.get

Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27663: [SPARK-30895]:The behavior of CsvToStructs should not depend on SQLConf.get
URL: https://github.com/apache/spark/pull/27663#issuecomment-593867288
 
 
   **[Test build #119223 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/119223/testReport)** for PR 27663 at commit [`b8b77ba`](https://github.com/apache/spark/commit/b8b77babe17edeefe4a66b867781d1f3c01e3960).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on issue #27663: [SPARK-30895]:The behavior of CsvToStructs should not depend on SQLConf.get

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27663: [SPARK-30895]:The behavior of CsvToStructs should not depend on SQLConf.get
URL: https://github.com/apache/spark/pull/27663#issuecomment-589710440
 
 
   Test PASSed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/118780/
   Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on issue #27663: [SPARK-30895]:The behavior of CsvToStructs should not depend on SQLConf.get

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27663: [SPARK-30895]:The behavior of CsvToStructs should not depend on SQLConf.get
URL: https://github.com/apache/spark/pull/27663#issuecomment-591415765
 
 
   Test FAILed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/118958/
   Test FAILed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on issue #27663: [SPARK-30895]:The behavior of CsvToStructs should not depend on SQLConf.get

Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27663: [SPARK-30895]:The behavior of CsvToStructs should not depend on SQLConf.get
URL: https://github.com/apache/spark/pull/27663#issuecomment-591592075
 
 
   **[Test build #118976 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118976/testReport)** for PR 27663 at commit [`677c265`](https://github.com/apache/spark/commit/677c265d6f0ce2422ca7d499422c0d58b4fa1c42).
    * This patch passes all tests.
    * This patch merges cleanly.
    * This patch adds no public classes.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on issue #27663: [SPARK-30895]:The behavior of CsvToStructs should not depend on SQLConf.get

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27663: [SPARK-30895]:The behavior of CsvToStructs should not depend on SQLConf.get
URL: https://github.com/apache/spark/pull/27663#issuecomment-590166171
 
 
   Merged build finished. Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on issue #27663: [SPARK-30895]:The behavior of CsvToStructs should not depend on SQLConf.get

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27663: [SPARK-30895]:The behavior of CsvToStructs should not depend on SQLConf.get
URL: https://github.com/apache/spark/pull/27663#issuecomment-591298882
 
 
   Test PASSed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/23706/
   Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on issue #27663: [SPARK-30895]:The behavior of CsvToStructs should not depend on SQLConf.get

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27663: [SPARK-30895]:The behavior of CsvToStructs should not depend on SQLConf.get
URL: https://github.com/apache/spark/pull/27663#issuecomment-589587744
 
 
   Test PASSed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/23532/
   Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on issue #27663: [SPARK-30895]:The behavior of CsvToStructs should not depend on SQLConf.get

Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27663: [SPARK-30895]:The behavior of CsvToStructs should not depend on SQLConf.get
URL: https://github.com/apache/spark/pull/27663#issuecomment-590165965
 
 
   **[Test build #118845 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118845/testReport)** for PR 27663 at commit [`b40cbc5`](https://github.com/apache/spark/commit/b40cbc57ba37bc30d1474c5e70d01cd312d43136).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on issue #27663: [SPARK-30895]:The behavior of CsvToStructs should not depend on SQLConf.get

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27663: [SPARK-30895]:The behavior of CsvToStructs should not depend on SQLConf.get
URL: https://github.com/apache/spark/pull/27663#issuecomment-594004744
 
 
   Test PASSed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/119223/
   Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on issue #27663: [SPARK-30895]:The behavior of CsvToStructs should not depend on SQLConf.get

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27663: [SPARK-30895]:The behavior of CsvToStructs should not depend on SQLConf.get
URL: https://github.com/apache/spark/pull/27663#issuecomment-590204659
 
 
   Test FAILed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/118845/
   Test FAILed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] HyukjinKwon commented on issue #27663: [SPARK-30895]:The behavior of CsvToStructs should not depend on SQLConf.get

Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on issue #27663: [SPARK-30895]:The behavior of CsvToStructs should not depend on SQLConf.get
URL: https://github.com/apache/spark/pull/27663#issuecomment-589586357
 
 
   cc @MaxGekk 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] HyukjinKwon commented on issue #27663: [SPARK-30895]:The behavior of CsvToStructs should not depend on SQLConf.get

Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on issue #27663: [SPARK-30895]:The behavior of CsvToStructs should not depend on SQLConf.get
URL: https://github.com/apache/spark/pull/27663#issuecomment-597459066
 
 
   Closing this per the discussion in the JIRA

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on issue #27663: [SPARK-30895]:The behavior of CsvToStructs should not depend on SQLConf.get

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27663: [SPARK-30895]:The behavior of CsvToStructs should not depend on SQLConf.get
URL: https://github.com/apache/spark/pull/27663#issuecomment-590204659
 
 
   Test FAILed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/118845/
   Test FAILed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on issue #27663: [SPARK-30895]:The behavior of CsvToStructs should not depend on SQLConf.get

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27663: [SPARK-30895]:The behavior of CsvToStructs should not depend on SQLConf.get
URL: https://github.com/apache/spark/pull/27663#issuecomment-591592925
 
 
   Test PASSed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/118976/
   Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on issue #27663: [SPARK-30895]:The behavior of CsvToStructs should not depend on SQLConf.get

Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27663: [SPARK-30895]:The behavior of CsvToStructs should not depend on SQLConf.get
URL: https://github.com/apache/spark/pull/27663#issuecomment-591298360
 
 
   **[Test build #118958 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118958/testReport)** for PR 27663 at commit [`f4150c5`](https://github.com/apache/spark/commit/f4150c5842b51d0016774445c56afa8d871189d8).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on issue #27663: [SPARK-30895]:The behavior of CsvToStructs should not depend on SQLConf.get

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27663: [SPARK-30895]:The behavior of CsvToStructs should not depend on SQLConf.get
URL: https://github.com/apache/spark/pull/27663#issuecomment-591592925
 
 
   Test PASSed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/118976/
   Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on issue #27663: [SPARK-30895]:The behavior of CsvToStructs should not depend on SQLConf.get

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27663: [SPARK-30895]:The behavior of CsvToStructs should not depend on SQLConf.get
URL: https://github.com/apache/spark/pull/27663#issuecomment-591415765
 
 
   Test FAILed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/118958/
   Test FAILed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on issue #27663: [SPARK-30895]:The behavior of CsvToStructs should not depend on SQLConf.get

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27663: [SPARK-30895]:The behavior of CsvToStructs should not depend on SQLConf.get
URL: https://github.com/apache/spark/pull/27663#issuecomment-591298875
 
 
   Merged build finished. Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org