[GitHub] [iceberg] rdblue commented on a diff in pull request #4898: Core: Add schema_id to ContentFile/ManifestFile

[GitBox <gi...@apache.org>]

rdblue commented on code in PR #4898:
URL: https://github.com/apache/iceberg/pull/4898#discussion_r884936249


##########
api/src/main/java/org/apache/iceberg/ContentFile.java:
##########
@@ -39,6 +39,13 @@
    */
   int specId();
 
+  /**
+   * Return id of the schema when write this file.
+   */
+  default int schemaId() {
+    return -1;

Review Comment:
   Instead of returning an incorrect value, I think this should throw an exception.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org