You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@commons.apache.org by lu...@free.fr on 2010/11/03 15:24:23 UTC
Re: svn commit: r1030464 [1/3] - in /commons/proper/math/trunk/src:
main/java/org/apache/commons/math/
main/java/org/apache/commons/math/analysis/
main/java/org/apache/commons/math/analysis/integration/
main/java/org/apache/commons/math/analysis/interpolat...
----- erans@apache.org a écrit :
> Author: erans
> Date: Wed Nov 3 13:46:04 2010
> New Revision: 1030464
>
> URL: http://svn.apache.org/viewvc?rev=1030464&view=rev
> Log:
> MATH-195
> Created an unchecked "FunctionEvaluationException" in package
> "exception".
> Removed "throws" clause from interface "UnivariateRealFunction".
> "PolynomialFunctionLagrangeForm": Added early check on the
> interpolating
> array having distinct points; removed redundant test in methods
> "evaluate"
> and "computeCoefficients".
> "DividedDifferenceInerpolator": Removed redundant check.
> "Mathutils": Added method "sortInPlace". Removed (most) references to
> the
> deprecated "MathRuntimeException" class.
> "optimization.direct": Removed deprecated classes.
> Javadoc clean up.
Some of theses changes should have been on separate commits. It helps tracking changes back to issues and other developers updating their working copy on purpose.
Luc
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: svn commit: r1030464 [1/3] - in /commons/proper/math/trunk/src:
main/java/org/apache/commons/math/ main/java/org/apache/commons/math/analysis/
main/java/org/apache/commons/math/analysis/integration/ main/java/org/apache/commons/math/analysis/interpolat...
Posted by Phil Steitz <ph...@gmail.com>.
On 11/3/10 12:01 PM, Gilles Sadowski wrote:
>>> URL: http://svn.apache.org/viewvc?rev=1030464&view=rev
>>> Log:
>>> MATH-195
>>> Created an unchecked "FunctionEvaluationException" in package
>>> "exception".
>>> Removed "throws" clause from interface "UnivariateRealFunction".
>>> "PolynomialFunctionLagrangeForm": Added early check on the
>>> interpolating
>>> array having distinct points; removed redundant test in methods
>>> "evaluate"
>>> and "computeCoefficients".
>>> "DividedDifferenceInerpolator": Removed redundant check.
>>> "Mathutils": Added method "sortInPlace". Removed (most) references to
>>> the
>>> deprecated "MathRuntimeException" class.
>>> "optimization.direct": Removed deprecated classes.
>>> Javadoc clean up.
>>
>> Some of theses changes should have been on separate commits. [...]
>
> This *might* be true, but not necessarily so; some changes/additions (e.g.
> "sortInPlace" were cascaded from a previous modification, and were necessary
> to allow compilation and/or tests to pass. Please trust me that I try to
> change things by small bits. One cannot always easily foresee all the
> implications of a modification, and it's simply not worth the time it
> would take.
I disagree. We need to separate and fully document our commits.
Whatever client-side tooling we want to use, the requirement is
individually documented atomic commits. Large commits should be few
and far between. Large refactorings and changes to exception
processing like what you are doing now in the 3.0 branch will
necessarily lead to some large commits. Especially in these cases,
however, we want to carefully avoid introducing other changes that
may be overlooked by reviewers and/or people later on trying to
figure out how changes were made (the two main reasons that we favor
smaller, individually documented commits).
Phil
> Also I'm not going to "svn co" a fresh copy of CM every time I
> encounter an issue that should have been better dealt with *before* the
> changes I'm currently performing (I already have two active ones).
>
> All of the above commit is related to issue MATH-195 (the aim of which is
> that all CM's exceptions should be in package "exception" and unchecked).
> "sortInPlace" was added here because it made it possible not to change
> something else (namely, allowing unsorted arrays).
>
>
> Gilles
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: svn commit: r1030464 [1/3] - in
/commons/proper/math/trunk/src: main/java/org/apache/commons/math/
main/java/org/apache/commons/math/analysis/
main/java/org/apache/commons/math/analysis/integration/
main/java/org/apache/commons/math/analysis/interpolat...
Posted by Gilles Sadowski <gi...@harfang.homelinux.org>.
> > URL: http://svn.apache.org/viewvc?rev=1030464&view=rev
> > Log:
> > MATH-195
> > Created an unchecked "FunctionEvaluationException" in package
> > "exception".
> > Removed "throws" clause from interface "UnivariateRealFunction".
> > "PolynomialFunctionLagrangeForm": Added early check on the
> > interpolating
> > array having distinct points; removed redundant test in methods
> > "evaluate"
> > and "computeCoefficients".
> > "DividedDifferenceInerpolator": Removed redundant check.
> > "Mathutils": Added method "sortInPlace". Removed (most) references to
> > the
> > deprecated "MathRuntimeException" class.
> > "optimization.direct": Removed deprecated classes.
> > Javadoc clean up.
>
> Some of theses changes should have been on separate commits. [...]
This *might* be true, but not necessarily so; some changes/additions (e.g.
"sortInPlace" were cascaded from a previous modification, and were necessary
to allow compilation and/or tests to pass. Please trust me that I try to
change things by small bits. One cannot always easily foresee all the
implications of a modification, and it's simply not worth the time it
would take.
Also I'm not going to "svn co" a fresh copy of CM every time I
encounter an issue that should have been better dealt with *before* the
changes I'm currently performing (I already have two active ones).
All of the above commit is related to issue MATH-195 (the aim of which is
that all CM's exceptions should be in package "exception" and unchecked).
"sortInPlace" was added here because it made it possible not to change
something else (namely, allowing unsorted arrays).
Gilles
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org