You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@airavata.apache.org by hasinitg <gi...@git.apache.org> on 2015/06/11 13:10:54 UTC

[GitHub] airavata pull request: Fix for the script: generate-thrift-file.sh...

GitHub user hasinitg opened a pull request:

    https://github.com/apache/airavata/pull/16

    Fix for the script: generate-thrift-file.sh 

    I got an error when running the generate-thrift-file.sh due to the file paths that do not match the new source structure. It is fixed herewith and it worked for me after this fix.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/hasinitg/airavata sprint2

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/airavata/pull/16.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #16
    
----
commit ce0a9be271a4fca2d3fecbd2dfa7459dba935290
Author: Hasini Gunasinghe <ha...@gmail.com>
Date:   2015-06-02T15:23:45Z

    fixing a build issue.

commit 84eb4d78813368864f3f79429a65a90359ceec3e
Author: hasinitg <ha...@gmail.com>
Date:   2015-06-10T07:51:17Z

    Merge branch 'sprint1_update2' into sprint2

commit 09e3a93e3c3f3e2cf7adcb881b528f1aeb15ef32
Author: hasinitg <ha...@gmail.com>
Date:   2015-06-11T10:49:11Z

    fixing the generate-thrift-files.sh script to align with new refactorings.

commit e2f332b205b5b7fbae59a6c25463badb6bad3f23
Author: hasinitg <ha...@gmail.com>
Date:   2015-06-11T11:03:26Z

    reverting the change to pom.xml

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] airavata pull request: Fix for the script: generate-thrift-file.sh...

Posted by smarru <gi...@git.apache.org>.
Github user smarru commented on the pull request:

    https://github.com/apache/airavata/pull/16#issuecomment-111090130
  
    Hi Hasini, I have fixed the thrift script and also have updating all the generated files to thrift 0.9.2. Can you please hold onto to this PR until I commit these changes this morning. It will be great if you can take a PR after the thrift changes. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] airavata pull request #16: Fix for the script: generate-thrift-file.sh

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/airavata/pull/16


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] airavata pull request: Fix for the script: generate-thrift-file.sh...

Posted by hasinitg <gi...@git.apache.org>.
Github user hasinitg commented on the pull request:

    https://github.com/apache/airavata/pull/16#issuecomment-111093401
  
    Hi Suresh, please discard this if you have fixed the issue. Sure, I will update my copy of the source after your changes and before making the next PR.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---