[GitHub] [spark] sander-goos commented on pull request #43035: [SPARK-45256][SQL] DurationWriter fails when writing more values than initial capacity

["sander-goos (via GitHub)" <gi...@apache.org>]

sander-goos commented on PR #43035:
URL: https://github.com/apache/spark/pull/43035#issuecomment-1731360942

   > +1, this PR looks reasonable (Pending CIs). There is no perf regression for the case which fits the limit, right, @sander-goos ?
   
   There shouldn't be a perf regression; the extra call to `handleSafe` is a no-op when index < capacity. The Arrow writers for other types also `setSafe` where applicable.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org