You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "messere1 (via GitHub)" <gi...@apache.org> on 2026/08/11 06:26:58 UTC
[PR] [studio][ISSUE #1636] Preserve concurrent NameServer additions [rocketmq-dashboard]
messere1 opened a new pull request, #1638:
URL: https://github.com/apache/rocketmq-dashboard/pull/1638
## Summary
- append saved NameServer addresses with a functional state update
- deduplicate against the latest address list instead of a request-time snapshot
- clear the address input only when it still belongs to the completed request
- cover out-of-order concurrent additions and newer input with a regression test
## Root cause and impact
The asynchronous add handler spread `namesrvAddrList` captured before the request. Two overlapping successful additions therefore wrote independent copies of the same old list, and the last completion hid the other saved address. Each completion also cleared any newer input. Updating from current state preserves all confirmed additions without disturbing subsequent typing.
Closes #1636
## Validation
- npm test -- --run src/pages/studio/__tests__/Ops.test.tsx (6 passed)
- npx eslint src/pages/studio/Ops.tsx src/pages/studio/__tests__/Ops.test.tsx
- npm run build
- git diff --check
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [studio][ISSUE #1636] Preserve concurrent NameServer additions [rocketmq-dashboard]
Posted by "lizhimins (via GitHub)" <gi...@apache.org>.
lizhimins closed pull request #1638: [studio][ISSUE #1636] Preserve concurrent NameServer additions
URL: https://github.com/apache/rocketmq-dashboard/pull/1638
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [studio][ISSUE #1636] Preserve concurrent NameServer additions [rocketmq-dashboard]
Posted by "lizhimins (via GitHub)" <gi...@apache.org>.
lizhimins commented on PR #1638:
URL: https://github.com/apache/rocketmq-dashboard/pull/1638#issuecomment-5253030117
Closing: superseded by #1628, which serializes the same Ops NameServer add/remove/update paths with a stronger in-flight guard.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org