You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tinkerpop.apache.org by "Cole-Greer (via GitHub)" <gi...@apache.org> on 2025/03/07 22:11:32 UTC
[PR] TINKERPOP-3015 Use wildcard instead of Object for hasId/hasValue predicates [tinkerpop]
Cole-Greer opened a new pull request, #3068:
URL: https://github.com/apache/tinkerpop/pull/3068
https://issues.apache.org/jira/browse/TINKERPOP-3015
Update hasId(P) signature to accept P<?> instead of P<Object>. This allows for types such as P<String> which are not subtypes of P<Object> to be passed directly to this method, instead of going through the hasId(Object) overload and then casting to a P raw type. Note that the P special case handling still exists in hasId(Object) to cover any cases in which the correct overload is not identifiable at compile-time.
All of the above applies equivalently for hasValue().
This is non-breaking and targeting 3.7-dev as all it is doing is allowing more predicates to go into hasId(P) directly, and skipping the cast to the P raw-type.
My vote is VOTE +1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] TINKERPOP-3015 Use wildcard instead of Object for hasId/hasValue predicates [tinkerpop]
Posted by "Cole-Greer (via GitHub)" <gi...@apache.org>.
Cole-Greer merged PR #3068:
URL: https://github.com/apache/tinkerpop/pull/3068
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] TINKERPOP-3015 Use wildcard instead of Object for hasId/hasValue predicates [tinkerpop]
Posted by "vkagamlyk (via GitHub)" <gi...@apache.org>.
vkagamlyk commented on PR #3068:
URL: https://github.com/apache/tinkerpop/pull/3068#issuecomment-2709106684
VOTE +1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] TINKERPOP-3015 Use wildcard instead of Object for hasId/hasValue predicates [tinkerpop]
Posted by "spmallette (via GitHub)" <gi...@apache.org>.
spmallette commented on PR #3068:
URL: https://github.com/apache/tinkerpop/pull/3068#issuecomment-2710394541
interesting that nothing broke with that. could use a CHANGELOG but VOTE +1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org