[GitHub] [geode] Kris-10-0 commented on a change in pull request #7240: feature/GEODE-9836: SUNION Command Support

[GitBox <gi...@apache.org>]

Kris-10-0 commented on a change in pull request #7240:
URL: https://github.com/apache/geode/pull/7240#discussion_r779233010



##########
File path: geode-for-redis/src/integrationTest/java/org/apache/geode/redis/internal/commands/executor/set/AbstractSUnionIntegrationTest.java
##########
@@ -32,16 +38,17 @@
 
 import org.apache.geode.redis.ConcurrentLoopingThreads;
 import org.apache.geode.redis.RedisIntegrationTest;
-import org.apache.geode.test.awaitility.GeodeAwaitility;
 
 public abstract class AbstractSUnionIntegrationTest implements RedisIntegrationTest {
   private JedisCluster jedis;
-  private static final int REDIS_CLIENT_TIMEOUT =
-      Math.toIntExact(GeodeAwaitility.getTimeout().toMillis());
+  private static final String setKey1 = "{user1}setKey1";
+  private static final String[] setMembers1 = {"one", "two", "three", "four", "five"};
+  private static final String nonExistentSetKey = "{user1}nonExistentSet";
+  private static final String setKey2 = "{user1}setKey2";

Review comment:
       Yes! A lot of my previous tests use {user1} as a tag. Should I go ahead and change everything with this commit since its quick, create a new ticket, or just fix this and from now on use a different tag?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org