You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@turbine.apache.org by se...@apache.org on 2005/11/15 03:57:34 UTC

svn commit: r344295 - /jakarta/turbine/core/trunk/src/java/org/apache/turbine/services/session/TurbineSessionService.java

Author: seade
Date: Mon Nov 14 18:57:30 2005
New Revision: 344295

URL: http://svn.apache.org/viewcvs?rev=344295&view=rev
Log:
Deal with invalid sessions from the container.

Modified:
    jakarta/turbine/core/trunk/src/java/org/apache/turbine/services/session/TurbineSessionService.java

Modified: jakarta/turbine/core/trunk/src/java/org/apache/turbine/services/session/TurbineSessionService.java
URL: http://svn.apache.org/viewcvs/jakarta/turbine/core/trunk/src/java/org/apache/turbine/services/session/TurbineSessionService.java?rev=344295&r1=344294&r2=344295&view=diff
==============================================================================
--- jakarta/turbine/core/trunk/src/java/org/apache/turbine/services/session/TurbineSessionService.java (original)
+++ jakarta/turbine/core/trunk/src/java/org/apache/turbine/services/session/TurbineSessionService.java Mon Nov 14 18:57:30 2005
@@ -146,7 +146,17 @@
      */
     public User getUserFromSession(HttpSession session)
     {
-        return (User) session.getAttribute(User.SESSION_KEY);
+        // Not sure of other containers, but Tomcat 5.0.28 sometimes returns
+        // invalid sessions which will result in IllegalStateException when 
+        // session.getAttribute() is invoked below.
+        try
+        {
+            return (User) session.getAttribute(User.SESSION_KEY);
+        }
+        catch (IllegalStateException e)
+        {
+            return null;
+        }
     }
 
     /**



---------------------------------------------------------------------
To unsubscribe, e-mail: turbine-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: turbine-dev-help@jakarta.apache.org