You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "amorynan (via GitHub)" <gi...@apache.org> on 2024/10/24 10:18:07 UTC
[PR] [fix](bloomFilter)fix data type supported behavior same in FE and BE [doris]
amorynan opened a new pull request, #42416:
URL: https://github.com/apache/doris/pull/42416
## Proposed changes
fix create table stmt for properties: bloom_filter_columns, which should same with BE behavior
Issue Number: close #xxx
<!--Describe your changes.-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](bloomFilter)fix data type supported behavior same in FE and BE [doris]
Posted by "amorynan (via GitHub)" <gi...@apache.org>.
amorynan commented on PR #42416:
URL: https://github.com/apache/doris/pull/42416#issuecomment-2441337547
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](bloomFilter)fix data type supported behavior same in FE and BE [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #42416:
URL: https://github.com/apache/doris/pull/42416#issuecomment-2434875686
Thank you for your contribution to Apache Doris.
Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR)
Since 2024-03-18, the Document has been moved to [doris-website](https://github.com/apache/doris-website).
See [Doris Document](https://cwiki.apache.org/confluence/display/DORIS/Doris+Document).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](bloomFilter)fix data type supported behavior same in FE and BE [doris]
Posted by "amorynan (via GitHub)" <gi...@apache.org>.
amorynan commented on code in PR #42416:
URL: https://github.com/apache/doris/pull/42416#discussion_r1818905699
##########
fe/fe-core/src/main/java/org/apache/doris/common/util/PropertyAnalyzer.java:
##########
@@ -642,11 +642,18 @@ public static Set<String> analyzeBloomFilterColumns(Map<String, String> properti
if (column.getName().equalsIgnoreCase(bfColumn)) {
PrimitiveType type = column.getDataType();
- // tinyint/float/double columns don't support
+ // now we only support BloomFilter on (same behavior with BE):
+ // smallint/int/bigint/largeint
+ // string/varchar/char/variant
+ // date/datetime/datev2/datetimev2
+ // decimal/decimal32/decimal64/decimal128I/decimal256
+ // ipv4/ipv6
+ //
// key columns and none/replace aggregate non-key columns support
- if (type == PrimitiveType.TINYINT || type == PrimitiveType.FLOAT
- || type == PrimitiveType.DOUBLE || type == PrimitiveType.BOOLEAN
- || type.isComplexType()) {
+ if (!((type == PrimitiveType.SMALLINT || type == PrimitiveType.INT
Review Comment:
done!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](bloomFilter)fix data type supported behavior same in FE and BE [doris]
Posted by "amorynan (via GitHub)" <gi...@apache.org>.
amorynan commented on PR #42416:
URL: https://github.com/apache/doris/pull/42416#issuecomment-2439811974
run p0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](bloomFilter)fix data type supported behavior same in FE and BE [doris]
Posted by "eldenmoon (via GitHub)" <gi...@apache.org>.
eldenmoon commented on code in PR #42416:
URL: https://github.com/apache/doris/pull/42416#discussion_r1818300839
##########
fe/fe-core/src/main/java/org/apache/doris/common/util/PropertyAnalyzer.java:
##########
@@ -642,11 +642,18 @@ public static Set<String> analyzeBloomFilterColumns(Map<String, String> properti
if (column.getName().equalsIgnoreCase(bfColumn)) {
PrimitiveType type = column.getDataType();
- // tinyint/float/double columns don't support
+ // now we only support BloomFilter on (same behavior with BE):
+ // smallint/int/bigint/largeint
+ // string/varchar/char/variant
+ // date/datetime/datev2/datetimev2
+ // decimal/decimal32/decimal64/decimal128I/decimal256
+ // ipv4/ipv6
+ //
// key columns and none/replace aggregate non-key columns support
- if (type == PrimitiveType.TINYINT || type == PrimitiveType.FLOAT
- || type == PrimitiveType.DOUBLE || type == PrimitiveType.BOOLEAN
- || type.isComplexType()) {
+ if (!((type == PrimitiveType.SMALLINT || type == PrimitiveType.INT
Review Comment:
maybe add a function isSupportedBloomFilter(PrimitiveType type)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](bloomFilter)fix data type supported behavior same in FE and BE [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #42416:
URL: https://github.com/apache/doris/pull/42416#issuecomment-2443016081
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](bloomFilter)fix data type supported behavior same in FE and BE [doris]
Posted by "starocean999 (via GitHub)" <gi...@apache.org>.
starocean999 merged PR #42416:
URL: https://github.com/apache/doris/pull/42416
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](bloomFilter)fix data type supported behavior same in FE and BE [doris]
Posted by "amorynan (via GitHub)" <gi...@apache.org>.
amorynan commented on PR #42416:
URL: https://github.com/apache/doris/pull/42416#issuecomment-2437101679
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](bloomFilter)fix data type supported behavior same in FE and BE [doris]
Posted by "amorynan (via GitHub)" <gi...@apache.org>.
amorynan commented on PR #42416:
URL: https://github.com/apache/doris/pull/42416#issuecomment-2436710240
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](bloomFilter)fix data type supported behavior same in FE and BE [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #42416:
URL: https://github.com/apache/doris/pull/42416#issuecomment-2443016044
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](bloomFilter)fix data type supported behavior same in FE and BE [doris]
Posted by "amorynan (via GitHub)" <gi...@apache.org>.
amorynan commented on PR #42416:
URL: https://github.com/apache/doris/pull/42416#issuecomment-2434875854
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org