You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2020/04/27 09:54:07 UTC
[GitHub] [incubator-doris] morningman opened a new pull request #3404: [Thirdparty] Upgrade Google Guava lib to 29.0-jre
morningman opened a new pull request #3404:
URL: https://github.com/apache/incubator-doris/pull/3404
Fix #3403
This CL has passed our test environment, and looks running well.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] morningman commented on pull request #3404: [Thirdparty] Upgrade Google Guava lib to 29.0-jre
Posted by GitBox <gi...@apache.org>.
morningman commented on pull request #3404:
URL: https://github.com/apache/incubator-doris/pull/3404#issuecomment-620323972
> > The new version of Guava has move the `toStringHelper` from `Object` to `MoreObject`.
> > So I can't just upgrade the version without changing the code.
>
> OK, I See. Better explain this in commit message to let other developers know about it
OK
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] morningman commented on pull request #3404: [Thirdparty] Upgrade Google Guava lib to 29.0-jre
Posted by GitBox <gi...@apache.org>.
morningman commented on pull request #3404:
URL: https://github.com/apache/incubator-doris/pull/3404#issuecomment-620322378
> Hi @morningman
> Better to split this PR into two PR, one to change Guava, the other to change `Object` to `MoreObject`
The new version of Guava has move the `toStringHelper` from `Object` to `MoreObject`.
So I can't just upgrade the version without changing the code.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] imay commented on pull request #3404: [Thirdparty] Upgrade Google Guava lib to 29.0-jre
Posted by GitBox <gi...@apache.org>.
imay commented on pull request #3404:
URL: https://github.com/apache/incubator-doris/pull/3404#issuecomment-620315600
Hi @morningman
Better to split this PR into two PR, one to change Guava, the other to change `Object` to `MoreObject`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] imay commented on pull request #3404: [Thirdparty] Upgrade Google Guava lib to 29.0-jre
Posted by GitBox <gi...@apache.org>.
imay commented on pull request #3404:
URL: https://github.com/apache/incubator-doris/pull/3404#issuecomment-620323196
> The new version of Guava has move the `toStringHelper` from `Object` to `MoreObject`.
> So I can't just upgrade the version without changing the code.
OK, I See. Better explain this in commit message to let other developers know about it
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org