You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "dongjoon-hyun (via GitHub)" <gi...@apache.org> on 2026/06/24 18:54:58 UTC
[PR] [SPARK-57671][BUILD] Upgrade `tink` to 1.22.0 [spark]
dongjoon-hyun opened a new pull request, #56750:
URL: https://github.com/apache/spark/pull/56750
### What changes were proposed in this pull request?
This PR upgrades the `Tink` dependency to 1.22.0.
### Why are the changes needed?
To pick up the latest bug fixes and improvements:
- https://github.com/tink-crypto/tink-java/releases/tag/v1.21.0
- Added `addAnnotations` to `KeysetHandle.Builder` and `getAnnotationsOrNull`
- Added support for the `ML-DSA-87` signature algorithm
- `SignaturePemKeysetReader` now handles `ML-DSA-65`, `ML-DSA-87`, and `Ed25519`
- https://github.com/tink-crypto/tink-java/releases/tag/v1.22.0
- https://github.com/tink-crypto/tink-java/issues/68
- Key derivation no longer runs inside a synchronized block in `MutableKeyDerivationRegistry`
- Added `SLH-DSA` signature parameters and the `ML-DSA-44` signature primitive with PEM import
- Introduced `SignatureJwkSetConverter` for signature public keys to/from JWK sets
- `class` files now correctly target Java 11 (major version 55)
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
Pass the CIs with the existing tests.
### Was this patch authored or co-authored using generative AI tooling?
Generated-by: Claude Code (claude-opus-4-8)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-57671][BUILD] Upgrade `tink` to 1.22.0 [spark]
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #56750:
URL: https://github.com/apache/spark/pull/56750#issuecomment-4793927329
Thank you, @uros-b !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-57671][BUILD] Upgrade `tink` to 1.22.0 [spark]
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun closed pull request #56750: [SPARK-57671][BUILD] Upgrade `tink` to 1.22.0
URL: https://github.com/apache/spark/pull/56750
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-57671][BUILD] Upgrade `tink` to 1.22.0 [spark]
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #56750:
URL: https://github.com/apache/spark/pull/56750#issuecomment-4794379350
Merged to master for Spark 5.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org