You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by ahshahid <gi...@git.apache.org> on 2016/02/03 21:49:39 UTC

[GitHub] spark pull request: [SPARK-13116][SQL] TungstenAggregate though it...

GitHub user ahshahid opened a pull request:

    https://github.com/apache/spark/pull/11058

    [SPARK-13116][SQL] TungstenAggregate though it is supposedly capable …

    …of all processing unsafe & safe rows, fails if the input is safe rows.
    
    Allowing targeted mutable row to be set with field values if the target row is Unsafe.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/SnappyDataInc/spark SPARK-13116

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/11058.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #11058
    
----
commit 05f0626e8aeeec07776d92644eb2e8078320e436
Author: Asif Shahid <as...@snappydata.io>
Date:   2016-02-03T20:43:31Z

    [SPARK-13116][SQL] TungstenAggregate though it is supposedly capable of all processing unsafe & safe rows, fails if the input is safe rows.
    Allowing targeted mutable row to be set with field values if the target row is Unsafe.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-13116][SQL] TungstenAggregate though it...

Posted by ahshahid <gi...@git.apache.org>.
Github user ahshahid closed the pull request at:

    https://github.com/apache/spark/pull/11058


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-13116][SQL] TungstenAggregate though it...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:

    https://github.com/apache/spark/pull/11058#issuecomment-179459249
  
    Can one of the admins verify this patch?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-13116][SQL] TungstenAggregate though it...

Posted by davies <gi...@git.apache.org>.
Github user davies commented on the pull request:

    https://github.com/apache/spark/pull/11058#issuecomment-185533170
  
    @ahshahid Do you mind close this PR?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-13116][SQL] TungstenAggregate though it...

Posted by ahshahid <gi...@git.apache.org>.
Github user ahshahid commented on the pull request:

    https://github.com/apache/spark/pull/11058#issuecomment-179462715
  
    @davies 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-13116][SQL] TungstenAggregate though it...

Posted by ahshahid <gi...@git.apache.org>.
Github user ahshahid commented on the pull request:

    https://github.com/apache/spark/pull/11058#issuecomment-191915798
  
    Hi ,
    Extremely sorry for the delay.
    I am fine with it closing the ticket , but just to be clear , the issue
    which I described is there , just that it surfaces if the code gen throws
    exception.
    Regards
    Asif
    
    
    On Wed, Feb 17, 2016 at 8:01 PM, Davies Liu <no...@github.com>
    wrote:
    
    > @ahshahid <https://github.com/ahshahid> Do you mind close this PR?
    >
    > —
    > Reply to this email directly or view it on GitHub
    > <https://github.com/apache/spark/pull/11058#issuecomment-185533170>.
    >



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-13116][SQL] TungstenAggregate though it...

Posted by ahshahid <gi...@git.apache.org>.
Github user ahshahid commented on the pull request:

    https://github.com/apache/spark/pull/11058#issuecomment-179479583
  
    Looks like code which we had contained TungstenAggregate.canProcessSafeRows as true. But in the latest codebase, these methods are not there.  
    I have test which showed up this issue. I will check if I get the problem with the latest codebase of spark.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-13116][SQL] TungstenAggregate though it...

Posted by JoshRosen <gi...@git.apache.org>.
Github user JoshRosen commented on the pull request:

    https://github.com/apache/spark/pull/11058#issuecomment-185523147
  
    Ping @ahshahid, any update here?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-13116][SQL] TungstenAggregate though it...

Posted by davies <gi...@git.apache.org>.
Github user davies commented on the pull request:

    https://github.com/apache/spark/pull/11058#issuecomment-179466465
  
    @ahshahid I think may only Spark 1.6 has this issue, in Spark master, every operator should output UnsafeRow.
    
    In 1.6 branch, a quick fix could be let TungstenAggregate only accept UnsafeRow, then there will be ToUnsafe operator inserted before TungstenAggregate.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org