You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by GitBox <gi...@apache.org> on 2022/03/03 18:53:15 UTC
[GitHub] [solr] risdenk commented on a change in pull request #711: SOLR-14920: Spotless formatting for core - test only
risdenk commented on a change in pull request #711:
URL: https://github.com/apache/solr/pull/711#discussion_r818969974
##########
File path: solr/core/src/test/org/apache/solr/cloud/api/collections/SplitByPrefixTest.java
##########
@@ -51,15 +50,13 @@
@BeforeClass
public static void setupCluster() throws Exception {
- System.setProperty("managed.schema.mutable", "true"); // needed by cloud-managed config set
+ System.setProperty("managed.schema.mutable", "true"); // needed by cloud-managed config set
// clould-managed has the copyField from ID to id_prefix
// cloud-minimal does not and thus histogram should be driven from the "id" field directly
String configSetName = random().nextBoolean() ? "cloud-minimal" : "cloud-managed";
- configureCluster(1)
- .addConfig("conf", configset(configSetName)) // cloud-managed has the id copyfield to id_prefix
- .configure();
+ configureCluster(1).addConfig("conf", configset(configSetName)).configure();
Review comment:
Line 55 has the same comment so looks like some duplication at some point.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org