You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "Quatters (via GitHub)" <gi...@apache.org> on 2024/02/29 09:51:51 UTC
[I] "Series Style" control not working [superset]
Quatters opened a new issue, #27302:
URL: https://github.com/apache/superset/issues/27302
### Bug description
There is control in Line Chart called "Series style". When you select any of the option it includes the chart is not re-rendered, nothing happens.
### How to reproduce the bug
1. Create Line Chart.
2. Go to "Customize" tab.
3. Search for "Series style" control.
4. Select any option.
5. Nothing happens.
### Screenshots/recordings
### Superset version
3.1.1
### Python version
Not applicable
### Node version
Not applicable
### Browser
Not applicable
### Additional context
_No response_
### Checklist
- [X] I have searched Superset docs and Slack and didn't find a solution to my problem.
- [X] I have searched the GitHub issue tracker and didn't find a similar bug report.
- [ ] I have checked Superset's logs for errors and if I found a relevant Python stacktrace, I included it here as text in the "additional context" section.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [I] "Series Style" control not working [superset]
Posted by "vedantprajapati (via GitHub)" <gi...@apache.org>.
vedantprajapati commented on issue #27302:
URL: https://github.com/apache/superset/issues/27302#issuecomment-2934899759
> This problem is a little bit more complex. The Line chart variations (normal, smooth, step) were broken into multiple charts and for that reason this control shouldn't exist. To add to the problem, the Area chart, which has the exact same variations, was not broken into multiple charts and this control works. In order to fix this mess, we need to decide if we want to have multiple charts and disable this control or a single chart which accepts style variations. Independent of the resolution, this will require a migration.
>
> [@rusackas](https://github.com/rusackas) [@villebro](https://github.com/villebro) [@kgabryje](https://github.com/kgabryje) [@geido](https://github.com/geido)
@geido
We ran into this a few months ago. as a temporary fix, we overrided the generic class with visibility -> true and then made modifications on a more granular level to hide this for line charts.
<img width="735" alt="Image" src="https://github.com/user-attachments/assets/db31bf20-4988-4768-a2a0-c4520c795e5c" />
geotab/controlPanel.tsx
```
import controlPanel from '../Timeseries/Regular/Line/controlPanel';
// Define the createGenericControlPanel function outside of the class
const createRemovedSeriesStyleControlPanel = {
...controlPanel,
controlPanelSections: controlPanel.controlPanelSections.map(section => {
// Check if section is not null before accessing its properties
if (section === null) {
return section;
}
return {
...section,
controlSetRows: section.controlSetRows?.map((row: any[]) =>
row.map(item => {
if (item?.name === 'seriesType') {
return {
...item,
config: {
...item.config,
visibility: () => true,
},
};
}
return item;
}),
),
};
}),
};
export default createRemovedSeriesStyleControlPanel;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [I] "Series Style" control not working [superset]
Posted by "geido (via GitHub)" <gi...@apache.org>.
geido commented on issue #27302:
URL: https://github.com/apache/superset/issues/27302#issuecomment-2698539000
> The code below seems to change the type to line unconditionally, so when I remove that code, it seems to work fine.
>
> /var/local/idk2/heartset/superset-frontend/plugins/plugin-chart-echarts/src/Timeseries/Regular/Line/index.ts
>
> > seriesType: EchartsTimeseriesSeriesType.Line,
>
> ```
> const lineTransformProps = (chartProps: EchartsTimeseriesChartProps) =>
> transformProps({
> ...chartProps,
> formData: {
> ...chartProps.formData,
> seriesType: EchartsTimeseriesSeriesType.Line,
> },
> });
> ```
@chkang-idk2 if you would like to look deeper into this problem, considering what @michael-s-molina has written about the issues we have encountered, feel free to open a PR. It would be super helpful!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [I] "Series Style" control not working [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on issue #27302:
URL: https://github.com/apache/superset/issues/27302#issuecomment-2259344851
Normally I'd threaten to close this out as stale by now, but this is still relevant today, and should probably be put forward as a SIP to either consolidate or bifurcate these chart types once and for all. Any interested parties?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [I] "Series Style" control not working [superset]
Posted by "michael-s-molina (via GitHub)" <gi...@apache.org>.
michael-s-molina commented on issue #27302:
URL: https://github.com/apache/superset/issues/27302#issuecomment-1971462375
This problem is a little bit more complex. The Line chart variations (normal, smooth, step) were broken into multiple charts and for that reason this control shouldn't exist. To add to the problem, the Area chart, which has the exact same variations, was not broken into multiple charts and this control works. In order to fix this mess, we need to decide if we want to have multiple charts and disable this control or a single chart which accepts style variations. Independent of the resolution, this will require a migration.
@rusackas @villebro @kgabryje @geido
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [I] "Series Style" control not working [superset]
Posted by "geido (via GitHub)" <gi...@apache.org>.
geido commented on issue #27302:
URL: https://github.com/apache/superset/issues/27302#issuecomment-2935744739
> let me know if we want to make this change? I can make a PR. @geido
Sure. That would be great. It is going to be easier to discuss the changes on a PR. Thank you!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [I] "Series Style" control not working [superset]
Posted by "vedantprajapati (via GitHub)" <gi...@apache.org>.
vedantprajapati commented on issue #27302:
URL: https://github.com/apache/superset/issues/27302#issuecomment-2935730600
let me know if we're want to make this change? I can make a PR. @geido
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [I] "Series Style" control not working [superset]
Posted by "geido (via GitHub)" <gi...@apache.org>.
geido commented on issue #27302:
URL: https://github.com/apache/superset/issues/27302#issuecomment-1971523099
I agree this requires further discussion. Curious what was the decision driving the Line chart to be broken into multiple charts
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [I] "Series Style" control not working [superset]
Posted by "michael-s-molina (via GitHub)" <gi...@apache.org>.
michael-s-molina commented on issue #27302:
URL: https://github.com/apache/superset/issues/27302#issuecomment-1971531978
Just for reference, here's the Area chart and the control in action:
https://github.com/apache/superset/assets/70410625/0f3d21b3-8a72-49e9-b006-9575e8c476be
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [I] "Series Style" control not working [superset]
Posted by "vedantprajapati (via GitHub)" <gi...@apache.org>.
vedantprajapati commented on issue #27302:
URL: https://github.com/apache/superset/issues/27302#issuecomment-2937772523
Created ^ 🥳 @geido
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [I] "Series Style" control not working [superset]
Posted by "Quatters (via GitHub)" <gi...@apache.org>.
Quatters commented on issue #27302:
URL: https://github.com/apache/superset/issues/27302#issuecomment-1970780227
When I fixed this control locally, I saw that all options duplicate existing charts (Line -> Line Chart, Scatter -> Scatter Plot, Smooth Line -> Smooth Line, Bar -> Bar Chart, Step - [start, middle, end] -> Stepped Line). Maybe we can remove it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [I] "Series Style" control not working [superset]
Posted by "chkang-idk2 (via GitHub)" <gi...@apache.org>.
chkang-idk2 commented on issue #27302:
URL: https://github.com/apache/superset/issues/27302#issuecomment-2658515380
When I remove the code below, it looks like it's working fine
/var/local/idk2/heartset/superset-frontend/plugins/plugin-chart-echarts/src/Timeseries/Regular/Line/index.ts
> seriesType: EchartsTimeseriesSeriesType.Line,
```
const lineTransformProps = (chartProps: EchartsTimeseriesChartProps) =>
transformProps({
...chartProps,
formData: {
...chartProps.formData,
seriesType: EchartsTimeseriesSeriesType.Line,
},
});
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [I] "Series Style" control not working [superset]
Posted by "sfirke (via GitHub)" <gi...@apache.org>.
sfirke commented on issue #27302:
URL: https://github.com/apache/superset/issues/27302#issuecomment-3503730170
I'm glad I found this thread, I was trying to make a stepped line chart and was confused by the selector not working. Then I saw mentioned above this is its own line chart type!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [I] "Series Style" control not working [superset]
Posted by "sadpandajoe (via GitHub)" <gi...@apache.org>.
sadpandajoe closed issue #27302: "Series Style" control not working
URL: https://github.com/apache/superset/issues/27302
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org