You are viewing a plain text version of this content. The canonical link for it is here.
Posted to users@subversion.apache.org by Gisbert Amm <gi...@webde.de> on 2006/05/19 13:52:43 UTC
pre-commit hangs
I have a pre-commit hook that checks for tabs in Python files and
rejects the commit if it finds any, writing a line to stderr for every
file so that the user knows what to fix. It worked so far but the
process always hung when the amount of error messages the script
returned was bigger than a certain size.
After some searching I found out that the process hangs because there's
too much data on stderr, more than the stderr buffer size, which is the
system's default page size (4096 Byte on my system). It is similar to
this Apache vulnerability: http://www.securityfocus.com/bid/5787/info.
I've tried out this exploit; it does no longer work with Apache 2.0.52.
Therefore I consider Subversion the culprit.
As a workaround, I do check how much data the hook script wants to write
to stderr and cut it, if it's too long. However, I'd rather see this
fixed cleanly.
Has anyone else experienced the same and is it probably already reported
as an issue? Otherwise I'd file a bug report.
Regards,
Gisbert Amm
---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@subversion.tigris.org
For additional commands, e-mail: users-help@subversion.tigris.org
Re: pre-commit hangs
Posted by Gisbert Amm <gi...@webde.de>.
Garrett Rooney wrote:
> On 5/19/06, Gisbert Amm <gi...@webde.de> wrote:
>
>> I have a pre-commit hook that checks for tabs in Python files and
>> rejects the commit if it finds any, writing a line to stderr for every
>> file so that the user knows what to fix. It worked so far but the
>> process always hung when the amount of error messages the script
>> returned was bigger than a certain size.
>>
>> After some searching I found out that the process hangs because there's
>> too much data on stderr, more than the stderr buffer size, which is the
>> system's default page size (4096 Byte on my system). It is similar to
>> this Apache vulnerability: http://www.securityfocus.com/bid/5787/info.
>> I've tried out this exploit; it does no longer work with Apache 2.0.52.
>> Therefore I consider Subversion the culprit.
>>
>> As a workaround, I do check how much data the hook script wants to write
>> to stderr and cut it, if it's too long. However, I'd rather see this
>> fixed cleanly.
>>
>> Has anyone else experienced the same and is it probably already reported
>> as an issue? Otherwise I'd file a bug report.
>
>
> What version of Subversion are you seeing the problem with? I believe
> this has been fixed in 1.3.x.
>
> -garrett
It's 1.2.3 (r15833).
I'll ask the Sysadmin to upgrade.
Sorry for first answering off list. Monday morning failure ;)
Thanks,
Gisbert Amm
---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@subversion.tigris.org
For additional commands, e-mail: users-help@subversion.tigris.org
Re: pre-commit hangs
Posted by Garrett Rooney <ro...@electricjellyfish.net>.
On 5/19/06, Gisbert Amm <gi...@webde.de> wrote:
> I have a pre-commit hook that checks for tabs in Python files and
> rejects the commit if it finds any, writing a line to stderr for every
> file so that the user knows what to fix. It worked so far but the
> process always hung when the amount of error messages the script
> returned was bigger than a certain size.
>
> After some searching I found out that the process hangs because there's
> too much data on stderr, more than the stderr buffer size, which is the
> system's default page size (4096 Byte on my system). It is similar to
> this Apache vulnerability: http://www.securityfocus.com/bid/5787/info.
> I've tried out this exploit; it does no longer work with Apache 2.0.52.
> Therefore I consider Subversion the culprit.
>
> As a workaround, I do check how much data the hook script wants to write
> to stderr and cut it, if it's too long. However, I'd rather see this
> fixed cleanly.
>
> Has anyone else experienced the same and is it probably already reported
> as an issue? Otherwise I'd file a bug report.
What version of Subversion are you seeing the problem with? I believe
this has been fixed in 1.3.x.
-garrett
---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@subversion.tigris.org
For additional commands, e-mail: users-help@subversion.tigris.org