You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "codecov[bot] (via GitHub)" <gi...@apache.org> on 2023/06/26 23:41:42 UTC

[GitHub] [superset] codecov[bot] commented on pull request #24520: fix(native filter): undefined filter dependencies

codecov[bot] commented on PR #24520:
URL: https://github.com/apache/superset/pull/24520#issuecomment-1608468076

   ## [Codecov](https://app.codecov.io/gh/apache/superset/pull/24520?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   > Merging [#24520](https://app.codecov.io/gh/apache/superset/pull/24520?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (cc227d6) into [master](https://app.codecov.io/gh/apache/superset/commit/e20b69587f351056f5f997c19f438b12302dcf0b?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (e20b695) will **increase** coverage by `0.01%`.
   > The diff coverage is `90.90%`.
   
   > :exclamation: Current head cc227d6 differs from pull request most recent head 6d764d9. Consider uploading reports for the commit 6d764d9 to get more accurate results
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #24520      +/-   ##
   ==========================================
   + Coverage   69.06%   69.07%   +0.01%     
   ==========================================
     Files        1901     1902       +1     
     Lines       74019    74025       +6     
     Branches     8116     8118       +2     
   ==========================================
   + Hits        51121    51134      +13     
   + Misses      20787    20779       -8     
   - Partials     2111     2112       +1     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | javascript | `55.73% <90.90%> (+0.02%)` | :arrow_up: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://app.codecov.io/gh/apache/superset/pull/24520?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [superset-frontend/src/SqlLab/fixtures.ts](https://app.codecov.io/gh/apache/superset/pull/24520?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9maXh0dXJlcy50cw==) | `100.00% <ø> (ø)` | |
   | [.../nativeFilters/FilterCard/useFilterDependencies.ts](https://app.codecov.io/gh/apache/superset/pull/24520?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQ2FyZC91c2VGaWx0ZXJEZXBlbmRlbmNpZXMudHM=) | `88.88% <50.00%> (-11.12%)` | :arrow_down: |
   | [...core/src/time-format/utils/denormalizeTimestamp.ts](https://app.codecov.io/gh/apache/superset/pull/24520?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY29yZS9zcmMvdGltZS1mb3JtYXQvdXRpbHMvZGVub3JtYWxpemVUaW1lc3RhbXAudHM=) | `100.00% <100.00%> (ø)` | |
   | [...i-core/src/time-format/utils/normalizeTimestamp.ts](https://app.codecov.io/gh/apache/superset/pull/24520?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY29yZS9zcmMvdGltZS1mb3JtYXQvdXRpbHMvbm9ybWFsaXplVGltZXN0YW1wLnRz) | `100.00% <100.00%> (ø)` | |
   | [superset-frontend/src/SqlLab/reducers/sqlLab.js](https://app.codecov.io/gh/apache/superset/pull/24520?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9yZWR1Y2Vycy9zcWxMYWIuanM=) | `48.25% <100.00%> (+4.98%)` | :arrow_up: |
   
   :mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org