[GitHub] [hive] EugeneChung commented on a change in pull request #1919: HIVE-23458: Introduce unified thread pool for scheduled jobs

[GitBox <gi...@apache.org>]

EugeneChung commented on a change in pull request #1919:
URL: https://github.com/apache/hive/pull/1919#discussion_r568842878



##########
File path: common/src/java/org/apache/hadoop/hive/conf/HiveConf.java
##########
@@ -746,6 +746,8 @@ private static void populateLlapDaemonVarsSet(Set<String> llapDaemonVarsSetLocal
         "This value must not contain any special character used in HDFS URI (e.g., ':', '%', '/' etc). \n" +
         "The user has to be aware that the dynamic partition value should not contain this value to avoid confusions."),
     DEFAULT_ZOOKEEPER_PARTITION_NAME("hive.lockmgr.zookeeper.default.partition.name", "__HIVE_DEFAULT_ZOOKEEPER_PARTITION__", ""),
+    HIVE_EXEC_SCHEDULED_POOL_NUM_THREADS("hive.exec.scheduler.num.threads", 10,

Review comment:
       Yes, the role of corepoolsize is exactly what you understand.
   
   The reason I set to 10 is just because `metastore.thread.pool.size` is 10. I think 2 would be good.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org