[GitHub] [arrow] alamb commented on a change in pull request #9771: ARROW-12043: [Rust] [Parquet] Write FSB arrays

[GitBox <gi...@apache.org>]

alamb commented on a change in pull request #9771:
URL: https://github.com/apache/arrow/pull/9771#discussion_r599084717



##########
File path: rust/parquet/src/arrow/arrow_writer.rs
##########
@@ -189,11 +199,12 @@ fn write_leaves(
         ArrowDataType::Float16 => Err(ParquetError::ArrowError(
             "Float16 arrays not supported".to_string(),
         )),
-        ArrowDataType::FixedSizeList(_, _)
-        | ArrowDataType::FixedSizeBinary(_)
-        | ArrowDataType::Union(_) => Err(ParquetError::NYI(
-            "Attempting to write an Arrow type that is not yet implemented".to_string(),
-        )),
+        ArrowDataType::FixedSizeList(_, _) | ArrowDataType::Union(_) => {
+            Err(ParquetError::NYI(
+                "Attempting to write an Arrow type that is not yet implemented"
+                    .to_string(),

Review comment:
       ```suggestion
                   format!("Attempting to write an Arrow type {?} to parquet that is not yet implemented", array.data_type())
   ```
   
   ( I realize the error message is not changed by this PR I just saw it when looking)




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org