You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Greg Mann <gr...@mesosphere.io> on 2015/11/30 19:49:03 UTC

Review Request 40787: Removed obsolete TODO in mesos.proto.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40787/
-----------------------------------------------------------

Review request for mesos and Timothy Chen.


Repository: mesos


Description
-------

Removed obsolete TODO in mesos.proto.


Diffs
-----

  include/mesos/mesos.proto 27971fea6935b82d7034397edaa7a37edb1f6f38 

Diff: https://reviews.apache.org/r/40787/diff/


Testing
-------


Thanks,

Greg Mann


Re: Review Request 40787: Removed obsolete TODO in mesos.proto.

Posted by Timothy Chen <tn...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40787/#review108444
-----------------------------------------------------------

Ship it!


Ship It!

- Timothy Chen


On Nov. 30, 2015, 6:49 p.m., Greg Mann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40787/
> -----------------------------------------------------------
> 
> (Updated Nov. 30, 2015, 6:49 p.m.)
> 
> 
> Review request for mesos and Timothy Chen.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Removed obsolete TODO in mesos.proto.
> 
> 
> Diffs
> -----
> 
>   include/mesos/mesos.proto 27971fea6935b82d7034397edaa7a37edb1f6f38 
> 
> Diff: https://reviews.apache.org/r/40787/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Greg Mann
> 
>


Re: Review Request 40787: Removed obsolete TODO in mesos.proto.

Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40787/#review108442
-----------------------------------------------------------


Patch looks great!

Reviews applied: [40787]

Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export COMPILER=gcc; ./support/docker_build.sh

- Mesos ReviewBot


On Nov. 30, 2015, 6:49 p.m., Greg Mann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40787/
> -----------------------------------------------------------
> 
> (Updated Nov. 30, 2015, 6:49 p.m.)
> 
> 
> Review request for mesos and Timothy Chen.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Removed obsolete TODO in mesos.proto.
> 
> 
> Diffs
> -----
> 
>   include/mesos/mesos.proto 27971fea6935b82d7034397edaa7a37edb1f6f38 
> 
> Diff: https://reviews.apache.org/r/40787/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Greg Mann
> 
>